1. 05 Sep, 2022 1 commit
  2. 02 Sep, 2022 2 commits
  3. 01 Sep, 2022 1 commit
  4. 31 Aug, 2022 2 commits
    • Fix 3 ErrorProneStyle findings: · 4d4af376
      * Non-standard parameter comment; prefer `/* paramName= */ arg`
        (see http://go/bugpattern/ParameterComment) (3 times)
      
      This CL looks good? Just LGTM and Approve it!
      This CL doesn’t look good? This is what you can do:
      * Revert this CL, by replying "REVERT: <provide reason>"
      * File a bug under go/error-prone-bug for category ErrorProneStyle if there's an issue with the CL content.
      * File a bug under go/rosie-bug if there's an issue with how the CL was managed.
      * Revert this CL and not get a CL that cleans up these paths in the future by
      replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to
      opt out the respective paths in your CL Robot configuration instead:
      go/clrobot-opt-out.
      
      This CL was generated by CL Robot - a tool that cleans up code findings
      (go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/java/com/google/android/libraries/media/METADATA which is reachable following include_presubmits from //depot/google3/third_party/java_src/android_libs/media/METADATA.
      Anything wrong with the signup? File a bug at go/clrobot-bug.
      
      #codehealth
      
      Tested:
          Local presubmit tests passed.
      PiperOrigin-RevId: 471198016
      (cherry picked from commit bac7d697)
      Googler committed
    • Add @SuppressWarnings to nullness errors detected by a newer version of the Checker Framework · ba01d04e
      PiperOrigin-RevId: 471137219
      (cherry picked from commit 90e684a6)
      Googler committed
  5. 30 Aug, 2022 8 commits
    • Effect: Add some FrameProcessor javadoc. · 53b1cabe
      In particular, make it a bit more clear that "rendering" and "releasing" frames are
      related concepts, and how they differ from one another in conjunction with frame
      dropping.
      
      PiperOrigin-RevId: 471037733
      (cherry picked from commit e6a1936b)
      huangdarwin committed
    • HDR: Use factory for MatrixTransformationProcessor. · 4c8d22fe
      Separate MatrixTransformationProcessor constructors by color input and output.
      
      PiperOrigin-RevId: 471034768
      (cherry picked from commit a8e814ab)
      huangdarwin committed
    • Fix 19 ErrorProneStyle findings: · fc8edfcd
      * Non-standard parameter comment; prefer `/* paramName= */ arg`
        (see http://go/bugpattern/ParameterComment) (19 times)
      
      This CL looks good? Just LGTM and Approve it!
      This CL doesn’t look good? This is what you can do:
      * Revert this CL, by replying "REVERT: <provide reason>"
      * File a bug under go/error-prone-bug for category ErrorProneStyle if there's an issue with the CL content.
      * File a bug under go/rosie-bug if there's an issue with how the CL was managed.
      * Revert this CL and not get a CL that cleans up these paths in the future by
      replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to
      opt out the respective paths in your CL Robot configuration instead:
      go/clrobot-opt-out.
      
      This CL was generated by CL Robot - a tool that cleans up code findings
      (go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/java/com/google/android/libraries/media/METADATA which is reachable following include_presubmits from //depot/google3/third_party/java_src/android_libs/media/METADATA.
      Anything wrong with the signup? File a bug at go/clrobot-bug.
      
      #codehealth
      
      Tested:
          Local presubmit tests passed.
      PiperOrigin-RevId: 471022923
      (cherry picked from commit 674b3d45)
      Googler committed
    • Add static Grayscale and Inverted RGB Filter. · 8e90496d
      PiperOrigin-RevId: 471017440
      (cherry picked from commit 9f67ce4e)
      leonwind committed
    • Update first frame instructions. · 2e4ec7a6
      PiperOrigin-RevId: 471008623
      (cherry picked from commit cb60f506)
      huangdarwin committed
    • Remove media3-only line from exoplayer2 `build.gradle` file · b6fecfc1
      #minor-release
      
      PiperOrigin-RevId: 470999044
      (cherry picked from commit e285e707)
      ibaker committed
    • Fix 1 ErrorProneStyle finding: · 1071a91d
      * Non-standard parameter comment; prefer `/* paramName= */ arg`
        (see http://go/bugpattern/ParameterComment)
      
      This CL looks good? Just LGTM and Approve it!
      This CL doesn’t look good? This is what you can do:
      * Revert this CL, by replying "REVERT: <provide reason>"
      * File a bug under go/error-prone-bug for category ErrorProneStyle if there's an issue with the CL content.
      * File a bug under go/rosie-bug if there's an issue with how the CL was managed.
      * Revert this CL and not get a CL that cleans up these paths in the future by
      replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to
      opt out the respective paths in your CL Robot configuration instead:
      go/clrobot-opt-out.
      
      This CL was generated by CL Robot - a tool that cleans up code findings
      (go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/java/com/google/android/libraries/media/METADATA which is reachable following include_presubmits from //depot/google3/third_party/java_src/android_libs/media/METADATA.
      Anything wrong with the signup? File a bug at go/clrobot-bug.
      
      #codehealth
      
      Tested:
          Local presubmit tests passed.
      PiperOrigin-RevId: 470953422
      (cherry picked from commit f26e5d4c)
      Googler committed
    • Update color info mismatch test · 585dfaf5
      This should now expect transformation to succeed.
      
      PiperOrigin-RevId: 470950411
      (cherry picked from commit 1023254d)
      andrewlewis committed
  6. 26 Aug, 2022 2 commits
    • Log instead of throwing for transfer mismatch · 179eafb2
      PiperOrigin-RevId: 470354448
      (cherry picked from commit f1a3a40e)
      andrewlewis committed
    • Fix ExternalTextureManager: repeated queueing input frame in preview · 0f271c20
      TL;DR: we should check if there are new frames available to queue to the
      ExternalTextureProcessor before actually queueing a frame.
      
      The overall flow on the external texture processor:
      
      - `SurfaceTexture.onFrameAvailable` is called on `ExtTexMgr`, and
        - it calls `updateTexImage()`, and sets `frame`
        - it calls `maybeQueueFrameToExtTexProc()`
          - the frame is queued to `ExtTexProc` if `frame` is set
      
        - From `ExtTexProc.queueInputFrame()`:
          - notifies the `frameProcessorListener` of available frame
          - notifies the `inputListener` of `onReadyToAcceptInputFrame`
            - (`ExtTexMgr` is the listener), it calls `maybeQueueFrameToExtTexProc()`
             again
      
      -- Parallelly --
      - `ExtTexProc` calls `inputListener.onInputFrameProcessed`, when the frame is
      released
        - (`ExtTexMgr` is the listener), sets `frame` to `null`
      
      *Problem*
      
      This logic relies on `frame` to be cleared at the right time.
      
      In transformer, it's OK b/c `ExtTexProc` release the frame immediately in
      `queueInputFrame()` and calls `onInputFrameProcessed` which also reset `frame`
      
      But in previewing, the frame is not released for a while, up to 10 ms.
      In this case, `frame` will not reset in this 10 ms, and
      `maybeQueueFrameToExtTexProc()` is repeatedly queueing the same input frame.
      
      PiperOrigin-RevId: 470211620
      (cherry picked from commit a8c54dd3)
      claincly committed
  7. 25 Aug, 2022 4 commits
  8. 24 Aug, 2022 2 commits
    • Fix missing id error · 0e7227df
      PiperOrigin-RevId: 469750922
      (cherry picked from commit 2c70383d)
      rohks committed
    • HDR: Add PQ support. · c827c80b
      Use the PQ OETF and EOTF to ensure that intermediate fragment shader operations
      using PQ are in linear BT.2020 rather than PQ and HLG-1 BT.2020.
      
      Also, swap the OETF and EOTF in shaders, as they were used incorrectly before
      
      Manually tested by verifying transformer demo HLG and PQ videos look the same with and without this CL, including with a BitmapOverlayProcessor enabled to test flows both with one MatrixTransformationProcessor that skips HDR TFs, and with one that doesn't.
      
      PiperOrigin-RevId: 469736067
      (cherry picked from commit a2139109)
      huangdarwin committed
  9. 23 Aug, 2022 3 commits
  10. 22 Aug, 2022 1 commit
  11. 19 Aug, 2022 3 commits
  12. 18 Aug, 2022 3 commits
    • Fix the command sample size given to trackOutput. · 5c95b41d
      Remove the manual overwriting of Note ON events that have 0 velocity with Note OFF. JSyn handles this already.
      
      - The implementation of "running status" means that the amount of bytes read from the file differ from the size of the sample that ends up in the decoder. The decoder sample contains the applied running status (status of previous event), which the file bytes don't contain.
      
      PiperOrigin-RevId: 468537659
      (cherry picked from commit 53218b50)
      hmzh committed
    • Allow frame release to be controlled outside FrameProcessor. · 884e3763
      Adds a method to FrameProcessor.Listener to be called when an
      output frame is available and a method releaseOutputFrame in
      FrameProcessor allowing the caller to trigger release of the
      oldest available output frame at a given timestamp. Late frames
      or frames with unset release times are dropped in the
      FinalMatrixTransformationProcessorWrapper.
      
      More than one output frame can become available before they are
      released if the penultimate GlTextureProcessor is capable of producing
      multiple output frames. Processing continues while waiting for
      releaseOutputFrame to be called. Frame release tasks are prioritized
      over other tasks.
      
      PiperOrigin-RevId: 468473072
      (cherry picked from commit 2c063546)
      Googler committed
    • HDR: Clamp YUV to RGB conversion. · 4c36dae9
      Manually tested using transformer demo HLG videos. Before this CL, RGB values after the YUV to RGB conversion reached up to 1.025. After this CL, RGB values correctly clamp at 1.0.
      
      PiperOrigin-RevId: 468426092
      (cherry picked from commit 32ee4480)
      huangdarwin committed
  13. 17 Aug, 2022 2 commits
  14. 16 Aug, 2022 3 commits
  15. 15 Aug, 2022 3 commits
    • Allow high-priority tasks to be executed before other tasks. · 6d099598
      This is needed as a pre-requisite for allowing MCVR to control
      FrameProcessor frame release for previewing.
      
      Submitting a high-priority task is conceptually different from
      posting at the front of a single queue of tasks, as the high-priority
      tasks are executed in FIFO order among themselves. This will ensure
      that frame release tasks submitted in close succession are executed
      in the order they are submitted but before any lower priority tasks.
      
      PiperOrigin-RevId: 467675137
      (cherry picked from commit 4d81a6db)
      Googler committed
    • Increase max sample size for HEVC. · 909953b8
      Increase the estimated max sample size for HEVC by 2x, and set a minimum
      size of 2MB. The 2MB will be applied for resolutions up to 1080p, after
      which the new calculation takes effect. This is in par with the
      platform's HEVC software decoder.
      
      PiperOrigin-RevId: 467641494
      (cherry picked from commit d3d5ffce)
      christosts committed
    • Update CMake version for AV1 extension · 770839fe
      The specified CMake version doesn't work with the latest
      Android Studio releases. Updating to a more recent version
      fixes the problem.
      
      Issue: google/ExoPlayer#9933
      PiperOrigin-RevId: 467634063
      (cherry picked from commit 80b635e7)
      tonihei committed