1. 04 Jun, 2020 3 commits
  2. 02 Jun, 2020 10 commits
  3. 01 Jun, 2020 2 commits
  4. 29 May, 2020 14 commits
  5. 28 May, 2020 1 commit
  6. 27 May, 2020 10 commits
    • Replace manifest uri without changing the media item · f84bd463
      We aim to have the same media item instance published in the timeline that is passed to the createMediaSource(mediaItem) method. This means when the manifest uri is manually replaced by a developer, the media item published in the next timeline update is still the same.
      
      Note: This leads to the fact that the manifest published in that timeline is loaded from a different URI than the URI of the media item in the same timeline.
      PiperOrigin-RevId: 313375421
      bachinger committed
    • Merge pull request #7422 from noamtamim:bandwidthmeter-5g · 82e19944
      PiperOrigin-RevId: 313372995
      Oliver Woodman committed
    • Extract a ChunkExtractor interface · 32c35617
      A future implementation will depend on MediaParser.
      
      PiperOrigin-RevId: 313367998
      aquilescanta committed
    • Turn CacheUtil into stateful CacheWriter · d88f5f47
      - The new CacheWriter is simplified somewhat
      - Blocking on PriorityTaskManager.proceed is moved out of
        CacheWriter and into the Downloader tasks. This is because
        we want to shift only the caching parts of the Downloaders
        onto their Executors, whilst keeping the blocking parts on
        the main Downloader threads. Else we can end up "using"
        the Executor threads indefinitely whilst they're blocked.
      
      Issue: #5978
      PiperOrigin-RevId: 313222923
      olly committed
    • Add .inOrder() to most AnalyticsCollectorTest asserts · a1c72c0d
      I skipped it where it didn't make sense (e.g. singleton lists, or lists
      where all elements are identical).
      
      PiperOrigin-RevId: 313217398
      ibaker committed
    • Make constants more readable with _ separator · 151ea531
      Add an `_` in long constants.
      Eg: 10000 => 10_000.
      
      I'm proposing this change because I have had multiple
      missread due to confusing the number of 0 in a long number.
      
      More specifically, added an underscore to all number matching:
      `final.*\ [0-9]{2,}000;`
      
      PiperOrigin-RevId: 313186920
      krocard committed
    • Fix flaky test. · 45b574d5
      The test was flaky because it didn't wait for pending commands to finish
      after pausing the test playback.
      
      Also add more debug information to the toString() method because the
      expected and actual state only differed in the nextAdGroupIndex in the
      flaky case.
      
      PiperOrigin-RevId: 313175919
      tonihei committed
    • Make fallback value more explicitly unset. · 0add067e
      PiperOrigin-RevId: 313171970
      tonihei committed
    • ConditionVariable: Add uninterruptible block · 03ea39b1
      Sometimes it's useful to be able to block until something on some other thread
      "really has finished". This will be needed for moving caching operations onto
      the executor in Downloader implementations, since we need to guarantee that
      Downloader.download doesn't return until it's no longer modifying the
      underlying cache.
      
      One solution to this is of course just to not interrupt the thread that's
      blocking on the condition variable, but there are cases where you do need to do
      this in case the thread is at some other point in its execution. This is true
      for Downloader implementations, where the Download.download thread will also
      be blocking on PriorityTaskManager.proceed. Arranging to conditionally
      interrupt the thread based on where it's got to is probably possible, but seems
      complicated and error prone.
      
      Issue: #5978
      PiperOrigin-RevId: 313152413
      olly committed
    • Make manifest loads on timeline refresh optional in FakeMediaSource. · ee11d9d6
      Every timeline refresh currently assumes that it corresponds to a manifest
      refresh and issues the respective load events. However, there are other
      timeline updates that don't have a manifest refresh (e.g. ad state updates)and thus shouldn't issue these events.
      
      PiperOrigin-RevId: 313150489
      tonihei committed