- 06 Mar, 2019 40 commits
-
-
These are thrown for non-IOException encountered during loading. Also, they are thrown from an unexpected position and retrying is likely to fail anyway because the Extractor is left in an unrecoverable state. PiperOrigin-RevId: 237043948
tonihei committed -
SQLiteException is a runtime exception, which makes it easy to forget to handle it. This change converts SQLiteExceptions into a checked exception, which is then handled appropriately. PiperOrigin-RevId: 237038793
olly committed -
PiperOrigin-RevId: 237028164
andrewlewis committed -
Currently a flags-only DecoderInputBuffer may hold only the end-of-stream flag. This change makes flags-only buffer read any kind of flag set in the next sample. If no sample is available RESULT_NOTHING_READ is returned. PiperOrigin-RevId: 237027581
aquilescanta committed -
PiperOrigin-RevId: 237025639
olly committed -
We currrently just inherit the acitivity's alertDialogTheme style (which is equivalent to ThemeOverlay.AppCompat.Dialog.Alert). Using the theme overlay directly and also force-enable the title such that the title is shown even if the activity disabled the title. PiperOrigin-RevId: 237012601
tonihei committed -
nalPrefix.readUnsignedIntToInt() will throw if the unsigned output doesn't fit in an int. Before this change, in the error case we'd retry reading from after the NAL prefix position. Throw a ParserException so that reading an obviously invalid NAL prefix will be treated as a fatal exception by the default load error handling policy. PiperOrigin-RevId: 236839690
andrewlewis committed -
PiperOrigin-RevId: 236805460
andrewlewis committed -
There are 6 different situations which are now more explicitly covered to ensure we handle them correctly: 1. Radio button (non-adaptive, single group only) Selected -> Do nothing. Unselected -> Replace override with selected track. 2. Check box (non-adaptive, but multi-group allowed) Selected -> Remove track (and override). If last one, set isDisabled flag. Unselected -> Replace override with selected track. 3. Check box (adaptive allowed, single or multi group) Selected -> Remove track. If last, remove override and maybe set isDisabled. Unselected -> Add track to override. PiperOrigin-RevId: 236668642
tonihei committed -
The release needs to post to the MediaSource thread and also needs to post back to the DownloadHelper thread to prevent sending updates after release has been called. The point where we release the downloadHelper also needs to dismiss the dialog in case the creation has already been queued before the release. PiperOrigin-RevId: 236652309
tonihei committed -
PiperOrigin-RevId: 236648435
aquilescanta committed -
PiperOrigin-RevId: 236645446
olly committed -
This is more in line with "forgetting all previous state" as documented for resetState=True. Also only apply the current position as initial seek position in this case. PiperOrigin-RevId: 236623630
tonihei committed -
Deduplicates a bit of code PiperOrigin-RevId: 236621851
aquilescanta committed -
We currently throw if a pending seek position was valid when the user issued it on the app thread, but can't be resolved on the playback thread because the timeline changed in the meantime. Throwing in this case seems wrong as the user could not have known about the issue (and the seek position was actually valid). Also, in other cases where the currently playing period is no longer in the new timeline, we gracefully use a subsequent period or transition to ENDED state instead of throwing. So it seems more consistent to transition to ENDED state as well. PiperOrigin-RevId: 236274862
tonihei committed -
This constants and classes are defined by the same name in the super class and thus can be safely removed. PiperOrigin-RevId: 236136197
tonihei committed -
PiperOrigin-RevId: 236133636
tonihei committed -
So far it's only enabled in the external demo app. PiperOrigin-RevId: 236122825
tonihei committed -
They are currently broken because we ignore downloads without periods. As the DownloadHelper doesn't create periods for progressive media, we don't download them. Fixing by starting download automatically without showing track selection dialog. PiperOrigin-RevId: 236120202
tonihei committed -
PiperOrigin-RevId: 236119640
tonihei committed -
These were added in an internal clean-up and are better fixed than suppressed. PiperOrigin-RevId: 236118715
tonihei committed -
Instead just set the currently clicked item as override. If the already selected button is clicked, the override is reset with the same value. PiperOrigin-RevId: 236118429
tonihei committed -
We currently do not show check boxes if the renderer does not support adaptive switches between tracks in one group. However, we assume check boxes in the onClick method. Use same logic for both methods to be consistent. PiperOrigin-RevId: 236118372
tonihei committed -
The flag in ExoPlayer.prepare is documented as keeping the current window index and window position. We are currently using the current period UID and period position instead. This causes problems when the media source is changed but the position is not reset. Using the initial seek position instead ensures we actually use the window index and position. Issue:#5520 PiperOrigin-RevId: 236101024
tonihei committed -
Adding new error types may cause issues when listeners assume a fixed set of error types and don't handle arbitrary defaults. Fixing error handling in one case and improving documentation to make people aware of the issue. PiperOrigin-RevId: 236093265
tonihei committed -
This is a left-over from the past and is no longer true. PiperOrigin-RevId: 236089921
tonihei committed -
Global Presubmit : https://test.corp.google.com/ui#id=OCL:235456897:BASE:235767406:1551211793273:aa1704f6 LSC doc: go/android-sdk-lsc PiperOrigin-RevId: 235812819
olly committed -
PiperOrigin-RevId: 235685393
bachinger committed -
PiperOrigin-RevId: 235576645
olly committed -
PiperOrigin-RevId: 235541545
olly committed -
Issue: #5503 PiperOrigin-RevId: 235523955
andrewlewis committed -
While disabled the renderer does not have non-null stream formats. This means that setting the operating rate could cause a NullPointerException if there was a codec for reuse. Check for being enabled/started before trying to set the operating rate. After the renderer is enabled it should receive a new input format which will update the operating rate as needed. PiperOrigin-RevId: 235494384
andrewlewis committed -
If the DefaultAudioSink was reconfigured in a way that was compatible with the previous configuration just after having been reset, we would try to drain audio processors despite not having an AudioTrack. This could result in a NullPointerException if speed adjustment was active. Fix this behavior by only trying to drain audio processors if we actually have an AudioTrack. PiperOrigin-RevId: 235355466
andrewlewis committed -
Issue #5360 PiperOrigin-RevId: 235196177
bachinger committed -
PiperOrigin-RevId: 235189983
aquilescanta committed -
- Expose constructor (package private for now, for tests only) - Add some tests for cache initialization - Add some TODOs for handling initialization failure PiperOrigin-RevId: 235188386
olly committed -
*** Reason for rollback *** Breaks ExoPlayer's gradle build *** Original change description *** Migrate Mockito Matchers.{hamcrestMethods} to MockitoHamcrest.{hamcrestMethods} All methods accepting a hamcrest Matcher in org.mockito.Matchers have been changed to only accept an ArgumentMatcher. The corresponding methods are now available on MockitoHamcrest. For more information see http://go/mockito-2-lsc Tested: TAP --sample for global presubmit queue http://test/OCL:235033293:BASE:234998256:1550793421835:c2ccbbda *** PiperOrigin-RevId: 235186705olly committed -
Deduplicates the call to Extractor#read and sorrounding logic. PiperOrigin-RevId: 235165499
aquilescanta committed -
All methods accepting a hamcrest Matcher in org.mockito.Matchers have been changed to only accept an ArgumentMatcher. The corresponding methods are now available on MockitoHamcrest. For more information see http://go/mockito-2-lsc Tested: TAP --sample for global presubmit queue http://test/OCL:235033293:BASE:234998256:1550793421835:c2ccbbda PiperOrigin-RevId: 235153912
olly committed -
PiperOrigin-RevId: 234997641
bachinger committed
-