- 09 Dec, 2019 3 commits
-
-
Caveats: - Block additional data is ignored if the block is laced and contains multiple samples. Note that this is not a loss of functionality (SimpleBlock cannot have block additional data, and lacing was previously completely unsupported for Block) - Subrip and ASS samples are dropped if they're in laced blocks with multiple samples (I don't think this is valid anyway) Issue: #3026 PiperOrigin-RevId: 284545197
olly committed -
This change constrains the use of sample state member variables to writeSampleData, finishWriteSampleData and resetWriteSampleData. Using them elsewhere gets increasingly confusing when considering features like lacing in full blocks. For example sampleBytesWritten cannot be used when calling commitSampleToOutput in this case because we need to write the sample data for multiple samples before we commit any of them. Issue: #3026 PiperOrigin-RevId: 284541942
olly committed -
PiperOrigin-RevId: 284509437
olly committed
-
- 06 Dec, 2019 30 commits
-
-
Oliver Woodman committed
-
For AOSP TV devices that might not pass manual verification. PiperOrigin-RevId: 284154763
olly committed -
- Remove "lacing" from member variables. They're used even if there is no lacing (and the fact that lacing is the way of getting multiple samples into a block isn't important). Issue: #3026 PiperOrigin-RevId: 284152447
olly committed -
- Change sampleHasReferenceBlock to a block reading variable, which is what it is (the distinction didn't matter previously, but will do so when we add lacing support in full blocks because there wont be a 1:1 relationship any more. - Move sampleRead to be a reading state variable. - Stop abbreviating "additional" Issue: #3026 PiperOrigin-RevId: 284000937
olly committed -
An I/O error could occur while handling the start of an mdta box, in which case retrying would cause another ContainerAtom to be added. Fix this by skipping the mdta header before updating container atoms. PiperOrigin-RevId: 284000715
andrewlewis committed -
This makes the exception easier to interpret and helps with debugging of externally reported issues. PiperOrigin-RevId: 283965317
tonihei committed -
PiperOrigin-RevId: 283958680
samrobinson committed -
PiperOrigin-RevId: 283951181
olly committed -
PiperOrigin-RevId: 283810554
olly committed -
PiperOrigin-RevId: 283791815
olly committed -
This simplifies documentation and adds compiler checks that the correct values are used. PiperOrigin-RevId: 283754163
tonihei committed -
Also remove MetadataRenderer and SpliceInfoDecoder from the nullness blacklist PiperOrigin-RevId: 283744417
olly committed -
This parameter is a little confusing, especially as the behaviour can be surprising if the intended use-case isn't clear. This change moves the description of the parameter into the class javadoc, adds context/justification and slims down each method's javadoc to refer to the class-level. Related to investigating/fixing issue:#6700 PiperOrigin-RevId: 283724826
ibaker committed -
PiperOrigin-RevId: 283722376
Ian Baker committed -
Issue: #6657 PiperOrigin-RevId: 283563218
bachinger committed -
PiperOrigin-RevId: 283559073
ibaker committed -
This is a minor change ahead of merging a full variant of https://github.com/google/ExoPlayer/pull/6706, to make re-buffers less likely. Also remove variable substitution when parsing AVERAGE-BANDWIDTH (it's not required for integer attributes) PiperOrigin-RevId: 283554106
olly committed -
PiperOrigin-RevId: 283546707
bachinger committed -
PiperOrigin-RevId: 283543456
andrewlewis committed -
Fixes issue:#6700 sample_cbs_truncated.adts test file produced using `$ split -b 31795 sample_truncated.adts` to remove the last 10 bytes PiperOrigin-RevId: 283530136
ibaker committed -
PiperOrigin-RevId: 283515315
andrewlewis committed -
PiperOrigin-RevId: 283366568
olly committed -
PiperOrigin-RevId: 283347700
bachinger committed -
PiperOrigin-RevId: 283324784
olly committed -
PiperOrigin-RevId: 283324612
olly committed -
PiperOrigin-RevId: 283319944
andrewlewis committed -
PiperOrigin-RevId: 283310946
olly committed -
This allows easy overriding of the resources by app developers Issue: #6709 PiperOrigin-RevId: 283306121
olly committed -
PiperOrigin-RevId: 283296427
olly committed -
Issue: #6687 PiperOrigin-RevId: 283023548
andrewlewis committed
-
- 27 Nov, 2019 5 commits
-
-
Oliver Woodman committed
-
When transitioning to a new stream in a different format, the audio processors are reconfigured. After this, they are drained and then flushed so that they are ready to handle data in updated formats for the new stream. Before this change, some audio processors made the assumption that after reconfiguration no more input would be queued in their old input format, but this assumption is not correct: during draining more input may be queued. Fix this behavior so that the new configuration is not referred to while draining and only becomes active once flushed. Issue: #6601 PiperOrigin-RevId: 282515359
andrewlewis committed -
flush() is guaranteed to be called in all these cases anyway. Also clarify documentation for AudioProcessor-specific methods that can change the 'active' flag. Issue: #6601 PiperOrigin-RevId: 282515255
andrewlewis committed -
Issue: #6601 PiperOrigin-RevId: 282515179
andrewlewis committed -
This simplifies the contract of configure and is in preparation for fixing a bug where more input can't be queued when draining audio processors for a configuration change. Issue: #6601 PiperOrigin-RevId: 282514367
andrewlewis committed
-
- 24 Nov, 2019 1 commit
-
-
PiperOrigin-RevId: 282227866
olly committed
-
- 22 Nov, 2019 1 commit
-
-
PiperOrigin-RevId: 281976465
olly committed
-