Skip to content
Toggle navigation
P
Projects
G
Groups
S
Snippets
Help
SDK
/
exoplayer
This project
Loading...
Sign in
Toggle navigation
Go to a project
Project
Repository
Issues
0
Merge Requests
0
Pipelines
Wiki
Snippets
Settings
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Commit
5f465f77
authored
Nov 29, 2019
by
andrewlewis
Committed by
Oliver Woodman
Dec 06, 2019
Browse files
Options
_('Browse Files')
Download
Email Patches
Plain Diff
Remove AdsManager listeners on release
Issue: #6687 PiperOrigin-RevId: 283023548
parent
9d9a2a68
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
0 deletions
RELEASENOTES.md
extensions/ima/src/main/java/com/google/android/exoplayer2/ext/ima/ImaAdsLoader.java
RELEASENOTES.md
View file @
5f465f77
...
...
@@ -140,6 +140,9 @@
[
Cast demo app
](
https://github.com/google/ExoPlayer/tree/dev-v2/demos/cast
)
.
*
TestUtils: Publish the
`testutils`
module to simplify unit testing with
ExoPlayer (
[
#6267
](
https://github.com/google/ExoPlayer/issues/6267
)
).
*
IMA extension: Remove
`AdsManager`
listeners on release to avoid leaking an
`AdEventListener`
provided by the app
(
[
#6687
](
https://github.com/google/ExoPlayer/issues/6687
)
).
### 2.10.8 (2019-11-19) ###
...
...
extensions/ima/src/main/java/com/google/android/exoplayer2/ext/ima/ImaAdsLoader.java
View file @
5f465f77
...
...
@@ -646,6 +646,11 @@ public final class ImaAdsLoader
public
void
release
()
{
pendingAdRequestContext
=
null
;
if
(
adsManager
!=
null
)
{
adsManager
.
removeAdErrorListener
(
this
);
adsManager
.
removeAdEventListener
(
this
);
if
(
adEventListener
!=
null
)
{
adsManager
.
removeAdEventListener
(
adEventListener
);
}
adsManager
.
destroy
();
adsManager
=
null
;
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment