Skip to content

SDK / exoplayer

Go to a project
Switch branch/tag
  1. 16 Nov, 2022 8 commits
  3. 14 Nov, 2022 11 commits
  5. 10 Nov, 2022 21 commits
    • Fix bug where streamOffsetUs is passed instead of streamPositionUs · c9fe52bf 
      Also make order of streamStartPositionUs and streamOffsetUs consistent

PiperOrigin-RevId: 487511633
      kimvde committed
    • Ensure listener invocations use final state variable. · 33bea391 
      The MediaControllerImplBase listener invocations currently use the
class member state that can change if one of the listener method
implementations changes the state recursively.

Updating the listener invocations to use a final local variable
ensures all listeners get consistent updates.

PiperOrigin-RevId: 487503373
      tonihei committed
    • Split test methods more clearly in arrange, act, assert. · c6a0ba25 
      The tests in MediaControllerCompatCallbackWithMediaSessionTest
don't follow this pattern very consistently at the moment.

PiperOrigin-RevId: 487501913
      tonihei committed
    • Align PlaybackStateCompat states with logic in MediaSessionConnector · c5e071e5 
      Creating the PlaybackStateCompat from a media3 Player state is done
already by the MediaSessionConnector (and used widely). The media3
session module should set the same states under the same circumstances
to ensure compatiblity and consistency.

PlaybackStateCompat changes made in media3 session:
 - Use STATE_STOPPED when player is ended instead of STATE_PAUSED
 - Use STATE_PLAYING when playback is suppressed temporarily.
 - Set the playback speed to 0 if the player is not playing.
 - Add extras for mediaId and user-set playback speed.

Part of the problem was that Player.isPlaying() was used to check
the state. Unfortunately, MockPlayer.isPlaying() is implemented in
a way that makes it hard to test these changes, because the value
is set independently of playbackState, playWhenReady and suppression
reason. To be able to write consistent, logical tests, this change
also removes the independent setting of isPlaying in MockPlayer to
align it better with a real player. This requires to update some
other tests to use alternative methods.

PiperOrigin-RevId: 487500859
      tonihei committed
    • Add missing IntDef on MediaSource.Factory.getSupportedTypes overrides · 4f04a284 
      Without this the annotation isn't shown in javadoc (same in Dackka)

No annotation:
https://exoplayer.dev/doc/reference/com/google/android/exoplayer2/source/DefaultMediaSourceFactory.html#getSupportedTypes()

Annotation present:
https://exoplayer.dev/doc/reference/com/google/android/exoplayer2/source/MediaSource.Factory.html#getSupportedTypes()

#minor-release

PiperOrigin-RevId: 487498450
      ibaker committed
    • Configure Dackka to generate javadoc for protected methods · a4029551 
      #minor-release

PiperOrigin-RevId: 487497923
      ibaker committed
    • Fix parameter name mismatch in MappingTrackSelector.selectTracks · 4fcc019b 
      It's not clear to me why presubmit didn't catch this, I briefly
investigated but couldn't work it out - so I'm just going to fix
it and move on.

#minor-release

PiperOrigin-RevId: 487497827
      ibaker committed
    • Avoid notifying connection twice from MediaControllerImplLegacy. · b24161a6 
      The connection to a legacy MediaSession may receive additional
onSessionReady callbacks that are treated as additional state updates.
We currently also set the "notifyConnected" flag for these updates
even though we are connected already, causing an IllegalStateException.

Fix the exception by not setting this flag.

We can also remove the wording about "locked" updates since this class
operates everything on a single application thread.

Issue: androidx/media#49
PiperOrigin-RevId: 487487286
      tonihei committed
    • Remove dependency on muxer from ExoPlayerAssetLoader · 07f0589c 
      PiperOrigin-RevId: 487487259
      kimvde committed
    • Set targetSdkVersion of main demo app to 29 · 40c6c431 
      #minor-release

PiperOrigin-RevId: 487479366
      christosts committed
    • Add TransformerInternal · 1d888d20 
      The player is still driving the transformation at this point. The
transformer thread will be added in another CL.

PiperOrigin-RevId: 487479148
      kimvde committed
    • Fix Dackka parameter name error in `Gav1Decoder` and `VpxDecoder` · 742da7f4 
      These aren't caught by presubmit because the classes are annotated
`@VisibleForTesting` and are therefore stripped out by Metalava. However
Metalava doesn't run when we're generating javadoc for real.

#minor-release

PiperOrigin-RevId: 487476260
      ibaker committed
    • Fix Dackka/Metalava errors in test_utils module · 3ab88135 
      This involves reducing the visibility of methods/constructors that
are already unusable outside the `androidx.media3.test.utils` package.

#minor-release

PiperOrigin-RevId: 487473005
      ibaker committed
    • Fix Dackka/Metalava errors in av1, flac, ffmpeg, midi, and opus modules · e9ddfa53 
      This uses `@hide` on `protected final` methods to hide them from Dackka
javadoc generation, since these methods are inaccessible to developers
anyway. These symbols will still (currently) be included in artefacts
distributed on Maven (because we don't run Metalava as part of
generating these artefacts).

In some cases I had to change the visibility/finality of methods to make
them `protected final` before adding the `@hide` annotation (but
the impact should be very low, since most of these methods were either
already unusable by app developers, or they shouldn't have been used).

#minor-release

PiperOrigin-RevId: 487472907
      ibaker committed
    • Fix Dackka/Metalava errors in the HLS and RTSP modules · dbfc0cc7 
      This makes two fixes:
1. Remove `HlsSampleStreamWrapper.Callback` (package-private) from the
   list of interfaces implemented by `HlsMediaPeriod` (`public`) and
   move the implementation to a private inner class instead. This avoids
   Metalava complaining about a public class that inherits from a
   package-private type.
2. Reduce the visibility of
   `RtpPayloadFormat.isFormatSupported(MediaDescription)` from `public`
   to package-private. The `MediaDescription` type is already
   package-private, so this method was already unusable outside the
   package.

#minor-release

PiperOrigin-RevId: 487472781
      ibaker committed
    • Fix Dackka/Metalava errors in the ExoPlayer module · 7905744a 
      This makes two types of fix:
1. Align parameter names on overridden methods where the superclass
   has `@param` javadoc.
2. Use `@hide` on `protected final` methods that refer to package-private
   types. This will hide these symbols from Dackka javadoc generation
   but not (currently) from the artefacts distributed on Maven. These
   methods are currently unusable outside their package anyway (e.g. by
   external developers) because of the dependency on a package-private
   type.

This also changes some HLS, SmoothStreaming, and IMA code where I've renamed
parameters of overridden methods to be consistent across the type
hierarchy.

#minor-release

PiperOrigin-RevId: 487472665
      ibaker committed
    • HDR: Implement ForceInterpretHdrVideoAsSdr · 2ff5dab0 
      Also, document that we tone map when no HDR features are explicitly set

PiperOrigin-RevId: 487310971
      huangdarwin committed
    • Set HDR color info on FrameworkMuxer · 3c74e076 
      Not setting the color info results in a missing "colr" box in the produced
container, under file/moov/trak/mdia/minf/stbl/stsd/hvc1. This means extractors
will not be able to find out the transcoded file is HDR.

In `Transformer`, this means it can't transcode this transcoded file, because
it currently relies on the container bearing HDR info to construct the
transcoding sample pipeline.

PiperOrigin-RevId: 487276712
      claincly committed
    • Wait with PlayerInfo updates until all pending operations are done · 0b4ba3e3 
      Accepting a PlayerInfo while the MediaController is masking its state
means we are reverting all masking changes we've made earlier. This
only makes sense if the update already contains the masked operation.
If multiple operations are in flight (or are sent from the session
while they are in flight), we need to wait until all of them are
handled before accepting new updates.

In cases where a new update from the session excludes the Timeline
and the masked state is incompatible with the new update, we also
risk an exception if we accept the update too early.

PiperOrigin-RevId: 487266899
      tonihei committed
    • Change UnsupportedEncodingException to IllegalArgumentException · 818bf4a2 
      In startTransformation method we were throwing UnsupportedEncodingException (IOException) when mediaItem with unsupported arguments is passed.
Changed this to IllegalArgumentException which seems more logical here.

PiperOrigin-RevId: 487259296
      sheenachhabra committed
    • MediaController: Add missing event flags (2/2) · c403b4ce 
      This is the follow-up commit where the onEvents callback
raised by MediaController contains the missing events, for the
case where MediaController is connected to a legacy MediaSession.

#minor-release

PiperOrigin-RevId: 487231996
      christosts committed