- 13 Jul, 2020 17 commits
-
-
The method currently advances the read position and returns the number of skipped samples. This prevents checking how many samples are skipped before the operation is executed. Instead, we have a new method that returns the number of to be skipped samples and a skip method that executes the skipping. PiperOrigin-RevId: 320953439
tonihei committed -
Remove occurrences in comments and private fields. ISSUE: #7565 PiperOrigin-RevId: 320948364
kimvde committed -
- DefaultAudioSink always supports floating point input. Make it advertise this fact. - Remove the ability to enable/disable floating point output in FfmpegAudioRenderer, since this ability is now also provided on DefaultAudioSink. - Let FfmpegAudioRenderer query the sink to determine whether it will output floating point PCM directly or resample it to 16-bit PCM. PiperOrigin-RevId: 320945360
olly committed -
PiperOrigin-RevId: 320921457
olly committed -
CSS background-color isn't inherited to inner HTML elements by default: https://developer.mozilla.org/en-US/docs/Web/CSS/background-color But Android Span styling assumes an outer BackgroundColorSpan will affect inner spans. This usually doesn't make a difference, because HTML elements are transparent by default, so there's an implicit inheritance by just being able to see through to the 'outer' element underneath. However this doesn't work if the inner element sits outside the bounding box of the outer element, e.g. <rt> (ruby text, sits above/below) or a <span> with font-size > 100%. END_PUBLIC Demo of <rt> and font-size problems: http://go/cpl/ruby-backgrounds/1 Demo of CSS inheritance: http://go/cpl/css-inheritance/1 PiperOrigin-RevId: 320915999
ibaker committed -
PiperOrigin-RevId: 320909448
andrewlewis committed -
Previously, the automatically selected subtitle track has not been marked (with check mark) in subtitle track list, just like audio track. But, in subtitle track option UI, there is no 'auto' option, which is different from audio track selection menu. This CL marks the auto selected subtitle track name in the cc list. PiperOrigin-RevId: 320802575
insun committed -
Remove occurrences in comments and private fields. ISSUE: #7565 PiperOrigin-RevId: 320606558
kimvde committed -
PiperOrigin-RevId: 320601157
olly committed -
The counter was increased by one for each batch instead of each frame. Additionally fix a null check. PiperOrigin-RevId: 320592873
krocard committed -
Sharing the Handler has led to it being accidentally used for purposes beyond the original intention. Instead for EPII -> EPI communication: Call methods directly on ExoPlayerImpl that then post from the playback thread to the application thread. And for the MediaSourceList and Queue initialization, create a dedicated Handler based on the same applicationLooper. PiperOrigin-RevId: 320590527
ibaker committed -
PiperOrigin-RevId: 320581002
olly committed -
PiperOrigin-RevId: 320574671
kimvde committed -
Also flip DefaultDrmSessionManager#prepare()/release() into guard clauses. Suggestions from review comments on: https://github.com/google/ExoPlayer/commit/316f8a88cdaeff2b1b5d219097b2739ef607b2c4 PiperOrigin-RevId: 320572462
ibaker committed -
AdDisplayContainer now takes the video ad player at construction time, and obstructions are registered/unregistered via a new method. Also 'content complete' is now notified via ad callbacks rather than the AdsLoader. PiperOrigin-RevId: 320567666
andrewlewis committed -
PiperOrigin-RevId: 320565543
andrewlewis committed -
The new reader is named H263Reader as it handles H.263 streams, but MPEG-4 Part 2 streams are also intended to be handled. The reader's output format MIME type is video/mp4v as the H.263 streams can be decoded by decoders supporting this MIME type. The implementation is based on the framework implementation for extracting MPEG-4 video in MPEG-TS (https://cs.android.com/android/platform/superproject/+/master:frameworks/av/media/libstagefright/mpeg2ts/ESQueue.cpp;l=1825;drc=86e363c1fac27302ca4ae33e73296f7797672995) and is similar to the existing H262Reader. Issue: #1603 Issue: #5107 PiperOrigin-RevId: 320565337
andrewlewis committed
-
- 10 Jul, 2020 6 commits
-
-
This brings in a fix for the IMA SDK ignoring the media load timeout. Issue: #7170 PiperOrigin-RevId: 320557386
andrewlewis committed -
Issue: #7592 PiperOrigin-RevId: 320556981
kimvde committed -
DecoderCounters are reset in onEnabled, but the way the local counters in MediaCodecVideoRenderers were reset assumed the DecoderCounters were reset in onStarted. PiperOrigin-RevId: 320440991
olly committed -
Building on the Format that was provided on the input side of the decoder creates a format that's a mixture of the formats on the input and output sides of the decoder. This change instead builds a PCM format from scratch. PiperOrigin-RevId: 320405656
olly committed -
The counter was increased by one for each batch instead of each frame. PiperOrigin-RevId: 320396903
krocard committed -
The renderers are currently constructing formats that consist of their input format with added PCM encoding. Such formats are not self-consistent, and this only works because DefaultAudioSink ignores the rest of the format if the format has a PCM encoding. It would not work if the sink implementation checked the MIME type, for example, which wouldn't be a strange or incorrect thing for it to do. The more correct approach is to construct a new format that properly represents the PCM that will be provided to the sink. This change also renames supportsOutput to supportsFormat, because AudioSink itself has both an input and an output side, and this method is actually evaluating support on the input side of the sink. PiperOrigin-RevId: 320396089
olly committed
-
- 09 Jul, 2020 3 commits
-
-
PiperOrigin-RevId: 320351394
jaewan committed -
PiperOrigin-RevId: 320323388
insun committed -
The receiving code was updated in: https://github.com/google/ExoPlayer/commit/7b82a3c8892a2b90fa1121dc6bfad7817ae03944 but this sending site was missed. PiperOrigin-RevId: 320173033
ibaker committed
-
- 08 Jul, 2020 14 commits
-
-
PiperOrigin-RevId: 320172040
ibaker committed -
This is useful for subclasses to easily query the point up to which they should only decode (but not render) content, rather than each subclass having to have its own startPositionUs and update it in onPositionReset. PiperOrigin-RevId: 320163677
olly committed -
https://github.com/google/ExoPlayer/commit/252bf43bf450a0f42fd06178c1dc82062d227b29
*** Original commit *** Stop parsing unsupported WebVTT CSS properties The spec lists an exhaustive list of CSS properties that should be recognised, all others must be ignored: https://www.w3.org/TR/webvtt1/#the-cue-pseudo-element *** PiperOrigin-RevId: 320150427
ibaker committed -
PiperOrigin-RevId: 320149613
olly committed -
This constructor and the way of passing BandwdithMeter has long been deprecated now and can be removed. PiperOrigin-RevId: 320147888
tonihei committed -
This also removes unused deprecated methods. PiperOrigin-RevId: 320141729
insun committed -
https://github.com/google/ExoPlayer/commit/75eab31d79aae73196a60fb24474da2a36855c4a
*** Original commit *** Rollback of https://github.com/google/ExoPlayer/commit/0943886cbd7ee6c4e33ed731ddff0b23e5699abd *** Original commit *** Use last queue format instead of previous decision to select new track We currently use the save... *** PiperOrigin-RevId: 320015109
tonihei committed -
PiperOrigin-RevId: 320006659
olly committed -
https://github.com/google/ExoPlayer/commit/0943886cbd7ee6c4e33ed731ddff0b23e5699abd
*** Original commit *** Use last queue format instead of previous decision to select new track We currently use the saved selectionIndex to base our new track selection decision on. This index might be stale if the previous selection didn't result in a queue update (e.g. when loading live streams where the new chunk isn't available yet). Fix this by using the format of the last chunk to make the new decision. Issue: #7582 *** PiperOrigin-RevId: 319991676
tonihei committed -
PiperOrigin-RevId: 319989989
ibaker committed -
Also move implementations of some VideoAdPlayer callback methods into their own methods. This is a no-op change except for expanding the scope of some defensive try blocks associated with those callbacks. Also add static imports for Math.max and Assertions helpers methods. PiperOrigin-RevId: 319958087
andrewlewis committed -
We currently use the saved selectionIndex to base our new track selection decision on. This index might be stale if the previous selection didn't result in a queue update (e.g. when loading live streams where the new chunk isn't available yet). Fix this by using the format of the last chunk to make the new decision. Issue: #7582 PiperOrigin-RevId: 319957980
tonihei committed -
PiperOrigin-RevId: 319954774
kim-vde committed -
The wait time parameter is an implementation detail where we can just provide a default. In addition, we should also force the evaluation when the last chunk in the queue changed to ensure it is always evaluated before starting to load a new chunk. Issue: #7582 PiperOrigin-RevId: 319949251
tonihei committed
-