Overriding onTouchEvent was causing multiple issues, and appears to be unnecessary. Removing the override fixes: 1. StyledPlayerView accessibility issue where "hide player controls" actually toggled play/pause. 2. Delivery of events to a registered OnClickListener when useController is false. 3. Delivery of events to a registered OnLongClickListener in all configurations. 4. Incorrectly treating a sequence of touch events that exit the bounds of the view before ACTION_UP as a click, both for delivery to OnClickListener and for toggling the controls. Note: After this change, control visibility will not be toggled if the application developer explicitly sets the view to be non-clickable. I think that's probably working as intended though. It seems correct that a non-clickable view would not respond to clicks. Issue: google/ExoPlayer#8627 Issue: google/ExoPlayer#9605 Issue: google/ExoPlayer#9861 PiperOrigin-RevId: 433016626
| Name |
Last commit
|
Last Update |
|---|---|---|
| .. | ||
| cast | Loading commit data... | |
| common | Loading commit data... | |
| database | Loading commit data... | |
| datasource | Loading commit data... | |
| datasource_cronet | Loading commit data... | |
| datasource_okhttp | Loading commit data... | |
| datasource_rtmp | Loading commit data... | |
| decoder | Loading commit data... | |
| decoder_av1 | Loading commit data... | |
| decoder_ffmpeg | Loading commit data... | |
| decoder_flac | Loading commit data... | |
| decoder_opus | Loading commit data... | |
| decoder_vp9 | Loading commit data... | |
| exoplayer | Loading commit data... | |
| exoplayer_dash | Loading commit data... | |
| exoplayer_hls | Loading commit data... | |
| exoplayer_ima | Loading commit data... | |
| exoplayer_rtsp | Loading commit data... | |
| exoplayer_smoothstreaming | Loading commit data... | |
| exoplayer_workmanager | Loading commit data... | |
| extractor | Loading commit data... | |
| session | Loading commit data... | |
| test_data | Loading commit data... | |
| test_exoplayer_playback | Loading commit data... | |
| test_session_common | Loading commit data... | |
| test_session_current | Loading commit data... | |
| test_utils | Loading commit data... | |
| test_utils_robolectric | Loading commit data... | |
| transformer | Loading commit data... | |
| ui | Loading commit data... | |
| ui_leanback | Loading commit data... |