Even when fixed to the US locale (and thus avoiding surprising behaviour in e.g. Turkish locale with "i" and "I") there are unexpected behaviours when upper and lower casing non-ASCII characters. For example it's sometimes not symmetric, e.g.: "ẞ".toLowerCase() -> "ß" "ß".toUpperCase() -> "SS" In all the ExoPlayer usages we are either dealing with known-ASCII strings (e.g. MIME types) or comparing against ASCII constant strings anyway, so it seems easier to just use Guava's ASCII-only class in these cases. This change also includes some null-twiddling, because Util.toLowerInvariant() is null tolerant, while Ascii.toLowerCase() is not. Most of the usages were already non-null, and it was easy enough to change the remaining ones to be so by simple reordering of statements. I'll make an equivalent change for Util.toUpperInvariant() next. PiperOrigin-RevId: 368419813
| Name |
Last commit
|
Last Update |
|---|---|---|
| .. | ||
| Assertions.java | Loading commit data... | |
| BundleUtil.java | Loading commit data... | |
| Clock.java | Loading commit data... | |
| CodecSpecificDataUtil.java | Loading commit data... | |
| ConditionVariable.java | Loading commit data... | |
| Consumer.java | Loading commit data... | |
| CopyOnWriteMultiset.java | Loading commit data... | |
| ErrorMessageProvider.java | Loading commit data... | |
| ExoFlags.java | Loading commit data... | |
| FileTypes.java | Loading commit data... | |
| FlacConstants.java | Loading commit data... | |
| GlUtil.java | Loading commit data... | |
| HandlerWrapper.java | Loading commit data... | |
| ListenerSet.java | Loading commit data... | |
| Log.java | Loading commit data... | |
| LongArray.java | Loading commit data... | |
| MediaFormatUtil.java | Loading commit data... | |
| MimeTypes.java | Loading commit data... | |
| NalUnitUtil.java | Loading commit data... | |
| NonNullApi.java | Loading commit data... | |
| ParsableBitArray.java | Loading commit data... | |
| ParsableByteArray.java | Loading commit data... | |
| ParsableNalUnitBitArray.java | Loading commit data... | |
| RepeatModeUtil.java | Loading commit data... | |
| SystemClock.java | Loading commit data... | |
| SystemHandlerWrapper.java | Loading commit data... | |
| TimedValueQueue.java | Loading commit data... | |
| TimestampAdjuster.java | Loading commit data... | |
| TraceUtil.java | Loading commit data... | |
| UnknownNull.java | Loading commit data... | |
| Util.java | Loading commit data... | |
| XmlPullParserUtil.java | Loading commit data... | |
| package-info.java | Loading commit data... |