Skip to content

SDK / exoplayer

Go to a project
Switch branch/tag
  1. 16 Apr, 2021 4 commits
    • Replace Util.toUpperInvariant() with Ascii.toUpperCase() · fff7b807 
      Even when fixed to the US locale (and thus avoiding surprising behaviour
in e.g. Turkish locale with "i" and "I") there are unexpected behaviours
when upper and lower casing non-ASCII characters.

For example it's sometimes not symmetric, e.g.:
"ẞ".toLowerCase() -> "ß"
"ß".toUpperCase() -> "SS"

In all the ExoPlayer usages we are either dealing with known-ASCII
strings (e.g. MIME types) or comparing against ASCII constant strings
anyway, so it seems easier to just use Guava's ASCII-only class in these
cases.

Util.toUpperInvariant() is null-tolerant, while Ascii.toLowercase() is
not. Most usages in this change are clearly non-null. The BandwidthMeter
usages aren't annotated @Nullable, but the current code *would* work if
countryCode was null in both cases. These methods will now throw NPE if
they're passed null.

PiperOrigin-RevId: 368816287
      ibaker committed
    • Merge pull request #8814 from dlafayet:line-height · 5511bb66 
      PiperOrigin-RevId: 368803206
      Oliver Woodman committed
    • Fix typo · 66e4e47e 
      PiperOrigin-RevId: 368789636
      jaewan committed
    • Add experimentalSetForegroundModeTimeoutMs on SimpleExoPlayer · b0260f7c 
      This is necessary to migrate apps which are using
ExoPlayer.Builder.experimentalSetForegroundModeTimeoutMs
from ExoPlayerImpl to SimpleExoPlayer.

PiperOrigin-RevId: 368657557
      kimvde committed
  3. 15 Apr, 2021 12 commits
    • Fix 1 ErrorProneStyle finding: · 3ab344c2 
      * The Google Java Style Guide requires that each switch statement includes a default statement group, even if it contains no code. (This requirement is lifted for any switch statement that covers all values of an enum.)
  (see http://go/bugpattern/MissingDefault)

This CL looks good? Just LGTM and Approve it!
This CL doesn’t look good? This is what you can do:
* Suggest a fix on the CL (go/how-to-suggest-fix).
* Revert this CL, by replying "REVERT: <provide reason>"
* File a bug under go/error-prone-bug for category ErrorProneStyle if the change looks generally problematic.
* Revert this CL and not get a CL that cleans up these paths in the future by
replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to
opt out the respective paths in your CL Robot configuration instead:
go/clrobot-opt-out.

This CL was generated by CL Robot - a tool that cleans up code findings
(go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/java/com/google/android/libraries/exoplayer/METADATA which is reachable following include_presubmits from //depot/google3/third_party/java_src/android_libs/exoplayer/METADATA.
Anything wrong with the signup? File a bug at go/clrobot-bug.

#codehealth

PiperOrigin-RevId: 368586454
      olly committed
    • Update internal codebase location for av1 extension · 14e085d6 
      PiperOrigin-RevId: 368585664
      andrewlewis committed
    • Tweak discontinuity reason definitions for remote players · 56899cb0 
      Discontinuity reasons may not be precisely obtained for remote
player. 'Remote Player' means that playback is owned by another
app or device and the same playback can be controller by other
clients simultaneously. The MediaController is an example.
If the remote playback doesn't provide discontinuity reason, then
player cannot differentiate between automatic playback transition
and seekTo() from another client.

This CL tweaks the discontinuity reason definitions, so reasons
can be obtained without remote playback's support.
This doesn't effect the local Players, such as SimpleExoPlayer.

PiperOrigin-RevId: 368579577
      jaewan committed
    • Make PositionInfo Bundleable · f0d84f21 
      PiperOrigin-RevId: 368453894
      jaewan committed
    • Core/UI decoupling: Replace SingleTapListener with OnClickListener · d7c71610 
      PiperOrigin-RevId: 368448442
      olly committed
    • Move DeviceComponent in ExoPlayer · 54f3dfb4 
      PiperOrigin-RevId: 368437660
      krocard committed
    • Move TextComponent to ExoPlayer · 5ae84ab5 
      PiperOrigin-RevId: 368428647
      krocard committed
    • Core/UI decoupling: Remove SphericalGLSurfaceView cast · bd654279 
      PiperOrigin-RevId: 368420961
      olly committed
    • Replace Util.toLowerInvariant() with Ascii.toLowerCase() · c50084e7 
      Even when fixed to the US locale (and thus avoiding surprising behaviour
in e.g. Turkish locale with "i" and "I") there are unexpected behaviours
when upper and lower casing non-ASCII characters.

For example it's sometimes not symmetric, e.g.:
"ẞ".toLowerCase() -> "ß"
"ß".toUpperCase() -> "SS"

In all the ExoPlayer usages we are either dealing with known-ASCII
strings (e.g. MIME types) or comparing against ASCII constant strings
anyway, so it seems easier to just use Guava's ASCII-only class in these
cases.

This change also includes some null-twiddling, because
Util.toLowerInvariant() is null tolerant, while Ascii.toLowerCase() is
not. Most of the usages were already non-null, and it was easy enough to
change the remaining ones to be so by simple reordering of statements.

I'll make an equivalent change for Util.toUpperInvariant() next.

PiperOrigin-RevId: 368419813
      ibaker committed
    • Move MetadataComponent from Player to ExoPlayer · 40d3e128 
      PiperOrigin-RevId: 368418142
      krocard committed
    • Update to Gradle plugin 4.1 · f4f31273 
      Some usage of += had to be changed to use .add
because GString can be implitly converted to String
and back, but it is not the case for List<GString>
and List<String>.

PiperOrigin-RevId: 368416727
      krocard committed
    • Move AudioComponent to ExoPlayer leaving key methods in Player · 4fc4ddbc 
      PiperOrigin-RevId: 368413660
      krocard committed
  5. 14 Apr, 2021 3 commits
  7. 13 Apr, 2021 13 commits
  9. 12 Apr, 2021 4 commits
  11. 09 Apr, 2021 4 commits