- 30 Jan, 2020 11 commits
-
-
Passing EXT-X-KEY DrmInitData through the FragmentedMp4Extractor doesn't work for streams with key rotation, because an extractor instance is used for multiple segments, but is only passed the EXT-X-KEY DrmInitData corresponding to the first segment. This change removes passing DrmInitData through the extractor, and instead passes it via FormatAdjustingSampleQueue. This is in-line with how manifest DrmInitData is handled during DASH playbacks. Issue: #6903 PiperOrigin-RevId: 292323429
olly committed -
PiperOrigin-RevId: 292316767
Oliver Woodman committed -
This is a nice-regardless improvement to SampleQueue, which will likely to used to fix the referenced issue. It makes it possible for SampleQueue subclasses to support dynamic changes to format adjustment in a non-hacky way. Issue: #6903 PiperOrigin-RevId: 292314720
olly committed -
PiperOrigin-RevId: 292194805
bachinger committed -
PiperOrigin-RevId: 292161845
ibaker committed -
PiperOrigin-RevId: 292112214
aquilescanta committed -
PiperOrigin-RevId: 292110291
kimvde committed -
PiperOrigin-RevId: 292099759
olly committed -
Issue: #6787 PiperOrigin-RevId: 291953855
kimvde committed -
PiperOrigin-RevId: 291943185
ibaker committed -
Without this, tapping the main video playback doesn't bring up the controls. PiperOrigin-RevId: 291943063
ibaker committed
-
- 29 Jan, 2020 1 commit
-
-
Fix outline style subtitle When a ForegroundColorSpan changes the foreground color, it is also applied to the outline painter. In order to keep the correct color, one needs to filter out theses span. We do this with a new cue that is our text source for the specific edgeLayout. Take care to only apply background color once Test: Manual check - Subtitle view can show custom color subtitles from specific Subtitle Renderer and outline is shown correctly using user defined color.
Nicolas Noury committed
-
- 28 Jan, 2020 10 commits
-
-
Calling setViewType with the same view type as the subtitleView is using would throw InvalidArgumentException instead of being a noop. PiperOrigin-RevId: 291937202
krocard committed -
PiperOrigin-RevId: 291927263
ibaker committed -
We currently have 3 states, but the NOT_SET state isn't needed anymore. We can therefore replace the IntDef by a simple boolean. PiperOrigin-RevId: 291926049
tonihei committed -
We currently apply new parameter checkpoints from an absolute media time and then substract the current media start time again to retrieve the media time offset for this playback parameter checkpoint. However, the media start time may change when unexpected discontinuities happen (the start time doesn't actually change, but we change it to correct for this discontinuity). This then invalidates the absolute media time in the playback parameter checkpoints (which should have been corrected as well). Avoid this problem by also only applying the new start position from the checkpoint. We don't have to save the start position anymore because it will cancel itself out. Also add some documentation and code clarification for improved readability. PiperOrigin-RevId: 291923069
tonihei committed -
PiperOrigin-RevId: 291905440
olly committed -
SubtitleView now becomes a ViewGroup that owns a SubtitleTextView. It handles some common styling defaults, but delegates the underlying values down into SubtitleTextView through the SubtitleView.Output interface. When I add a SubtitleWebView this will also be a ViewGroup containing a WebView and will implement SubtitleView.Output and convert Cue styling into HTML & CSS. PiperOrigin-RevId: 291903294
ibaker committed -
It doesn't seem worth keeping the cap, since the device will presumably stop receiving major version updates at some point anyway. Issue: #6899 PiperOrigin-RevId: 291899439
olly committed -
This also makes them look more like the equivalent tests for the list / array cases. PiperOrigin-RevId: 291890150
olly committed -
This seeker is only seeking to frames that have already been read by the extractor for playback. Seeking to not-yet-read frames will be implemented in another change. Issue: #6787 PiperOrigin-RevId: 291888899
kimvde committed -
PiperOrigin-RevId: 291750515
aquilescanta committed
-
- 27 Jan, 2020 9 commits
-
-
Issue: #6910 PiperOrigin-RevId: 291721229
olly committed -
We currently only keep the requested next content start position while we are playing ads. However, we should also keep at least before a content period is fully prepared to not loose the information about the user intent. PiperOrigin-RevId: 291705752
tonihei committed -
There are existing bugs that need this flag to know whether the current information in the window is still a placeholder or can already be relied on for further calculation. This flag will probably only ever be set in DummyTimeline, so it's not added to the window.set method to avoid updating all clients. Issue:#5924 PiperOrigin-RevId: 291705637
tonihei committed -
PiperOrigin-RevId: 291702471
kimvde committed -
OkHttp 3.12.7 introduced a regression, which was fixed in 3.12.8. PiperOrigin-RevId: 291695577
olly committed -
The tests for the extractor module rely on some core classes. PiperOrigin-RevId: 291688932
andrewlewis committed -
PiperOrigin-RevId: 291405419
kimvde committed -
PiperOrigin-RevId: 291401328
olly committed -
PiperOrigin-RevId: 291397882
kimvde committed
-
- 24 Jan, 2020 9 commits
-
-
PiperOrigin-RevId: 291394101
andrewlewis committed -
PiperOrigin-RevId: 291378636
andrewlewis committed -
It could either live in .util or .extractor, but since it's not needed outside the extractor package in core (and the FLAC extension), and FlacStreamMetadataTest uses a FLAC asset, it seems preferable to move it into the extractor package. PiperOrigin-RevId: 291372032
andrewlewis committed -
CeaUtil depends on TrackOutput so should live in the extractors package. To avoid having Cea708Decoder depend on extractors, this change also moves the initialization data building/parsing to CodecSpecificDataUtil. PiperOrigin-RevId: 291348317
andrewlewis committed -
PiperOrigin-RevId: 291340508
aquilescanta committed -
PiperOrigin-RevId: 291207668
olly committed -
Improve unit tests of binary search methods by making them more behavior-driven. PiperOrigin-RevId: 291175304
kimvde committed -
The deleted path was only used if resetPosition=false and clearPlaylist=true, which is never the case. PiperOrigin-RevId: 291154550
tonihei committed
-