- 21 Feb, 2022 40 commits
-
-
In some cases (whose where we previously used EventListener), AnalyticsCollector is registered as a listener to receive updates, in other cases it is called directly. Avoid this inconsistent handling by registering it as normal listener and removing all callbacks that are handled by the normal listener flow. The remaining direct usages of AnalyticsCollector calls are those callbacks that have no equivalent in Player.Listener. #minor-release PiperOrigin-RevId: 427201525
tonihei committed -
With this change, MediaCodecAudioRenderer always configures MediaCodec with max output channels set to 99 on API 32+. #minor-release PiperOrigin-RevId: 427192801
christosts committed -
SimpleExoPlayer used to register a listener on ExoPlayerImpl for the old EventListener callbacks. Now both classes are merged, this is no longer needed and should be removed in favor of calling methods directly. #minor-release PiperOrigin-RevId: 427187875
tonihei committed -
We have logic to not immediately interrupt playback when an ad group fails to load and instead let the current content play and transition at the point where the ad group should have been. This logic was broken by https://github.com/google/ExoPlayer/commit/dcbdbe53417d6642f2be98c82ac941d34908bd49 because of one of the conditions used MediaPeriodId.adGroupIndex, which is always -1 for content ids. It still worked for the last ad group because the next ad group index was C.INDEX_UNSET. Fix the issue and amend the test that was meant to catch this to test the ad failures for the last ad and previous ads. Also fix the PositionInfo reported in such a case, which was also wrong. Issue: google/ExoPlayer#9929 #minor-release PiperOrigin-RevId: 427143223
tonihei committed -
PiperOrigin-RevId: 427133919
tonihei committed -
PiperOrigin-RevId: 427133817
tonihei committed -
https://github.com/google/ExoPlayer/commit/03e645bab336578c155e46c4114534d346a06cc5
*** Original commit *** Rollback of https://github.com/google/ExoPlayer/commit/9b8ed581d06e2c21b114abc07ed5435b2c96391d *** Original commit *** Add missing imports to ExoPlayerImpl These were missed in https://github.com/google/ExoPlayer/commit/3bb0210d229ffd1455d546fa738dfebbac50f552 #minor-release *** *** PiperOrigin-RevId: 427131696
tonihei committed -
PiperOrigin-RevId: 427131569
tonihei committed -
https://github.com/google/ExoPlayer/commit/12be2bc35791bd00c3af8b403f5db7b14074c55c
*** Original commit *** Rollback of https://github.com/google/ExoPlayer/commit/3bb0210d229ffd1455d546fa738dfebbac50f552 *** Original commit *** Move SimpleExoPlayer logic into ExoPlayerImpl This makes SimpleExoPlayer a simple forwarding wrapper which can be removed in the future. The changes are all purely mechanical with none of the potential further simplifications made yet... *** PiperOrigin-RevId: 427131338
tonihei committed -
Aligning the byte size calculation with the sizes defined in opus_jni.cc for the `outputFloat=true` case #minor-release PiperOrigin-RevId: 427028982
olly committed -
https://github.com/google/ExoPlayer/commit/3bb0210d229ffd1455d546fa738dfebbac50f552
*** Original commit *** Move SimpleExoPlayer logic into ExoPlayerImpl This makes SimpleExoPlayer a simple forwarding wrapper which can be removed in the future. The changes are all purely mechanical with none of the potential further simplifications made yet. The only exceptions are name clashes where either EPI or SEP was calling a method in one of the classes and both classes had different implementations for the same method name. In these cases we needed to disambiguate between the two different implementations (e *** PiperOrigin-RevId: 426997821
olly committed -
PiperOrigin-RevId: 426996878
olly committed -
https://github.com/google/ExoPlayer/commit/9b8ed581d06e2c21b114abc07ed5435b2c96391d
*** Original commit *** Add missing imports to ExoPlayerImpl These were missed in https://github.com/google/ExoPlayer/commit/3bb0210d229ffd1455d546fa738dfebbac50f552 #minor-release *** PiperOrigin-RevId: 426996503
olly committed -
PiperOrigin-RevId: 426994820
olly committed -
PiperOrigin-RevId: 426994559
olly committed -
Transformer's minimum API level is 21, where-as the full library is still targeting 16. Hence we should no longer include the transformer module in the full library dependency. #minor-release PiperOrigin-RevId: 426958045
olly committed -
PiperOrigin-RevId: 426953267
Ian Baker committed -
#minor-release PiperOrigin-RevId: 426938026
ibaker committed -
Some strings didn't mention the context in which they are used (for example as item in a list, or for accessibility). This makes it harder for translators to choose the most appropriate translation and grammar. Also fix repeat and shuffle mode button accessibility descriptions to indicate the action, not the current state. PiperOrigin-RevId: 426924163
tonihei committed -
#minor-release PiperOrigin-RevId: 426909957
ibaker committed -
PiperOrigin-RevId: 426892085
olly committed -
PiperOrigin-RevId: 426876984
olly committed -
These were missed in https://github.com/google/ExoPlayer/commit/3bb0210d229ffd1455d546fa738dfebbac50f552 #minor-release PiperOrigin-RevId: 426872386
ibaker committed -
#minor-release PiperOrigin-RevId: 426870114
ibaker committed -
#minor-release PiperOrigin-RevId: 426868933
ibaker committed -
This class is deprecated (and will be removed from media3). #minor-release PiperOrigin-RevId: 426860018
ibaker committed -
PiperOrigin-RevId: 426855255
ibaker committed -
This ensures Kotlin usages of these IntDef annotations in the 'old' position will continue to compile. 'Frequently used' is a subjective judgement. I have a parallel change that marks all the other public IntDefs in the library as TYPE_USE (those that I've judged to be 'rarely used' by apps). A follow-up change will fix the positions of existing usages to be as if they're only TYPE_USE. #minor-release PiperOrigin-RevId: 426427334
ibaker committed -
This is a breaking change if the annotation itself is in use in Kotlin code. It's judged that the IntDefs in this commit are unlikely to be referred to often in Kotlin code. This is because they're either: - Related to esoteric parts of the library, or - In a common part of the library but only returned from methods (and never passed to callback methods). A follow-up change will fix the positions of existing usages to match this new config. #minor-release PiperOrigin-RevId: 426410237
ibaker committed -
#minor-release PiperOrigin-RevId: 426410137
ibaker committed -
This is not backwards compatible if the @SelectionReason annotation is used in Kotlin code, but before this change there aren't many library surfaces that return a value annotated with @SelectionReason, so it seems relatively unlikely that it is in use in any/many apps. A follow-up change will fix the positions of existing usages to match this new config. #minor-release PiperOrigin-RevId: 426409877
ibaker committed -
This is only used inside AudioFocusManager, it doesn't need to public. Also mark it TYPE_USE and update the position to match. #minor-release PiperOrigin-RevId: 426407790
ibaker committed -
This is only used in DefaultAudioSink, so we could move it there and make it private - but at that point we might as well refer to the underlying AudioManager constants instead. #minor-release PiperOrigin-RevId: 426407661
ibaker committed -
Keep values related to LegacyPlayerView in attrs_legacy_player_view.xml and put all values related to LegacyPlayerControlView back in their original locations. We plan to remove LegacyPlayerView (and attrs_legacy_player_view.xml) from media3, but will keep LegacyPlayerControlView - so the separation of the XML files needs to reflect this split. #minor-release PiperOrigin-RevId: 426406973
ibaker committed -
#minor-release Issue: google/ExoPlayer#9939 PiperOrigin-RevId: 426394339
olly committed -
This only changes IntDefs that cannot be used by apps because they're either private or package-private. A follow-up change will fix the positions of existing usages to match this new config. #minor-release PiperOrigin-RevId: 426372273
ibaker committed -
This makes the delegation model more explicit, and prevents the javadoc compiler from just pulling in the Player javadoc automatically - which can lead to some confusion when some method definitions in Player depend on other methods (e.g. seekForward() is defined in terms of getSeekForwardIncrement()). Issue: google/ExoPlayer#9897 #minor-release PiperOrigin-RevId: 426359004
ibaker committed -
These were messed up in https://github.com/google/ExoPlayer/commit/74c6ef9ba096fe64e767a739b97debca5185a375 Also suppress deprecation warnings when we're just forwarding a deprecated method to the delegate. #minor-release PiperOrigin-RevId: 426351791
ibaker committed -
This type is still known as PlayerView in exoplayer2 #minor-release PiperOrigin-RevId: 426348286
ibaker committed -
This allows us to remove the IMA naming from DefaultMediaSourceFactory's SSAI integration. #minor-release PiperOrigin-RevId: 426346456
ibaker committed
-