- 17 Jan, 2022 7 commits
-
-
Collapse the two variations of `VorbisUtil.buildMetadata` into a single method called `VorbisUtil.parseVorbisComments` that only takes a list of vorbis strings, compared to previously where it would take strings and picture frame instance. Any code that relied on the old signature now either concatenates picture frames and vorbis comments or copies vorbis comments into an existing metadata instance.
OxygenCobalt committed -
Group up some other minor changes with the vorbis comment utils.
OxygenCobalt committed -
Simplify how the comment header is parsed and eliminate a few possible bugs in the process, such as: - Metadata being overwritten directly by the comments header. - The packet being rewound to 0 if it cannot find a comment header, which might result in the cursor being moved to a bad position.
OxygenCobalt committed -
67e1261f messed up some of the other docs. Fix that.
OxygenCobalt committed -
Studio accidentally renamed some of the javadoc to reflect the new vorbis module. Revert it to the dev javadoc, as the ExoPlayer devs don't update the javadoc until a release.
OxygenCobalt committed -
Try to eliminate some nitpicks regarding VorbisUtil.
OxygenCobalt committed -
In the old `flac` module, superclass the deprecated types under the moved types in the `vorbis` module. This ensures backwards compat with existing library users.
OxygenCobalt committed
-
- 16 Jan, 2022 1 commit
-
-
Line up this branch with the dev branch instead of the release branch.
OxygenCobalt committed
-
- 10 Jan, 2022 1 commit
-
-
Slightly cleanup VorbisUtil.
OxygenCobalt committed
-
- 09 Jan, 2022 5 commits
-
-
Refactor the overall module to place the unified vorbis tags into a single package called `vorbis`. Also re-intoduce the vorbis tags in their original `flac` module, but deprecate them.
OxygenCobalt committed -
Add metadata parsing for the Opus format.
OxygenCobalt committed -
The vorbis tests did not expect metadata normally. Now they do.
OxygenCobalt committed -
Move all picture and vorbis frame parsing into a new xiph module. This commit also adds cover frame parsing from vorbis comments as well.
OxygenCobalt committed -
Change how OggReader handles the CommentsHeader instance, enabling VorbisComment tags to be parsed from it.
OxygenCobalt committed
-
- 07 Jan, 2022 10 commits
-
-
#minor-release PiperOrigin-RevId: 420289147
bachinger committed -
The encoder and sonic are now set up in the constructor rather than in a configuration method called from processData(). This is more similar to VideoSamplePipeline and reduces null checks. PiperOrigin-RevId: 420260526
hschlueter committed -
PiperOrigin-RevId: 420056876
hschlueter committed -
PiperOrigin-RevId: 420053894
claincly committed -
Issue: google/ExoPlayer#9800 Added test for RTSP authentication. PiperOrigin-RevId: 420048821
claincly committed -
PiperOrigin-RevId: 420032157
hschlueter committed -
When sending a MediaItem to a MediaSession with a Media3 MediaController important information is removed for privacy reason. To look up the fully populated MediaItem the mediaId is used as a key. Hence having the mediaId marhalled to the JSON representation that is sent to a Cast device enables app developers to use the same look up facilities. #minor-release PiperOrigin-RevId: 420022868
bachinger committed -
Remove wasInitialized in favor of using allocation's nullability to represent the initialization state. PiperOrigin-RevId: 420011311
aquilescanta committed -
PiperOrigin-RevId: 419864140
Oliver Woodman committed -
Only allowing TransformationExceptions to be created using the factory methods helps keeping error messages consistent. This is consistent with ExoPlaybackException. PiperOrigin-RevId: 419841025
hschlueter committed
-
- 05 Jan, 2022 4 commits
-
-
The UI component will be switched over to use them in a subsequent commit, once the translations have been imported. Issue: google/ExoPlayer#9811 PiperOrigin-RevId: 419632617
olly committed -
PiperOrigin-RevId: 419629912
claincly committed -
Compensate for aspect ratio of input frames, so that they're applied on rectangular frames instead of square normalized-device-coordinate frames. This fixes distortion most visible when rotating any GL video 45° (non-rectangular frames) or 90° (stretched frames) Tested by rotating several landscape/portrait demo videos. (Automated tests will follow in <unknown commit>) PiperOrigin-RevId: 419619743
huangdarwin committed -
* Move checking that the output format is supported by the muxer from supportsFormat (which deals with the input format) to ensureConfigured. * Add maps for the supported MIME types so that the muxer can return what MIME types it supports rather than just check a MIME type. PiperOrigin-RevId: 419578165
hschlueter committed
-
- 04 Jan, 2022 12 commits
-
-
John BoWeRs committed
-
PiperOrigin-RevId: 418960700
olly committed -
The `main` role distinguishes a track from an `alternate`, but unlike `SELECTION_FLAG_DEFAULT` it doesn't imply the track should be selected unless user preferences state otherwise. e.g. in the case of a text track, the player shouldn't enable subtitle rendering just because a `main` text track is present in the manifest. The `main`/`alternate` distinction is still available through `Format.roleFlags` and the `ROLE_FLAG_MAIN` and `ROLE_FLAG_ALTERNATE` values. This behaviour was originally [added in 2.2.0](https://github.com/google/ExoPlayer/commit/7f967f305718bc2c9ee679fdd7d014eccef0356b), however at the time the `C.RoleFlags` IntDef did not exist. The IntDef was [added in 2.10.0](https://github.com/google/ExoPlayer/commit/a86a9137be5f0ed89de3d68f4c4800a7753cc881). PiperOrigin-RevId: 418937747
ibaker committed -
PiperOrigin-RevId: 418820557
hschlueter committed -
* @CryptoType is a TYPE_USE annotation, so should appear after modifiers and directly before the type. PiperOrigin-RevId: 418814902
olly committed -
* @Override is not a TYPE_USE annotation, so should appear before any modifiers and after Javadocs. @CryptoType is a TYPE_USE annotation, so should appear after modifiers and directly before the type. PiperOrigin-RevId: 418811744
olly committed -
Before this change we checked whether the playback state and playWhenReady have changed when the state from the cast device arrived. If we detected such a change we called the listener callback `onIsPlayingChanged`. However, in the case when `setPlayWhenReady(boolean)` is called on 'CastPlayer', we mask the change in `playWhenReady`, then send the play/pause request to the cast device and when the state from the cast device arrives we never detect a change because we have already masked `playWhenReady`. This change now moves the check for `isPlaying` to the same place where the state and playWhenReady is updated, so we call the `onIsPlayingChanged` callback in either case, when masking or when a changed state from the server arrives. Issue: google/ExoPlayer#9792 PiperOrigin-RevId: 418483509
bachinger committed -
PiperOrigin-RevId: 418022431
aquilescanta committed -
This is better than silently dropping tracks as done previously. Later, we will implement fallback to transcoding to a supported MIME type. PiperOrigin-RevId: 418006258
hschlueter committed -
* These grouping parentheses are unnecessary; it is unlikely the code will be misinterpreted without them PiperOrigin-RevId: 417988060
olly committed -
This may one day change, but at least for now, we don't intend to support non-square pixels. PiperOrigin-RevId: 417983516
huangdarwin committed -
#minor-release PiperOrigin-RevId: 417961565
ibaker committed
-