- 01 May, 2020 40 commits
-
-
PiperOrigin-RevId: 309390050
ibaker committed -
PiperOrigin-RevId: 309389731
ibaker committed -
PiperOrigin-RevId: 309389571
ibaker committed -
This mimics the behaviour of SubtitleTextView for cues that don't have alignment set. PiperOrigin-RevId: 309389392
ibaker committed -
Issue: #7309 PiperOrigin-RevId: 309387483
aquilescanta committed -
PiperOrigin-RevId: 309258505
aquilescanta committed -
PiperOrigin-RevId: 309245320
ibaker committed -
PiperOrigin-RevId: 309244671
ibaker committed -
PiperOrigin-RevId: 309244135
ibaker committed -
PiperOrigin-RevId: 309243467
ibaker committed -
PiperOrigin-RevId: 309231983
tonihei committed -
Also fix a typo in them PiperOrigin-RevId: 309221515
andrewlewis committed -
We keep an index hint for the next pending player message. This hint wasn't updated correctly when messages are removed due to a timeline update. This change makes sure to only use the hint locally in one method so that it doesn't need to be updated anywhere else and also adds the "hint" suffix to the variable name to make it clearer that it's just a hint and there are no guarantees this index actually exists anymore. issue:#7278 PiperOrigin-RevId: 309217614
tonihei committed -
This also allows subsequent MediaSource instance in the list to still be released successfully. Issue: #7168 PiperOrigin-RevId: 309202170
olly committed -
Implementors should use the new callbacks to clean up any resources associated with the corresponding LoadEventInfo ids. PiperOrigin-RevId: 309198455
aquilescanta committed -
Currently the assertOutput() overloads do quite different things. Also stop returning FakeExtractorOutput from assertOutput (it's not used). PiperOrigin-RevId: 309030386
ibaker committed -
PiperOrigin-RevId: 309022070
olly committed -
testSubtitleEventTimes/IndicesHelper make assertions that only happen to be the same because values in two different constants match up. It seems much better to explicitly put the assertions in each test. The other assert methods are just obscuring the underlying call to Truth. PiperOrigin-RevId: 309022044
ibaker committed -
Steps 4-10 of https://www.w3.org/TR/webvtt1/#cue-computed-line This part is harder to fit into our code structure because it depends on how many cues are simultaneously visible - so it has to go in WebvttSubtitle not WebvttCueParser (which only deals with individual cues in isolation). This removes the `isNormal()` method that was trying to approximate the correct behaviour. PiperOrigin-RevId: 309021686
ibaker committed -
PiperOrigin-RevId: 308999582
olly committed -
PiperOrigin-RevId: 308997845
olly committed -
PiperOrigin-RevId: 308991602
olly committed -
PiperOrigin-RevId: 308988419
andrewlewis committed -
PiperOrigin-RevId: 308985567
olly committed -
Expose this through ExtractorAsserts via a new AssertionConfig object PiperOrigin-RevId: 308980701
ibaker committed -
adPlaybackState is now non-null, and the uninitialized case is covered by a new boolean hasAdPlaybackState. Position progress updates are now non-null and initialized with IMA's VIDEO_TIME_NOT_READY constant. Also fix some misc code issues: - Remove empty branch for SmoothStreaming (Android Studio warns about this). - Tidy onTimelineChanged and onPositionDiscontinuity and the methods they call to improve naming. - Remove logging for IMA events after release, as these methods are expected to be called in the current IMA SDK behavior. PiperOrigin-RevId: 308977116
andrewlewis committed -
The player's initial PlaylistTimeline has no ad cue points, so its first MediaPeriodId has no nextAdGroupIndex. When the AdsMediaSource provides its first timeline, the cue points become known. For the case where a preroll cue point appeared, the preroll was detected due to isAd changing on the MediaPeriodId. For the case where a midroll/postroll cue point appeared, the MediaPeriodId was actually treated as the same, which leads to keeping the unclipped original MediaPeriod. Fix this behavior by checking for nextAdGroupIndex becoming set or decreasing. PiperOrigin-RevId: 308974490
andrewlewis committed -
PiperOrigin-RevId: 308918151
bachinger committed -
PiperOrigin-RevId: 308854072
ibaker committed -
PiperOrigin-RevId: 308846313
aquilescanta committed -
PiperOrigin-RevId: 308844678
olly committed -
PiperOrigin-RevId: 308843488
olly committed -
PiperOrigin-RevId: 308841370
insun committed -
Its only real purpose is to encapsulate a download ID, but it doesn't actually save any code, and arguably makes it more complicated by having multiple lists of Downloader instances, indexed by key, and also because it's another (undocumented) class to understand. This CL retains the multiple Downloader lists, but they will be flattened in a child CL. PiperOrigin-RevId: 308838026
olly committed -
PiperOrigin-RevId: 308835671
olly committed -
This is equivalent to the method ExoPlayer provides. It's nice for consistency, and for retrieving the looper from test code. PiperOrigin-RevId: 308830288
olly committed -
DownloadRunner.getDownloader was creating Downloader instances before the actual DownloadManager under test would have created them. Tests were then asserting and manipulating these Downloader instances, which is quite confusing. In particular FakeDownloader.assertDoesNotStart() is an assertion on a Downloader instance that only makes sense when called on an instance that DownloadManager would not have created by itself. This change replaces FakeDownloader.assertDoesNotStart() with an assertion on DownloadRunner that no Downloader instance has been created. PiperOrigin-RevId: 308822398
olly committed -
- Assertion chaining is generally discouraged. For example, because it's harder to determine which assertion failed given a line number. - Also removed chaining of the form obj.actionX().assertY(), because it's easy for someone editing the test to accidentally delete actionX() when deleting assertY(), where-as actionX() may often be important for subsequent assertions. PiperOrigin-RevId: 308820503
olly committed -
- Remove assertReleased and replace it with a proper condition variable that's opened when Downloader.download or Download.remove finish. As far as I can tell assertReleased was basically implementing "sleep for 10 seconds after the Downloader starts". Note fixing this properly also makes the tests run much faster! - Use ConditionVariable instead of CountDownLatch(1). - Use AtomicInteger instead of volatile int because it's clearer and allows removal of explanatory comments. PiperOrigin-RevId: 308819204
olly committed -
The mocking setup is quite messy/unclear compared to the fakes, but it seems worth switching over because IMA API changes have already required changes to fakes in the past, and there are more API changes in the version we are about to upgrade to. This change should generally remove the need to keep the fakes up-to-date. PiperOrigin-RevId: 308819176
andrewlewis committed
-