- 27 Apr, 2020 35 commits
-
-
sneelavara committed
-
Sadashiva Neelavara committed
-
This changes fixes issue #7181. Removing CEA-608 captions that timeout after 16 seconds without a clear.
Sadashiva Neelavara committed -
This makes the distinction more clear between the methods that test a specific behaviour (and are meant to be used with parameterized tests) and those that test everything in one go. Also add a TODO to FlacExtractorTest to migrate it when we can PiperOrigin-RevId: 308228421
ibaker committed -
Also mark the two assertOutput methods private, to make the API surface smaller. PiperOrigin-RevId: 308228186
ibaker committed -
Unmarshal from json to MediaItem instead of Sample. Further the playlist of MediaItems is converted to Intent extras which are read by the PlayerActivity. PiperOrigin-RevId: 308141231
bachinger committed -
While most ExoPlayer code parsing ByteBuffers is called with buffers in big endian, in certain situation, buffers in little endian are used too. MediaCodec produced ByteBuffers are in little endian, while buffers receive from the sources are in big endian (ByteBuffer's default). As a result, some code called from AudioSink in passthrough parsed bytebuffer in little endian. This is not correct because those format are specified in BigEndian. Changing the endianness of the ByteBuffer returned from MediaCodec would impact a lot more code that can currently be tested in the current COVID lockdown situation. As a result, this patch instead make the parsing code independent of the ByteBuffer.order() set. All the code that is called from DefaultAudioSink now parses the buffer explicitly in Big Endian. Additionally, the MPEG big endian header data of size 4 bytes was retrieved with ByteBuffer.get, which only returns one byte. PiperOrigin-RevId: 308116173
krocard committed -
PiperOrigin-RevId: 308115863
krocard committed -
The first session should only be created once we have the media items and/or called prepare. Otherwise the first session is created with an EventTime having an empty timeline making it less useful. issue:#7193 PiperOrigin-RevId: 308100555
tonihei committed -
Issue: #5978 PiperOrigin-RevId: 308076851
olly committed -
LoadEventInfo needs to also be sent to the LoadErrorHandlingPolicy. PiperOrigin-RevId: 308066998
aquilescanta committed -
This better supports custom listener types defined by MediaSource subclasses. Part of issue:#6765 PiperOrigin-RevId: 308050575
ibaker committed -
This is just some trivial cleanup to get things into a better state to implement parallel segment downloads. Issue: #5978 PiperOrigin-RevId: 308041996
olly committed -
PiperOrigin-RevId: 308041841
aquilescanta committed -
PiperOrigin-RevId: 308031992
olly committed -
The MediaSessionConnector gets a Bundle passed to the MediaSession.Callback from the framework which can be null. This needs to be properly annotated with @Nullable. Issue: #7234 PiperOrigin-RevId: 307822764
bachinger committed -
Issue: #5978 PiperOrigin-RevId: 307819608
olly committed -
Handles pixel aspect ratio changes in playlists where video resolution does not change. Issue:#6646 PiperOrigin-RevId: 307817028
samrobinson committed -
PiperOrigin-RevId: 307789384
aquilescanta committed -
This avoids the non-parameterized tests being run repeatedly for every combination of parameters. PiperOrigin-RevId: 307785770
ibaker committed -
Part of what makes these tests hard to deal with (imo) is being unable to easily run a specific config, or seeing exactly which one failed (because you always see only the first failure). I put the parameters as a method on ExtractorAsserts to reduce the boiler-plate required in each test class. I'll migrate the extension FlacExtractorTest in a follow-up CL PiperOrigin-RevId: 307785380
ibaker committed -
PiperOrigin-RevId: 307777265
aquilescanta committed -
PiperOrigin-RevId: 307776363
tonihei committed -
PiperOrigin-RevId: 307764457
tonihei committed -
PiperOrigin-RevId: 307684243
olly committed -
Something that helps a constructor always seemed a bit strange. It's now possible to use CacheDataSource.Factory directly instead. PiperOrigin-RevId: 307661930
olly committed -
In the same way it made sense to tie CacheKeyFactory and CacheDataSource together in https://github.com/google/ExoPlayer/commit/7ea83d7167d0b021fb280fca2b5dfa4a5616b5c1, it makes sense to tie the PriorityTaskManager to the CacheDataSource as well. This prevents error prone scenarios where one can end up being passed around without (or with the wrong instance of) the other. This change also internalizes use of PriorityDataSource directly into CacheDataSource, rather than requiring the caller to chain things themselves. PiperOrigin-RevId: 307647290
olly committed -
PiperOrigin-RevId: 307636959
olly committed -
The sample timestamps are currently rounded to milliseconds, only to be multiplied by 1000 later. This causes rounding errors where the sample timestamps don't match the timestamps in the seek table (which are already in microseconds). issue:#7086 PiperOrigin-RevId: 307630559
tonihei committed -
Allows media parser to populate crypto data. PiperOrigin-RevId: 307616083
aquilescanta committed -
PiperOrigin-RevId: 307570994
olly committed -
PiperOrigin-RevId: 307534335
gyumin committed -
PiperOrigin-RevId: 307442976
bachinger committed -
issue:#6950 PiperOrigin-RevId: 307411067
ibaker committed -
PiperOrigin-RevId: 307390673
bachinger committed
-
- 20 Apr, 2020 5 commits
-
-
Issue: #7113 PiperOrigin-RevId: 307380133
olly committed -
This change generalizes the concept of "reading parameter sets" to "reading prefix NAL units", ahead of a change that will treat AUD and suffix SEI NAL units in the same way. The change also introduces some static isXxxNalUnit methods for clarity. Issue: #7113 PiperOrigin-RevId: 307376967
olly committed -
Currently we assume these are "start", "center", "middle" or "end", which was correct in a previous draft of the spec: https://www.w3.org/TR/2014/WD-webvtt1-20141111/#dfn-webvtt-text-position-cue-setting The released spec uses "line-left", "center" and "line-right": https://www.w3.org/TR/webvtt1/#webvtt-position-cue-setting PiperOrigin-RevId: 307371066
ibaker committed -
PiperOrigin-RevId: 307368176
Oliver Woodman committed -
Also add unit tests for AdsMediaSource. PiperOrigin-RevId: 307365492
andrewlewis committed
-