- 10 Jan, 2020 7 commits
-
-
PiperOrigin-RevId: 288868298
christosts committed -
Also fix annotation style of the surrounding functions. PiperOrigin-RevId: 288865420
krocard committed -
PiperOrigin-RevId: 288862795
ibaker committed -
I'm going to use these in TtmlDecoderTest PiperOrigin-RevId: 288862274
ibaker committed -
Ultimately we only care if the style is both bold & italic, if some of those are specified multiple times there's no problem. PiperOrigin-RevId: 288862235
ibaker committed -
PiperOrigin-RevId: 288860159
olly committed -
PiperOrigin-RevId: 288855515
andrewlewis committed
-
- 08 Jan, 2020 19 commits
-
-
PiperOrigin-RevId: 288772277
Oliver Woodman committed -
This improves readability by making clearer that reading no bytes from the input in readFrames() is an expected case if the buffer is full. PiperOrigin-RevId: 288711841
kimvde committed -
This doesn't work because the Chronometer text layout can only count in realtime. Issue:#6816 PiperOrigin-RevId: 288711702
tonihei committed -
PiperOrigin-RevId: 288710939
ibaker committed -
Currently, seeks are only tracked if both the start and the end of the seek is within the same window. This means no seeking state is reported if the playback switches to a new window during the seek. This problem is fixed by tracking seek start and end events in all cases, but only report seeking state once the window becomes the foreground window. PiperOrigin-RevId: 288706674
tonihei committed -
The current code relies on Android's evaluation order of spans, which doesn't seem to be defined anywhere. PiperOrigin-RevId: 288700011
ibaker committed -
Without the CSS tweak the additional test assertion fails. PiperOrigin-RevId: 288698323
ibaker committed -
Issue: #6845 PiperOrigin-RevId: 288688716
andrewlewis committed -
Use these to migrate the last WebvttDecoderTest method to SpannedSubject PiperOrigin-RevId: 288688620
ibaker committed -
PiperOrigin-RevId: 288667790
kimvde committed -
Issue: #4078 PiperOrigin-RevId: 288651166
olly committed -
Also remove most classes from the nullness blacklist PiperOrigin-RevId: 288494712
olly committed -
PiperOrigin-RevId: 288476415
christosts committed -
Suppression added in https://github.com/google/ExoPlayer/commit/6f9baffa0cc7daf8cbfd5e1f6c55a908190d2041 PiperOrigin-RevId: 288475120
ibaker committed -
These make the interesting bits of each assertion harder to follow imo. Also remove all the assertWithMessage() calls at the same time, Olly convinced me these are rarely useful since you can click from the stack trace to the failing line in the IDE. PiperOrigin-RevId: 288470704
ibaker committed -
PiperOrigin-RevId: 288468497
olly committed -
PiperOrigin-RevId: 288464154
kimvde committed -
As discussed with Olly, these don't add much info and are liable to go stale. PiperOrigin-RevId: 288463027
ibaker committed -
PiperOrigin-RevId: 288304477
olly committed
-
- 06 Jan, 2020 14 commits
-
-
PiperOrigin-RevId: 288292488
olly committed -
PiperOrigin-RevId: 288285953
ibaker committed -
- Simulate IO exceptions in the test using FlacBinarySearchSeeker for seeking in FlacExtractorTests. This makes the test slower but covers more test cases. PiperOrigin-RevId: 288285057
kimvde committed -
PiperOrigin-RevId: 288280500
tonihei committed -
There's currently no rendering support for ruby text in SubtitleView or SubtitlePainter, but this does have a visible impact with the current implementation by stripping the ruby text from Cue.text meaning it doesn't show up at all under the 'naive' rendering. This is an improvement over the current behaviour of including the ruby text in-line with the base text (no rubies is better than wrongly rendered rubies). PiperOrigin-RevId: 288280416
ibaker committed -
PiperOrigin-RevId: 288280332
ibaker committed -
This will be used when parsing Ruby info from WebVTT and TTML/IMSC subtitles. PiperOrigin-RevId: 288280181
ibaker committed -
PiperOrigin-RevId: 288274998
ibaker committed -
This typo was introduced in https://github.com/google/ExoPlayer/commit/ddb70d96ad99f07fe10f53a76ce3262fe625be70 when migrating a static method with parameter `durationUs` to an instance method where the correct field to use was `blockDurationUs` (but `durationUs` also exists). The test that catches this was only added in https://github.com/google/ExoPlayer/commit/45013ece1e3fe054ff8960355a89559241eeb288 (and therefore configured with the wrong expected output data). issue:#6833 PiperOrigin-RevId: 288274197
ibaker committed -
Remove unused method MediaCodecRenderer#getDequeueOutputBufferTimeoutUs(). PiperOrigin-RevId: 288005572
christosts committed -
PiperOrigin-RevId: 287999703
olly committed -
It's not used. I was trying to work out how to correctly cascade my text-combine-upright styling, but deleting the method seemed easier... PiperOrigin-RevId: 287989480
ibaker committed -
I decided the flags bit was a bit unclear so I played around with this It's also needed for more 'complex' assertions like colors - I didn't want to just chuck in a fourth int parameter to create: hasForegroundColorSpan(int start, int end, int flags, int color) PiperOrigin-RevId: 287989424
ibaker committed -
Relying on the precedence of spans seems risky - I can't find it defined anywhere. It might have changed in Android 6.0? https://stackoverflow.com/q/34631851 PiperOrigin-RevId: 287989365
ibaker committed
-