- 24 Mar, 2022 1 commit
-
-
I am suppressing these warnings so that the stub file can be added and future usages will be checked correctly. As noted in https://developer.android.com/reference/android/view/View#getLayoutParams() this can be null before params are set. This was produced by running the TGP on <unknown commit>. More information: go/new-nullness-stubs-lsc Tested: Automated deflaking failed to skip failures: http://mondo/deflaker/run/ff55923b-d76d-4eba-86dc-1b3077362352 http://test/OCL:435678706:BASE:436509228:1647985874385:4fae6f0a Some test failures are present, but the CL author has decided to mail the change anyway PiperOrigin-RevId: 436951684
olly committed
-
- 23 Mar, 2022 5 commits
-
-
* These grouping parentheses are unnecessary; it is unlikely the code will be misinterpreted without them (see http://go/bugpattern/UnnecessaryParentheses) (11 times) This CL looks good? Just LGTM and Approve it! This CL doesn’t look good? This is what you can do: * Revert this CL, by replying "REVERT: <provide reason>" * File a bug under go/error-prone-bug for category ErrorProneStyle if there's an issue with the CL content. * File a bug under go/rosie-bug if there's an issue with how the CL was managed. * Revert this CL and not get a CL that cleans up these paths in the future by replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to opt out the respective paths in your CL Robot configuration instead: go/clrobot-opt-out. This CL was generated by CL Robot - a tool that cleans up code findings (go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/java/com/google/android/libraries/media/METADATA which is reachable following include_presubmits from //depot/google3/third_party/java_src/android_libs/media/METADATA. Anything wrong with the signup? File a bug at go/clrobot-bug. #codehealth Tested: Local presubmit tests passed. PiperOrigin-RevId: 436726763
olly committed -
PiperOrigin-RevId: 436723149
hschlueter committed -
SEF is similar to frame editing, where the input and output videos are not intended to match, so SSIM will not provide a reliable value. To check SSIM correctly in future, we would need to provide golden/expected video files to compare output against. PiperOrigin-RevId: 436707240
samrobinson committed -
PiperOrigin-RevId: 436702840
hschlueter committed -
Also stabilise the 3 HTTP-based DataSource implementations: * DefaultHttpDataSource * OkHttpDataSource * CronetDataSource PiperOrigin-RevId: 436690643
ibaker committed
-
- 22 Mar, 2022 8 commits
-
-
PiperOrigin-RevId: 436521418
ibaker committed -
All the (Http)DataSource interactions can be done with the DataSource interface and don't need HttpDataSource. PiperOrigin-RevId: 436521036
ibaker committed -
All the (Http)DataSource interactions can be done with the DataSource interface and don't need HttpDataSource. PiperOrigin-RevId: 436520898
ibaker committed -
Depend on a alpha release now, so that we can remove the snapshot repo. PiperOrigin-RevId: 436471634
claincly committed -
PiperOrigin-RevId: 436470453
andrewlewis committed -
PiperOrigin-RevId: 436469107
hschlueter committed -
The FrameProcessorChain manages a List<GlFrameProcessor>. FrameProcessorChainDataProcessingTest now tests chaining ScaleToFit- and AdvancedFrameProcessors. PiperOrigin-RevId: 436468037
hschlueter committed -
To be shared with AviExtractor in a later CL. PiperOrigin-RevId: 436430385
aquilescanta committed
-
- 21 Mar, 2022 5 commits
-
-
PiperOrigin-RevId: 436211808
huangdarwin committed -
Add a MH test exercising this behaviour. PiperOrigin-RevId: 436177198
samrobinson committed -
This allows us to input scale and rotation in an easier-to-use manner. PiperOrigin-RevId: 436175982
huangdarwin committed -
PiperOrigin-RevId: 436174782
bachinger committed -
PiperOrigin-RevId: 436165237
andrewlewis committed
-
- 18 Mar, 2022 4 commits
-
-
This also ensures that if there's an error reading the image data then this gets surfaced as an analysis exception. PiperOrigin-RevId: 435680785
andrewlewis committed -
Add checking for bitrate mode settings. Add logging to the encoder filtering. PiperOrigin-RevId: 435662418
claincly committed -
This currently causes the test to fail on Pixel 6 Pro running a recent S build SQ1D.220205.004. There is no need to test audio transcoding while we are measuring video quality. PiperOrigin-RevId: 435635314
andrewlewis committed -
PiperOrigin-RevId: 435628703
hschlueter committed
-
- 17 Mar, 2022 6 commits
-
-
PiperOrigin-RevId: 435398814
claincly committed -
PiperOrigin-RevId: 435368283
huangdarwin committed -
#minor-release PiperOrigin-RevId: 435360232
bachinger committed -
With this change, the MediaNotificationManager stops MediaSessionService and hides any notifications if the player has no media items or the player hasn't been prepared yet. PiperOrigin-RevId: 435349363
christosts committed -
PiperOrigin-RevId: 435325454
olly committed -
PiperOrigin-RevId: 435308470
hschlueter committed
-
- 16 Mar, 2022 5 commits
-
-
ExternalCopyFrameProcessor's output dimensions match the input size not the output size. So the intermediate texture size should match the input size. Also rename configureOutputDimensions to configureOutputSize. PiperOrigin-RevId: 435058789
hschlueter committed -
More info: go/lsc-assertthrows and go/assertthrows NOTE: if the source of truth for this code is _NOT_ `//third_party/`, please ask for this CL to be reverted. Tested: TAP --sample ran all affected tests and none failed http://test/OCL:434925976:BASE:434869111:1647399186064:de338189 PiperOrigin-RevId: 435047509olly committed -
PiperOrigin-RevId: 435045138
claincly committed -
Some infra thinks the if does not protect against API incompatibilities (example: Android's soong build system). AndroidStudio 2021.3.1 also signals a warning. #minor-release PiperOrigin-RevId: 435027073
aquilescanta committed -
PiperOrigin-RevId: 435009545
claincly committed
-
- 15 Mar, 2022 5 commits
-
-
1. Fix indentation 2. Fix intention to only log one Metadata block PiperOrigin-RevId: 434818209
olly committed -
Use android.util.Size, whose naming is much easier to understand than Pair<Integer, Integer>, in both FrameProcessor and EncoderUtil. PiperOrigin-RevId: 434813986
huangdarwin committed -
Having this in place means that analysis exceptions can be swallowed or thrown as needed. PiperOrigin-RevId: 434788802
samrobinson committed -
* Move auto-adjustments for transformation matrices from the VideoTranscodingSamplePipeline constructor to the new ScaleToFitFrameProcessor. * Add GlFrameProcessor#getOutputDimensions() to allow for GlFrameProcessors with different input and output dimensions. This is a prerequisite for Presentation. * Tested with unit tests (and manually just in case). * A follow up CL will implement change the FrameProcessor input to be scale and rotate values as requested by the user. This was kept out of this CL to reduce CL review size. Presentation will also be implemented in a follow up CL. PiperOrigin-RevId: 434774854
huangdarwin committed -
As pointed out in a previous review, createFallbackTransformationRequest can be a bit confusing to parse. Added javadocs and renamed parameters appropriately, to make it slightly more easy to understand. PiperOrigin-RevId: 434733313
huangdarwin committed
-
- 14 Mar, 2022 1 commit
-
-
https://github.com/androidx/media/commit/98e039d8727344b00c0e37c8b4f9c07cd6561543
*** Original commit *** Rollback of https://github.com/androidx/media/commit/aa22bc2dbeb01fbe3a9905adc8e87a859a3f3dca *** Original commit *** Fix PlayerView touch handling Overriding onTouchEvent was causing multiple issues, and appears to be unnecessary. Removing the override fixes: 1. StyledPlayerView accessibility issue where "hide player controls" actually toggled play/pause. 2. Delivery of events to a registered OnClick... *** PiperOrigin-RevId: 434502423
olly committed
-