1. 13 Dec, 2019 1 commit
    • Make Cue final and change 2 subclasses to delegate-pattern · e8fa9a55
      This avoids needing to jump through type paremeter hoops to create a
      sub-classable Cue.Builder.
      
      Cue should have a standard set of fields, because it will be
      consumed by renderers that don't know what type it is. The
      existing subclass fields are only used inside their respective
      packages, so can be part of a wrapper object instead.
      
      This lays the groundwork for converting Cue's multiple constructors
      into a Builder pattern.
      
      PiperOrigin-RevId: 284992135
      ibaker committed
  2. 11 Dec, 2019 22 commits
  3. 10 Dec, 2019 10 commits
  4. 09 Dec, 2019 7 commits
    • MatroskaExtractor: Support lacing in full blocks · 914a8df0
      Caveats:
      
      - Block additional data is ignored if the block is laced
        and contains multiple samples. Note that this is not
        a loss of functionality (SimpleBlock cannot have block
        additional data, and lacing was previously completely
        unsupported for Block)
      
      - Subrip and ASS samples are dropped if they're in laced
        blocks with multiple samples (I don't think this is
        valid anyway)
      
      Issue: #3026
      PiperOrigin-RevId: 284545197
      olly committed
    • MatroskaExtractor: Constrain use of sample state member variables · 0065f63f
      This change constrains the use of sample state member variables to
      writeSampleData, finishWriteSampleData and resetWriteSampleData.
      Using them elsewhere gets increasingly confusing when considering
      features like lacing in full blocks. For example sampleBytesWritten
      cannot be used when calling commitSampleToOutput in this case
      because we need to write the sample data for multiple samples
      before we commit any of them.
      
      Issue: #3026
      PiperOrigin-RevId: 284541942
      olly committed
    • Fix Javadoc issues · 567f2a65
      PiperOrigin-RevId: 284509437
      olly committed
    • Clean `WakeLockManager.updateWakeLock` logic. · 4b281cec
      PiperOrigin-RevId: 284552723
      samrobinson committed
    • Add NonNull annotations to upstream.cache and upstream.crypto · c90c10c9
      PiperOrigin-RevId: 284548019
      olly committed
    • MatroskaExtractor: Support lacing in full blocks · 0b7f93a5
      Caveats:
      
      - Block additional data is ignored if the block is laced
        and contains multiple samples. Note that this is not
        a loss of functionality (SimpleBlock cannot have block
        additional data, and lacing was previously completely
        unsupported for Block)
      
      - Subrip and ASS samples are dropped if they're in laced
        blocks with multiple samples (I don't think this is
        valid anyway)
      
      Issue: #3026
      PiperOrigin-RevId: 284545197
      olly committed
    • MatroskaExtractor: Constrain use of sample state member variables · 002acc68
      This change constrains the use of sample state member variables to
      writeSampleData, finishWriteSampleData and resetWriteSampleData.
      Using them elsewhere gets increasingly confusing when considering
      features like lacing in full blocks. For example sampleBytesWritten
      cannot be used when calling commitSampleToOutput in this case
      because we need to write the sample data for multiple samples
      before we commit any of them.
      
      Issue: #3026
      PiperOrigin-RevId: 284541942
      olly committed