- 20 Oct, 2020 22 commits
-
-
Consensus is that the NoClassDefFoundError does not causes a crash but only a warning. PiperOrigin-RevId: 338022354
krocard committed -
PiperOrigin-RevId: 338016707
Oliver Woodman committed -
PiperOrigin-RevId: 337824945
andrewlewis committed -
The ExoPlayer receiver app id is a thin wrapper around the default receiver, so there are no reasons for users not to depend on it. By having ExoPlayer users refer to the ExoPlayer app id we can collect usage metrics. PiperOrigin-RevId: 337516767
aquilescanta committed -
This will be used to read ads responses out of data: URLs in a subsequent change. PiperOrigin-RevId: 334778780
andrewlewis committed -
PiperOrigin-RevId: 333036751
kim-vde committed -
This brings in a fix for companion ads rendering when targeting API 29. Issue: #6432 PiperOrigin-RevId: 337279054
andrewlewis committed -
This was causing issues old devices where the class inheriting StreamEventCallback was loaded even though it was not used. Instead use an anonymous class that seem to be loaded more lazily. PiperOrigin-RevId: 337252687
krocard committed -
Issue: #8014 PiperOrigin-RevId: 337142176
krocard committed -
Issue: #8067 PiperOrigin-RevId: 337122011
bachinger committed -
The 'implementation' dependency causes problems when resolving ListenableFuture in contexts that also include the com.google.guava:listenablefuture:1.0 dependency. Issue: #7905 Issue: #7997 Issue: #7993 PiperOrigin-RevId: 337093024
ibaker committed -
Issue: #7961 PiperOrigin-RevId: 337069152
Oliver Woodman committed -
This will reduce the amount of boilerplate required to pass the configuration values around (especially in a planned future change when logic is factored out of ImaAdsLoader). PiperOrigin-RevId: 337058355
andrewlewis committed -
This is in preparation for supporting playlists of ads media sources using ImaAdsLoader. Existing ways of passing ad tags should still function but are deprecated (and won't be supported with playlists). Issue: #3750 PiperOrigin-RevId: 335618364
andrewlewis committed -
This change was meant to be in https://github.com/google/ExoPlayer/commit/2e5f2f12adda1b71b9520bf7b2b0a755f41d6cbd but was not added my mistake. PiperOrigin-RevId: 337041686
kimvde committed -
Issue: #8044 PiperOrigin-RevId: 336955479
bachinger committed -
PiperOrigin-RevId: 336875300
kim-vde committed -
1. The first time the player controls are are made visible, there is no animation. 2. The first time the player controls are made visible, the "select tracks" button isn't displayed. When tapping to subsequently hide the player controls, the button briefly becomes visible and then is hidden again. This bug is due to state in StyledPlayerControlViewLayoutManager being out of sync, resulting in StyledPlayerControlView's onVisibilityChange not being called properly. After this change both of these issues should be resolved. PiperOrigin-RevId: 336704031
olly committed -
This should fix gradle errors like: "warn: removing resource com.google.android.exoplayer2.demo:string/exo_controls_fastforward_by_amount_description without required default value." PiperOrigin-RevId: 336670827
andrewlewis committed -
We stopped using using this MIME type in https://github.com/google/ExoPlayer/commit/74a9d8f680995f2096c59fde6cd1ef6e85bb4d55 This broke subtitle decoding in some cases (Issue: #7985), which I fixed in https://github.com/google/ExoPlayer/commit/7b8895d655c9b48e042f66045bc9c7ab27e93346. After some discussion we've decided SubtitleDecoderFactory shouldn't depend on Format.containerMimeType (since the samples have already been extracted by this point, so the container shouldn't matter). So this change fixes DashManifestParser to use MimeTypes.APPLICATION_MP4VTT (and reverts the no-longer-needed SubtitleDecoderFactory change). PiperOrigin-RevId: 336668450
ibaker committed -
PiperOrigin-RevId: 336643621
ibaker committed -
Adjusted the bottom layout of StyledPlayerControlView : - Enlarged bottom button's height to make tapping easier. - Extended greyed background area to upper edge of seekbar. - Gave padding between bottom edge of the overall layout and bottom buttons. - Reduced horizontal margins between bottom buttons. PiperOrigin-RevId: 336041160
insun committed
-
- 17 Oct, 2020 18 commits
-
-
Issue: #8024 PiperOrigin-RevId: 335846035
bachinger committed -
The bug affects playlists that start with an I-FRAME only variant. Issue: #8025 PiperOrigin-RevId: 335819497
aquilescanta committed -
PiperOrigin-RevId: 335642909
andrewlewis committed -
Issue: #8005 PiperOrigin-RevId: 335625992
kimvde committed -
Context: Issue: #7988 PiperOrigin-RevId: 335608610
kimvde committed -
Issue: #7944 PiperOrigin-RevId: 335012643
andrewlewis committed -
`subtitle` is only guaranteed to be non-null if `nextSubtitleEventIndex != C.INDEX_UNSET`. The null check added in https://github.com/google/ExoPlayer/commit/0efec5f6c12a5d583f24c122fbcbc1b1eebbabc3 was too early. Issue: #8017 PiperOrigin-RevId: 334777742
ibaker committed -
This was broken by https://github.com/google/ExoPlayer/commit/74a9d8f680995f2096c59fde6cd1ef6e85bb4d55 because DashManifestParser switched to setting Format.sampleMimeType to text/vtt while SubtitleDecoderFactory was still expecting application/x-mp4-vtt. This change teaches SubtitleDecoderFactory to check both Format.containerMimeType and Format.sampleMimeType. I'll investigate a follow-up change to remove MimeTypes.APPLICATION_MP4VTT completely (it's currently still used in AtomParsers). Issue: #7985 PiperOrigin-RevId: 334771672
ibaker committed -
This holds shared test infrastructure that needs to depend on Robolectric. PiperOrigin-RevId: 334604041
ibaker committed -
When I moved ParsableByteArray#data behind a getter I replaced some assignments with calls to reset(byte[]): https://github.com/google/ExoPlayer/commit/ce2e6e2fd625db787b1f400614adcd7458144bbd reset(byte[]) deliberately sets `limit` to `data.length`, in order to handle cases that were reassigning `data` but not updating `limit`. However OggPacket was already using `limit` to track where to write 'new' data into the array, so changing `limit` to `data.length` caused us to try and write new data beyond the end of the array. I looked at other uses of reset(byte[]) in https://github.com/google/ExoPlayer/commit/ce2e6e2fd625db787b1f400614adcd7458144bbd and condluded the only other usage in MatroskaExtractor is legit and shouldn't be updated like this (because MatroskaExtractor previously *wasn't* correctly updating/maintaining `limit`). Issue: #7992 PiperOrigin-RevId: 334601586
ibaker committed -
PiperOrigin-RevId: 334567234
andrewlewis committed -
PiperOrigin-RevId: 334562209
andrewlewis committed -
Non-realtime AudioTrack playback speed was not taken into account when extrapolating the old mode's position, causing the position not to advance smoothly. This should be a no-op when not using AudioTrack playback params for speed adjustment. Issue: #7982 PiperOrigin-RevId: 334151163
andrewlewis committed -
Every other subtitleButton has an if not null check, but does not force non null. Issue: #7962 PiperOrigin-RevId: 334124323
samrobinson committed -
On receiving a fetch error for an ad that would otherwise play based on an initial/seek position, the pending content position wasn't cleared which meant that position reporting was broken after a fetch error. Fix this by always clearing the pending position (if there was a pending position that will have triggered the fetch error). Also deduplicate the code for handling empty ad groups (fetch errors) and ad group load errors. Issue: #7956 PiperOrigin-RevId: 334113131
andrewlewis committed -
PiperOrigin-RevId: 333751261
Oliver Woodman committed -
Issue: #7949 PiperOrigin-RevId: 333733615
kimvde committed -
ISSUE: #7977 PiperOrigin-RevId: 333726625
bachinger committed
-