- 29 Jul, 2021 3 commits
-
-
This CL doesn't introduce functional changes. PiperOrigin-RevId: 387613057
aquilescanta committed -
The dokka javadoc generation tool complains when parameter names don't match between a method and its override. This change updates occurrences where there is currently a mismatch. PiperOrigin-RevId: 387367509
andrewlewis committed -
PiperOrigin-RevId: 387301144
aquilescanta committed
-
- 28 Jul, 2021 2 commits
-
-
The dokka javadoc generation tool complains when parameter names don't match between a method and its override. This change updates occurrences where there is currently a mismatch. Notable renamings that might be controversial: - `onPlaybackStateChanged(int state)` to `onPlaybackStateChanged(int playbackState)` affected a lot of lines but seems more consistent with other '-Changed' methods. - `handleMessage(int messageType, Object payload)` to `handleMessage(int messageType, Object message)` - `ExtractorInput` and `DataSource` inherit `DataReader` which had `read(byte[] target, ...`, while data sources normally called the first parameter `buffer`. I have standardized these all to use `buffer` even though it looks out of place in the `ExtractorInput` interface (which has more `read` methods with `target`). PiperOrigin-RevId: 387290360
andrewlewis committed -
The documentation on ByteArrayOutputStream and GZIPOutputStream isn't completely clear that an IOException will *never* happen, so AssertionError seems a bit strong - but it seems very unlikely, so we just use IllegalStateException instead. #minor-release PiperOrigin-RevId: 387169297
ibaker committed
-
- 27 Jul, 2021 17 commits
-
-
In order to avoid confusion with HTTP 400 Bad request. PiperOrigin-RevId: 387145057
aquilescanta committed -
PiperOrigin-RevId: 387143625
aquilescanta committed -
PiperOrigin-RevId: 387143449
bachinger committed -
PiperOrigin-RevId: 387090075
bachinger committed -
In favor of setting the cause in the constructor, which allows some code simplifications. PiperOrigin-RevId: 387062636
aquilescanta committed -
PiperOrigin-RevId: 386970718
olly committed -
#minor-release PiperOrigin-RevId: 386966219
olly committed -
The inference is used when nesting DataSourceExceptions. It is removed because nesting does not add additional value in surfacing the exceptions, and it is better to assign an error code at the throw site (in the "leaf" or the bottom most data source). PiperOrigin-RevId: 386919118
claincly committed -
Doclava outputs an error when handling the javadoc where the `@see` clause is an anchor but also has other content. PiperOrigin-RevId: 386875722
andrewlewis committed -
Issues: #771 and #7654 PiperOrigin-RevId: 386850707
bachinger committed -
* @Flags is not a TYPE_USE annotation, so should appear before any modifiers and after Javadocs. (see go/java-style#s4.8.5-annotations) This CL looks good? Just LGTM and Approve it! This CL doesn’t look good? This is what you can do: * Suggest a fix on the CL (go/how-to-suggest-fix). * Revert this CL, by replying "REVERT: <provide reason>" * File a bug under go/error-prone-bug for category ErrorProneStyle if the change looks generally problematic. * Revert this CL and not get a CL that cleans up these paths in the future by replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to opt out the respective paths in your CL Robot configuration instead: go/clrobot-opt-out. This CL was generated by CL Robot - a tool that cleans up code findings (go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/java/com/google/android/libraries/media/METADATA which is reachable following include_presubmits from //depot/google3/third_party/java_src/android_libs/media/METADATA. Anything wrong with the signup? File a bug at go/clrobot-bug. #codehealth PiperOrigin-RevId: 386849198
olly committed -
PiperOrigin-RevId: 386841818
olly committed -
PiperOrigin-RevId: 386836747
bachinger committed -
PiperOrigin-RevId: 386521255
bachinger committed -
The reason this was not an IO error code is that before other IOExceptions were classified, this catch would grab non-IO error codes, like ParserException. Now that we are getting closer to the final state, we can assume IOExceptions are ok to classify as IO error codes (unlike, for example, ParserExceptions or DrmSessionExceptions). PiperOrigin-RevId: 386496752
aquilescanta committed -
PiperOrigin-RevId: 386453305
olly committed -
PiperOrigin-RevId: 386442542
bachinger committed
-
- 23 Jul, 2021 8 commits
-
-
https://github.com/google/ExoPlayer/commit/4c10d2bd4c046ede62dd47c89cab127483c17cdc
*** Original commit *** Migrate /-as-division to math.div If google3 is the source-of-truth for this third_party code (or if this is legacy code that is no longer synced with an external source), just LGTM this CL and Rosie will submit it. If not, you should patch the upstream source of these files, since we will be disabling support for /-as-division in google3 before support is formally removed from the language. See go/lsc-slash-as-division-deprecation. Tested: TAP found no affected targets. No targets were b... *** PiperOrigin-RevId: 386432441olly committed -
PiperOrigin-RevId: 386428758
kim-vde committed -
PiperOrigin-RevId: 386401066
kimvde committed -
PiperOrigin-RevId: 386232697
aquilescanta committed -
PiperOrigin-RevId: 386227630
kimvde committed -
Using all lower case RTSP headers is perfectly valid, as the spec mandates case insensitively. However, some RTSP servers do not implement the RTSP spec closely and does not recognize the lower case headers. This change aims at using the header names as defined in the RTSP spec to maximize compatibility. Issue: #9182 PiperOrigin-RevId: 386224566
claincly committed -
ybai001 committed
-
Merge from Google dev-v2 branch
ybai001 committed
-
- 22 Jul, 2021 6 commits
- 21 Jul, 2021 4 commits