- 20 Sep, 2018 4 commits
-
-
The DefaultTrackSelector can now be constructed without leaving out a vital part of the initialization. This allows this new simple factory method. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=213438163
tonihei committed -
This reduces the possiblity of regressions. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=213436912
aquilescanta committed -
Currently there is no way to disable (or reduce) the logcat output generated by ExoPlayer. Issue:#4665 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=213421072
tonihei committed -
This allows creating multiple HLS media sources from a single Factory, as required by the interface. Issue:#4814 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=213297850
aquilescanta committed
-
- 17 Sep, 2018 8 commits
-
-
Issue: #4824 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=213285790
olly committed -
ExoPlayer can be run on a background thread, but some components (UI and IMA) only support players on the main thread. This adds some documentation and assertions for that. To simplify assertions, this also moves the getApplicationLooper method from ExoPlayer to Player. Issue:#4439 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=213280359
tonihei committed -
Kotlin will throw NPE whenever a method returns null or an interface is called with a null parameter and the respective values are not marked as @Nullable. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=213262886
tonihei committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=213248388
aquilescanta committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=213245186
andrewlewis committed -
To check the validity of a window index it needs to be compared with a greater or equal sign to the window count. Issue:#4822 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=213234403
tonihei committed -
Also prevent an unnecessary allocation when the removed range is empty. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=212993427
aquilescanta committed -
Not having this annotation may cause Kotlin implementations to fail. Issue:#4802 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=212980643
tonihei committed
-
- 13 Sep, 2018 4 commits
-
-
If we can select a track that has a strictly higher score than a selection already made for a renderer of the same type, we should prefer it. Issue: #4711 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=212835895
olly committed -
- Make addMediaSource a specific case of addMediaSources. - Make clear a specific case of removeMediaSourceRange. - Make removeMediaSource a specific case of removeMediaSourceRange. - Remove the unnecessary message handling and constants. - Move a method so that depending appears before depended. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=212809667
aquilescanta committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=212790665
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=212644046
olly committed
-
- 12 Sep, 2018 24 commits
-
-
Issue: #4771 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=212623142
olly committed -
Issue: #4185 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=212619419
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=212443793
andrewlewis committed -
This allows to update the shuffle order after the ConcatenatingMediaSource has been created. ShuffleOrder objects should be immutable to ensure thread safety and thus there is no way to do this currently. Issue:#4791 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=212443146
tonihei committed -
- Fixes the referenced issue. - Provides more consistent behavior for the edge case of empty chunks (i.e. chunks containing now samples). Format changes will now always be reported for such chunks, unless the empty chunk is discarded from upstream before there's a chance to do so. Issue: #4533 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=212443043
olly committed -
When the stream is changed in the audio renderer, the timestamps of the samples can no longer be expected to match the calculations in the AudioSink. This change tracks the samples at which the stream is changed and notifies the AudioSink of the discontinuity. Issue:#4559 Issue:#3829 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=212435859
tonihei committed -
When a reset is pending the sample queues normally contain pre-seek samples (which will be emptied when a pending load is canceled). The position passed to discard will be a post-seek position. I don't think anything bad happened in any of the cases being changed, but discarding is unnecessary in such cases, and reasoning about such cases is difficult. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=212435556
olly committed -
- This makes it so that onDownstreamFormatChanged will occur before the corresponding renderer event. This was not previously the case, since the renderer would typically read the format (and report its event), then a sample (causing the onDownstreamFormatChanged event). - The remaining ones to update are ChunkSampleStream (DASH + HLS), which will be done in a way that fixes #4533, and HLS. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=212434874
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=212432661
olly committed -
If there's already a pending reset, we need only update the pending reset position. We can currently end up calling cancelLoading more than once on the loader for the same task, which is hard to reason about (although I don't think anything actually broke in practice). ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=212432266
olly committed -
We currently apply the track.timescale whereas we should be applying the track.movieTimescale. The parsing for the trak atom does this correctly and the duration from the trak atom currently always takes precedence over the durations from the stbl atoms as it's always larger. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=212421687
tonihei committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=212303130
andrewlewis committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=212276150
tonihei committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=212266041
andrewlewis committed -
Ignoring all edit lists if they don't start with a keyframe causes A/V sync issues when valid edit lists are applied at the beginning. This change allows such edit lists again but removes all samples before the first keyframe (these samples would be ignored by the renderer anyway if at the beginning OR cause visible distortions when appended to an unrelated keyframe). Issue:#4774 Issue:#4348 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=212244407
tonihei committed -
Currently causing GTS tests to fail. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=212244198
tonihei committed -
Issue:#2025 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=211977802
aquilescanta committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=211976724
aquilescanta committed -
- There's no particular need to read or skip a sample before notifying - Add missing isPendingReset check Issue: #4533 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=211959762
olly committed -
The default character set is always UTF-8 anyway on Android, but we don't want our code to behave any differently where it's not (e.g. robolectric test runs could potentially run in an environment where UTF-8 isn't the default?). ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=211953885
olly committed -
This prevents repeated instantiation of empty arrays. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=211941723
tonihei committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=211854408
josephmarques committed -
Reverts the BOM check changes in [] ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=211826731
aquilescanta committed -
1. Currently, we may throw source info refresh errors while the previous media period is still playing. 2. We don't throw if the next period in a playlist fails to prepare and the previous renderers are all disabled. 3. We throw source info refresh errors for playlists before playback reaches the culprit source. This change: 1. Defers the exceptions until all existing media periods have been played. 2. Checks for period preparation exception if the next period is not getting prepared and the renderer time reached the next period. 3. Does no longer throw from ConcatenatingMediaSource.maybeThrowSourceInfo RefreshError. The deferred media periods take care of that for each source individually. Issue:#4661 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=211819436
tonihei committed
-
