Commits · de82a2be336e9308e194d5baf91c348a2700a5de · SDK / exoplayer

30 Sep, 2022 40 commits

Effect: Update javadoc to remove "final effect" references · de82a2be

"Final" was likely added to reference the FinalMatrixTextureProcessorWrapper,
which is a package-private class. However, I think more clear to express that
this is the input size, which then has all effects applied, to get the output
size.

PiperOrigin-RevId: 477975358

committed Sep 30, 2022

de82a2be

Tests: Statically import BitmapTestUtil methods. · d5c272fd
```
Per go/java-practices/imports#static

No functional changes intended.

PiperOrigin-RevId: 477974779
```
huangdarwin committed Sep 30, 2022
d5c272fd Browse Files

Test: Rename to avoid redundant substrings. · 62b95a71

Rename test files to avoid substrings that can be implied by the directory name,
like "Transformation" and "Test"

No functional changes. Renaming-only.

PiperOrigin-RevId: 477724724

committed Sep 30, 2022

62b95a71 Browse Files

Demo: Split video Effect generation out of createTransformer. · 1cfe18cd
```
PiperOrigin-RevId: 477524540
```
samrobinson committed Sep 30, 2022
1cfe18cd Browse Files
HDR: Add period to end of error message. · 1711d7f4
```
For tone mapping error messages.

PiperOrigin-RevId: 477447799
```
huangdarwin committed Sep 30, 2022
1711d7f4 Browse Files
HDR: Add tests for tone mapping. · aec4fe73
```
Also, add checks for output file color.

PiperOrigin-RevId: 477439139
```
huangdarwin committed Sep 30, 2022
aec4fe73 Browse Files
Fix checkboxes on configuration page · bb811f0d
```
PiperOrigin-RevId: 477166507
```
Googler committed Sep 30, 2022
bb811f0d Browse Files
Remove unofficial link from test case · 9e310150
```
PiperOrigin-RevId: 477101201
```
bachinger committed Sep 30, 2022
9e310150
Clarify PlaybackParameters constructor range. · 7c055c96
```
PiperOrigin-RevId: 476937845
```
samrobinson committed Sep 30, 2022
7c055c96 Browse Files
Fix badly formatted AudioProcessor javadoc. · 3e4aa050
```
PiperOrigin-RevId: 476909855
```
samrobinson committed Sep 30, 2022
3e4aa050 Browse Files

Remove test that just times out · d2887d52

One of the tests in MediaBrowserListenerTest caused the remote
browser service to crash and then just timed out. As this asserts
nothing useful besides checking that the timeout method is working,
we can remove the test.

Crashing the remote browser service had the side effect of letting
subsequent tests in the same class fail because the previous session
was never released and was still present in the static MediaSession
SESSION_ID_TO_SESSION_MAP instance, which prevented the creation
of new sessions with the same id. This is only an issue in test
runs because a real process would also lose its static variables
when it crashes.

PiperOrigin-RevId: 476905337

committed Sep 30, 2022

d2887d52

Don't start the service in the foreground with a pause intent · acd9e581

`PlaybackStateCompat.toKeyCode(command)` was replaced by our
own implementation of `toKeyCode()`. The legacy implementation used PLAY and PAUSE, while the new implementation uses PLAY_PAUSE. This made `pause` a pending intent that attempt to start the service in the foreground, but `service.startForeground()` won't be called in `MediaNotificationManager.updateNotificationInternal` when paused.

PiperOrigin-RevId: 476895752

committed Sep 30, 2022

acd9e581 Browse Files

HDR: Update gamma comments to linear. · 16dca182
```
Comment-only change.

PiperOrigin-RevId: 476873286
```
huangdarwin committed Sep 30, 2022
16dca182

Call callback future listeners on app handler · 74124f48

Calling maybeUpdateLegacyErrorState potentially creates a new legacy playback
state which involves calling player methods. This change makes sure that the call
sites of `maybeUpdateLegacyErrorState` are called on the app thread as enforced by
the library.

PiperOrigin-RevId: 476406282

committed Sep 30, 2022

74124f48 Browse Files

Add setPreferredAudioDevice method to ExoPlayer · a069ebda

This allows to access the associated functionality of AudioTrack and
fills a feature gap to MediaPlayer, which has a similar method.

Issue: androidx/media#135
PiperOrigin-RevId: 476398964

committed Sep 30, 2022

a069ebda Browse Files

Add example CLUT to demo. · 5b3efa8a
```
PiperOrigin-RevId: 476390089
```
leonwind committed Sep 30, 2022
5b3efa8a Browse Files

Store LUT bitmap as texture with processor creation. · 44b9aec0

* Before this CL, the texture was stored during the construction of the LUT processor. This failed since if one creates a list of GlEffects on the application thread, the texture will get stored in the application thread during the effect creation and not on the GL thread, which executes the FrameProcessors.
* This is an issue since the executing thread then can't index from the texture stored on a different thread.

PiperOrigin-RevId: 476388021

committed Sep 30, 2022

44b9aec0

Merge pull request #123 from stoyicker:wrapping_media_source · cac8c4f6
```
PiperOrigin-RevId: 476376463
```
Marc Baechinger committed Sep 30, 2022
cac8c4f6 Browse Files
Add HSL Adjustments to the demo. · 7626f70c
```
PiperOrigin-RevId: 476373520
```
leonwind committed Sep 30, 2022
7626f70c Browse Files
Remove TODOs for merging RGB and MatrixTransformation processors. · 7eb0ce62
```
PiperOrigin-RevId: 476362571
```
leonwind committed Sep 30, 2022
7eb0ce62

Try alternative decoder for Dolby Vision if display does not support · ed79f469

If the sample type is dolby vision and the following conditions match
a)There is a supported alternative codec mimetype
b)Display does not support Dolby Vision
Then getDecoderInfos will return the alternative types.

Issue: google/ExoPlayer#9794
PiperOrigin-RevId: 476356223

committed Sep 30, 2022

ed79f469 Browse Files

HDR: Assert output C.ColorTransfer for tests. · 87fd51a3
```
To confirm that tone mapping did or did not happen.

PiperOrigin-RevId: 476354606
```
huangdarwin committed Sep 30, 2022
87fd51a3 Browse Files
Add HSL Adjustments to the effects module. · dc9fa4f4
```
PiperOrigin-RevId: 476144167
```
leonwind committed Sep 30, 2022
dc9fa4f4 Browse Files

Add OETF and EOTF ES2 fragment shaders for non-HDR frames. · 3433758c

* Transform the intermediate color space to linear SDR by applying the SMPTE 170M EOTF and OETF.
* Use linear colors for the color filter pixel tests and update all golden bitmaps.

PiperOrigin-RevId: 476124592

committed Sep 30, 2022

3433758c Browse Files

Work around a bug in the Android 13 ClearKey implementation · 715c9480

The ClearKey CDM will attach an 'invalid' URL in `KeyRequest` objects,
when the documentation states this should be an empty string if a
default URL is not known.

#minor-release

PiperOrigin-RevId: 476113513

committed Sep 30, 2022

715c9480 Browse Files

Add RGB Adjustments to transformer demo. · 9ccdd22e
```
PiperOrigin-RevId: 476049125
```
leonwind committed Sep 30, 2022
9ccdd22e Browse Files
Add file size to TransformationResult at the end of a Transformation. · 9ec4e134
```
Tested:
  * Manually using both path and file descriptor.
PiperOrigin-RevId: 475860978
```
samrobinson committed Sep 30, 2022
9ec4e134 Browse Files
Use golden bitmaps in contrast pixel tests. · f00e43cf
```
PiperOrigin-RevId: 475805421
```
leonwind committed Sep 30, 2022
f00e43cf Browse Files
Fix instrumentation tests not working via Gradle · c96e010d
```
PiperOrigin-RevId: 475560401
```
rohks committed Sep 30, 2022
c96e010d
Fix outdated command in bitmap/README.md. · 75141f30
```
* The command changed after creating a custom effects module.

PiperOrigin-RevId: 474777823
```
leonwind committed Sep 30, 2022
75141f30 Browse Files

Fix tracing under offload. · 06230f19

Currently doSomeWork is never closed and so tracing is deceiving.

See https://screenshot.googleplex.com/eZDzn5APpBNnhe5

PiperOrigin-RevId: 474755816

committed Sep 30, 2022

06230f19 Browse Files

Add LUT functionalities to transformer. · f55a5146
```
* Adds SDR 3D LUT functionalities with OpenGL 2.0 support.

PiperOrigin-RevId: 474561060
```
leonwind committed Sep 30, 2022
f55a5146
Fix testId and match it to the test name. · ab6562e0
```
PiperOrigin-RevId: 474363545
```
leonwind committed Sep 30, 2022
ab6562e0 Browse Files
Add support for skipping windows in MssimCalculator. · 314b312a
```
By skipping every other row and column, SSIM calculation time reduces by 10-30%.

PiperOrigin-RevId: 474286702
```
samrobinson committed Sep 30, 2022
314b312a Browse Files
Clarify the replaceOutputBuffer parameter because count is unclear. · bca9c9b2
```
PiperOrigin-RevId: 474279220
```
samrobinson committed Sep 30, 2022
bca9c9b2 Browse Files
Change ContrastProcessor java doc for consistency. · 60ea6473
```
PiperOrigin-RevId: 474002026
```
leonwind committed Sep 30, 2022
60ea6473 Browse Files
Add MssimCalculatorTest to verify SSIM calculations. · 8ce42f06
```
As part of this change, MssimCalculator is moved from androidTest/ to main/

PiperOrigin-RevId: 473771344
```
samrobinson committed Sep 30, 2022
8ce42f06 Browse Files

Add java docs for ContrastProcessor constructor. · 7a460fa3

* Add docs for the public constructor for consistency with all the
other frame processors.

PiperOrigin-RevId: 473726586

committed Sep 30, 2022

7a460fa3 Browse Files

Add rgb matrices to java docs for public constructors. · 10cb5f17
```
PiperOrigin-RevId: 473699927
```
leonwind committed Sep 30, 2022
10cb5f17 Browse Files
Split decoding out of the test · 7f42e19f
```
This method is useful for other tests also.

PiperOrigin-RevId: 473574282
```
claincly committed Sep 30, 2022
7f42e19f Browse Files