- 30 Nov, 2020 12 commits
-
-
This is needed to support old binary builds that still rely on the existance of this class. PiperOrigin-RevId: 344799495
tonihei committed -
PiperOrigin-RevId: 344787160
tonihei committed -
Broken in https://github.com/google/ExoPlayer/commit/bf21e3c690cfbab6cdbb76b3dd6e353f7221b3f1. PiperOrigin-RevId: 344777455
aquilescanta committed -
The inner class was only used to obtain 3 distinct pieces of information which is better handled by static methods. #exofixit PiperOrigin-RevId: 344767661
tonihei committed -
#player-to-common PiperOrigin-RevId: 344558028
krocard committed -
PiperOrigin-RevId: 344535069
olly committed -
PiperOrigin-RevId: 344526343
andrewlewis committed -
As opposed to in-source git-clone. PiperOrigin-RevId: 344525899
aquilescanta committed -
#exofixit PiperOrigin-RevId: 344517105
andrewlewis committed -
#exofixit PiperOrigin-RevId: 344516187
samrobinson committed -
This copy will be removed once Player is migrated to common. #exo-offload PiperOrigin-RevId: 344515979
krocard committed -
This method should be assumed to clear the data of the underlying array (it will do this if the new limit > data.length). This means it should only be called (directly) before writing into the backing array. It shouldn't be used as a shorthand for position=0, limit=x - those should be two explicit method calls. Most of these changes are no-ops, but they make the code more correct. The TS SectionReader can't be easily changed to be 'safe', because it relies on sectionData maintaining state between iterations of the while loop. Instead I've added comments justifying the existing code. PiperOrigin-RevId: 344515340
ibaker committed
-
- 27 Nov, 2020 23 commits
-
-
The workaround to post a message was needed to ensure we receive any final onIsPlayingChanged event before the test is finished (to record the correct playing time). Using onEvents allows us to do this synchronously as the callback guarantees that there is no other pending event. #exofixit PiperOrigin-RevId: 344436180
tonihei committed -
#exofixit PiperOrigin-RevId: 344428571
olly committed -
This ensures we have full test coverage for proguard configs now. The only configs not covered by tests are: - IMA and OkHttp which copy recommended configs from the respective library. I couldn't reproduce failures by removing them (and thus couldn't write a test that ensures they are correct). - Some dontwarn lines that just suppress warnings. In addition, this change fixes a couple of related issues: - Moved AV1 proguard config to correct module. - Removed mentioning of deprecated ExtractorMediaSource from README - Suppressed warning from IMA code that prevent proguarding under strict rules - Fixed wrong proguard exclusion in VP9 module. - Moved FLAC exclusion (DefaultExtractorsFactory) to correct module. - Added AlertDialog suppression for de-jetified code. - Removed unusued dependency from UI module that causes large APK size increase. #exofixit #minor-release PiperOrigin-RevId: 344427532
tonihei committed -
- Retire YouTube streams. They're flaky (e.g., one of them has transformed into an audio only stream!). There is also a desire for us to stop relying on special non-expiring YouTube URLs. - Reorganize the remaining streams. PiperOrigin-RevId: 344421031
olly committed -
PiperOrigin-RevId: 344420436
olly committed -
Previously the PlaybackStatsListener needed to handle all events individually, which required to keep some state of the player and to resolve potentially transient state changes. Using onEvents allows to channel all simultanous updates through one method so that no transient player state and other inconsistencies need to be handled. This makes the logic easier to read. In addition it also allows to resolve all simultaneous events to use one EventTime (with one timestamp). #exofixit PiperOrigin-RevId: 344415459
tonihei committed -
#exofixit PiperOrigin-RevId: 344414313
samrobinson committed -
Instead of ffmpeg_jni for consistency with other extensions. PiperOrigin-RevId: 344411014
aquilescanta committed -
PiperOrigin-RevId: 344408351
olly committed -
PiperOrigin-RevId: 344384426
sungsoo committed -
PiperOrigin-RevId: 344310640
aquilescanta committed -
PiperOrigin-RevId: 344309747
aquilescanta committed -
Also make compilation automatically determine the number of threads to use during compilation. PiperOrigin-RevId: 344264761
aquilescanta committed -
#exofixit PiperOrigin-RevId: 344246408
olly committed -
PiperOrigin-RevId: 344243929
olly committed -
This is simpler than instantiating a single-element string array for every parameter. #exofixit PiperOrigin-RevId: 344237475
ibaker committed -
#exofixit PiperOrigin-RevId: 344232362
samrobinson committed -
Issue: #8239 #exofixit #minor-release PiperOrigin-RevId: 344211877
andrewlewis committed -
In many cases it doesn't matter for the test itself how many windows a timeline has, or even how the timeline of a MediaSource looks like. And since we introduced the MediaItem-based APIs, single-window Timelines are the only fully supported Timelines. Thus there is no point in specifiying this explicitly. Using these assumptions, we can remove some boilerplate when setting up standard FakeTimelines or FakeMediaSources with a standard FakeTimeline. #exofixit PiperOrigin-RevId: 344210395
tonihei committed -
#exofixit Issue: #5602 PiperOrigin-RevId: 344093622
olly committed -
The current code creates placeholder metadata elements if there is no static metadata. This causes onStaticMetadataChanged callbacks even if there is no metadata. Instead, we can keep the empty list as the static metadata is already documented to be an empty list if the metadata is unavailable. #exofixit PiperOrigin-RevId: 344071639
tonihei committed -
#exofixit PiperOrigin-RevId: 344065556
bachinger committed -
#exofixit PiperOrigin-RevId: 344065519
bachinger committed
-
- 24 Nov, 2020 5 commits
-
-
The ref'd issue was marked as a doucmentation candidate, but I think the confusion likely arises from the lack of "next" and "previous" in the method names. Our other UI components also support enabling each button individually, so this also brings notifications in line with those. Issue: #6491 #exofixit PiperOrigin-RevId: 344058969
olly committed -
PiperOrigin-RevId: 344057097
kim-vde committed -
* These grouping parentheses are unnecessary; it is unlikely the code will be misinterpreted without them (see http://go/bugpattern/UnnecessaryParentheses) (2 times) This CL looks good? Just LGTM and Approve it! This CL doesn’t look good? This is what you can do: * Suggest a fix on the CL (go/how-to-suggest-fix). * Revert this CL, by replying "REVERT: <provide reason>" * File a bug under go/error-prone-bug for category ErrorProneStyle if the change looks generally problematic. * Revert this CL and not get a CL that cleans up these paths in the future by replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to opt out the respective paths in your CL Robot configuration instead: go/clrobot-opt-out. This CL was generated by CL Robot - a tool that cleans up code findings (go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/java/com/google/android/libraries/exoplayer/METADATA which is reachable following include_presubmits from //depot/google3/third_party/java_src/android_libs/exoplayer/METADATA. Anything wrong with the signup? File a bug at go/clrobot-bug. #codehealth PiperOrigin-RevId: 344053269
olly committed -
#exofixit PiperOrigin-RevId: 344052500
kimvde committed -
#minor-release PiperOrigin-RevId: 344051610
christosts committed
-