- 22 Nov, 2018 9 commits
-
-
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222529260
olly committed -
We currently fail the entire playback tests if we exceed a start timeout or the test gets stopped forcefully. This is problematic as the start timeout may happen from time to time for the ABR tests and we'd still like to have the remaining playbacks. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222406639
tonihei committed -
The input.getLength() check is invalid because the length may be unknown (i.e. if the server doesn't include a Content-Length response header when serving chunks). Issue: #5063 (tangentially related only) ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222406347
olly committed -
This allows more efficient range removals and is consistent with addition, which supports adding multiple elements in a single operation. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222396310
aquilescanta committed -
Issue: #4883 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222392621
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222387374
olly committed -
This allows to account for bandwidth used by fixed track selections. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222383736
tonihei committed -
BandwidthProvider allows bandwidth allocation logic to be customized. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222293581
eguven committed -
1. Pull up all subclasses of DownloadAction into DownloadAction 2. Add DownloaderFactory for Downloader instantiation, and DefaultDownloaderFactory to replace the instantiation logic being removed from the DownloadAction subclasses. This change will upgrade existing action files gracefully (i.e. it does not lose compatibility with the existing offline implementation, other than some minor breaking changes to the API). TODOs: 1. Move test methods from the XDownloadActionTest classes into DownloadActionTest. This will be done in a subsequent CL. There's a lot of consolidation that can be done here, including de-duplicating some of the test code added in this CL. 2. Look at merging DownloaderConstructorHelper into DefaultDownloaderFactory. 3. Use customCacheKey in DASH/HLS/SS Downloaders, for completeness. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222258983
olly committed
-
- 20 Nov, 2018 11 commits
-
-
createTrackSelections decides whether to create an adaptive or a fixed track seletion to create. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222231011
eguven committed -
Forwarding the listeners to the notification update is meant to ensure we only notify the listeners which were registered at the time the event happened However, we currently just copy the reference to the actual list instead of doing a deep copy of the listeners. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222227735
tonihei committed -
This ensures that all callbacks use the same notification mechanism. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222226913
tonihei committed -
The update is actually unrelated and putting it all in one large update object complicates adding the same update mechanism for other values. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222226825
tonihei committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222221294
tonihei committed -
Since version 17.0 play-services-ads requires specifying AD_MANAGER_APP=true in AndroidManifest.xml, so add this in the IMA extension's manifest. See also https://developers.google.com/ad-manager/mobile-ads-sdk/android/quick-start. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222087771
andrewlewis committed -
WindowedTrackBitrateEstimator, uses future and past chunks in a window of time to estimate track bitrate values. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222065409
eguven committed -
Interpret single-item audio stream edit lists as audio padding specification. Use the information to strip out padding from decoded audio streams. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=221865861
mdoucleff committed -
Currently no path may be chosen if minBufferUs == maxBufferUs == bufferedDurationUs. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=221639199
tonihei committed -
This is needed because the allocator can't be reused for example. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=221638233
tonihei committed -
This matches the binarySearchFloor method overload. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=221617114
aquilescanta committed
-
- 14 Nov, 2018 18 commits
-
-
- Increase the search window size to fix TS seeking for problematic media we've had provided to us. - As per my comments on the issue, we should look at doing more here to better fix the problem. This will solve the worst of the immediate problem, however. - The memory usage is non-trivial, particularly with the increased search window size. I've made the allocations only live whilst determining duration and seeking to address this. I've done the same for PS just for consistency. Issue: #5097 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=221449988
olly committed -
The remaining work is to split Window.isDynamic so that it's possible to represent a window that wont be appended to, but may still be removed from. Issue: #4780 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=221439220
olly committed -
This allows client code to run nullability checks. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=221437215
aquilescanta committed -
This is a precursor for fixing the ref'd issue. These classes are well tested, so the tests passing should give you reasonable confidence I didn't break anything :). Issue: #5097 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=221435824
olly committed -
LegacyVideoTrackSelection is the previous implementation (unchanged). VideoTrackSelection is rewritten to extend AdaptiveTrackSelection. An experiment is added to allow use of the new VideoTrackSelection implementation. It's envisaged that this transition will be more or less a no-op change. The experiment flag is only in case of bugs during roll-out, and will be removed with LegacyVideoTrackSelection upon successful transition. VideoTrackSelection also implements discard-on-trick-play-exit, which was a TODO in the previous implementation. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=221153827
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=221078075
olly committed -
- This brings it in line with PlayerControlView. The play action is displayed instead, and pressing it seeks to the default position of the current window. - Do the same for MediaSessionConnector - Add support for PlaybackPreparer consistent with PlayerControlView Issue: #5072 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=221076008
olly committed -
Issue: #4915 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=221075615
aquilescanta committed -
The extension cannot be used without also using support-media-compat (e.g. to instantiate a MediaSessionCompat). So it may as well be an API dependency. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=221072128
olly committed -
This change also paves the way for splitting out functionality into a utility class. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=221070262
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=221065798
olly committed -
- Make MediaSessionConnector use a ControlDispatcher and add setControlDispatcher, setFastForwardIncrementMs and setRewindIncrementMs methods. This brings it in line with our other UI components, including PlayerControlView and PlayerNotificationManager. - Collapsed DefaultPlaybackController into MediaSessionConnector, since I'm not sure there's a legitimate alternative implementation (note ControlDispatcher does provide some equivalent functionality e.g. to modify calls being made on the player). - Pass the Player and ControlDispatcher to command receivers and custom actions, so they don't need their own references. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=220822082
olly committed -
- Simplify logic for dispatching to the rating callback - Simplify CommandReceiver by removing getCommands. Simply calling receivers is simpler, and more flexible because it doesn't force implementations to define a static set of things that they handle up front. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=220788423
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=220643861
eguven committed -
Issue: #4690 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=220640737
andrewlewis committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=220616166
bachinger committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=220592303
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=220529628
eguven committed
-
- 07 Nov, 2018 2 commits
-
-
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=220500268
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=220470213
olly committed
-
