1. 29 Oct, 2021 7 commits
  2. 27 Oct, 2021 7 commits
    • Allow missing full_range_flag in colr box with type=nclx · 39639f8d
      Test file produced with:
      $ MP4Box -add "sample.mp4#video:colr=nclc,1,1,1" -new sample_18byte_nclx_colr.mp4
      
      And then manually changing the `nclc` bytes to `nclx`.
      
      This produces an 18-byte `colr` box with type `nclx`. The bitstream of
      this file does not contain HDR content, so the file itself is invalid
      for playback with a real decoder, but adding the box is enough to test
      the extractor change in this commit.
      
      (aside: MP4Box will let you pass `nclx`, but it requires 4 parameters, i.e. it
      requires the full_range_flag to be set, resulting in a valid 19-byte colr box)
      
      #minor-release
      Issue: #9332
      PiperOrigin-RevId: 405842520
      ibaker committed
    • Migrate SegmentSpeedProviderTest off deprecated method. · 3bc0fae7
      PiperOrigin-RevId: 405841397
      samrobinson committed
    • Set assumedVideoMinimumCodecOperatingRate for all playbacks · 310f268a
      PiperOrigin-RevId: 405736227
      olly committed
    • Generalize findEsdsPosition to support other types · 383bad80
      - This CL does not introduce functional changes.
      - This change will allow searching for the clli box while
        parsing the mdcv box in order to construct the HDR
        static info contained in ColorInfo.
      
      #minor-release
      
      PiperOrigin-RevId: 405656499
      aquilescanta committed
    • Allow video MIME type to be set in TranscodingTransformer. · 8545a8b3
      Also check that the output video MIME type is supported with the given container MIME type in `TranscodingTransformer` and `TransformerBaseRenderer`.
      
      PiperOrigin-RevId: 405645362
      hschlueter committed
    • Replace ExtractorsFactory with MediaSourceFactory in ExoPlayer.Builder · 98200c26
      This has a few benefits:
        * Aligns the Builder constructors with the setters
          (setRenderersFactory is missing, but can be easily added in a
          follow-up change).
        * Allows DefaultMediaSourceFactory to be stripped by R8 and
          makes the shrinking dev guide for the cases of providing a custom
          MediaSourceFactory or directly instantiating MediaSource instances
          less weird too.
      
      #minor-release
      
      PiperOrigin-RevId: 405632981
      ibaker committed
    • Deduce encoder video format from decoder format. · 649fe702
      When no encoder video MIME type is specified, the `TransformerTranscodingVideoRenderer` now uses the video MIME type of the input for the encoder format.
      The input format is now read in a new method `ensureInputFormatRead` which is called before the other configuration methods. This removes the logic for reading the input format from `ensureDecoderConfigured`, because it is now needed for both encoder and decoder configuration but the encoder needs to be configured before GL and GL needs to be configured before the decoder, so the decoder can't read the format.
      The width and height are now inferred from the input and the frame rate and bit rate are still hard-coded but set by the `MediaCodecAdapterWrapper` instead of `TranscodingTransformer`.
      
      PiperOrigin-RevId: 405631263
      hschlueter committed
  3. 26 Oct, 2021 7 commits
  4. 25 Oct, 2021 14 commits
    • Move NAL unit utils to extractor module · 23b46d2e
      PiperOrigin-RevId: 405473686
      olly committed
    • Remove dependency from opus module to extractor module · 101b94f8
      PiperOrigin-RevId: 405429757
      olly committed
    • Fix TrackSelectionOverrides imports · 2ab7f28e
      PiperOrigin-RevId: 405408606
      olly committed
    • Update import scrubbing · 922e5082
      PiperOrigin-RevId: 405396600
      andrewlewis committed
    • Update package name · 4a8f2fc7
      PiperOrigin-RevId: 405394994
      andrewlewis committed
    • Remove jcenter() dependency · 647d69b9
      PiperOrigin-RevId: 405391455
      olly committed
    • Change MediaMetadata update priority to favour MediaItem values. · cd6c2e98
      The static and dynamic metadata now build up in a list, such that when
      the MediaMetadata is built, they are applied in an event order. This
      means that newer/fresher values will overwrite older ones. The MediaItem
      values are then applied at the end, as they take priority over any other.
      
      #minor-release
      
      PiperOrigin-RevId: 405383177
      samrobinson committed
    • Register newly split modules · 2b97455a
      PiperOrigin-RevId: 405379511
      olly committed
    • Rm stray blank line · 988a55db
      PiperOrigin-RevId: 405377964
      olly committed
    • Upgrade RTMP dependency and remove jcenter() · 2dc7ac38
      PiperOrigin-RevId: 405375352
      olly committed
    • Allow output audio MIME type to be set in TranscodingTransformer. · a42d9f36
      This introduces a new option `setAudioMimeType` in `TranscodingTransformer.Builder` and a corresponding check whether the selected type is supported. This check is done using `supportsSampleMimeType` which is now part of the `Muxer.Factory` and `MuxerWrapper` rather than `Muxer`.
      A new field `audioMimeType` is added to `Transformation` and the `TransformerAudioRenderer` uses this instead of the input MIME type if requested.
      
      PiperOrigin-RevId: 405367817
      olly committed
    • Transformer: avoid retrieving the video decoded bytes · 17d2f5a0
      Decoded video frames can be large and there is no need to retrieve the
      corresponding ByteBuffer as we render the decoded frames on a surface
      for better performance.
      
      PiperOrigin-RevId: 405364950
      kimvde committed
    • Encapsulate TrackSelectionOverrides in its own class · 1f3f22a7
      The current API exposes an `ImmutableMap` of
      `TrackGroup` -> `TrackSelectionOverride`.
      This has several disadvantages:
       - A difficult to use API for mutation
         (`ImmutableMap.Builder` doesn't support key removal).
       - There is no track selection specific methods,
         how the generic map API mapps to the selection override is not complex
         but to obvious for a casual reader.
       - The internal data type is exposed, making internal refactor difficult.
      
      This was done to have the API ready as quick as possible.
      
      When transitioning the clients to the map API in <unknown commit>,
      it became clear that the map API was too verbose and not mapping
      to the clients needs, so utility methods
      were added to make operations clearer and more concise.
      
      Nevertheless, having to use utility method to use easily and correctly
      an API is not the sign of a good API.
      
      This cl refactors the track selection API for several improvements:
      
       - Add a type `TrackSelectionParameters` that encapsulate the internal
         data structure (map currently).
       - For iteration, expose as a list.
       - Add a `Builder` for easy mutable operations.
       - Add track selection specific methods to avoid having utilities functions.
       - Those operations are the same as `DefaultTrackSelector.Parameters`
         for easier migration. (`setOverride` was renamed to `addOverride`)
       - Move `TrackSelection` classes outside of `TrackSelectionParameters`
         as their own top level classes.
      
      The migration of the client code is straightforward as most of it
      were already using the previously mentioned utility functions
      that are now native methods.
      
      The full migration has not been done yet, and is pending on this cl approval.
      
      PiperOrigin-RevId: 405362719
      krocard committed
    • Add datasource module · 2ee72076
      PiperOrigin-RevId: 404897119
      olly committed
  5. 21 Oct, 2021 5 commits
    • Get decoder buffers into the right place · 37b58476
      PiperOrigin-RevId: 404876228
      olly committed
    • Restructure core_settings · 5e26ba82
      PiperOrigin-RevId: 404851976
      olly committed
    • Add decoder module · ce17f618
      PiperOrigin-RevId: 404810682
      olly committed
    • Fix 2 ErrorProneStyle findings: · bffe2f7b
      * @Reason is not a TYPE_USE annotation, so should appear before any modifiers and after Javadocs.
        (see go/java-style#s4.8.5-annotations)
      * Curly braces should be used for inline Javadoc tags: {@code ...}
        (see http://go/bugpattern/InvalidInlineTag)
      
      This CL looks good? Just LGTM and Approve it!
      This CL doesn’t look good? This is what you can do:
      * Revert this CL, by replying "REVERT: <provide reason>"
      * File a bug under go/error-prone-bug for category ErrorProneStyle if the change looks generally problematic.
      * Revert this CL and not get a CL that cleans up these paths in the future by
      replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to
      opt out the respective paths in your CL Robot configuration instead:
      go/clrobot-opt-out.
      
      This CL was generated by CL Robot - a tool that cleans up code findings
      (go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/java/com/google/android/libraries/media/METADATA which is reachable following include_presubmits from //depot/google3/third_party/java_src/android_libs/media/METADATA.
      Anything wrong with the signup? File a bug at go/clrobot-bug.
      
      #codehealth
      
      PiperOrigin-RevId: 404769260
      olly committed
    • DefaultMediaSourceFactory: Lazily load media source factories · bbe2cef7
      Th purpose of this change is to speed up the instantiation of the
      DefaultMediaSourceFactory.
      
      PiperOrigin-RevId: 404665352
      christosts committed