- 29 Oct, 2021 7 commits
-
-
Relanding http://https://github.com/google/ExoPlayer/commit/9788750ddb23b2064dddf99d6e1ea491b2e45cea, with some changes applied to improve primarily readability, naming, and nullness checks. PiperOrigin-RevId: 406101742
huangdarwin committed -
Only deprecated references remain. Usages of the deprecated methods will be migrated in a follow-up change. #minor-release PiperOrigin-RevId: 405927141
ibaker committed -
Also add a setRenderersFactory() method, so that all constructor-provided components can also be passed via setters. This comment already appears on the constructor that takes all components, but it applies to these ones as well. PiperOrigin-RevId: 405917343
ibaker committed -
`checkNotNull` should be avoided where possible. This change adds `@EnsuresNonNull` or `@EnsuresNonNullIf` to configuration methods for fields they initialize. `checkNotNull` is now avoided for the `@MonotonicNonNull` formats by adding `@RequiresNonNull` annotations. `checkNotNull` is now avoided for the encoder and decoder in `feedMuxerFromEncoder()`, `feedEncoderFromDecoder()`, `feedDecoderFromInput()`, etc. by creating local variables for `encoder` and `decoder` in `render` after the configuration method calls and passing these as non-null parameters. PiperOrigin-RevId: 405893824
hschlueter committed -
No other index-related methods in Player are annotated, it's considered obvious that these should be >=0. PiperOrigin-RevId: 405882756
ibaker committed -
Should have been part of https://github.com/google/ExoPlayer/commit/98200c2692ba007ba0b177d7b285b957dc08ff93 #minor-release PiperOrigin-RevId: 405880982
ibaker committed -
Our package-info.java files are annotated with @NonNullApi which results in everything being non-null by default, so this annotation is never needed. #minor-release PiperOrigin-RevId: 405864737
ibaker committed
-
- 27 Oct, 2021 7 commits
-
-
Test file produced with: $ MP4Box -add "sample.mp4#video:colr=nclc,1,1,1" -new sample_18byte_nclx_colr.mp4 And then manually changing the `nclc` bytes to `nclx`. This produces an 18-byte `colr` box with type `nclx`. The bitstream of this file does not contain HDR content, so the file itself is invalid for playback with a real decoder, but adding the box is enough to test the extractor change in this commit. (aside: MP4Box will let you pass `nclx`, but it requires 4 parameters, i.e. it requires the full_range_flag to be set, resulting in a valid 19-byte colr box) #minor-release Issue: #9332 PiperOrigin-RevId: 405842520
ibaker committed -
PiperOrigin-RevId: 405841397
samrobinson committed -
PiperOrigin-RevId: 405736227
olly committed -
- This CL does not introduce functional changes. - This change will allow searching for the clli box while parsing the mdcv box in order to construct the HDR static info contained in ColorInfo. #minor-release PiperOrigin-RevId: 405656499
aquilescanta committed -
Also check that the output video MIME type is supported with the given container MIME type in `TranscodingTransformer` and `TransformerBaseRenderer`. PiperOrigin-RevId: 405645362
hschlueter committed -
This has a few benefits: * Aligns the Builder constructors with the setters (setRenderersFactory is missing, but can be easily added in a follow-up change). * Allows DefaultMediaSourceFactory to be stripped by R8 and makes the shrinking dev guide for the cases of providing a custom MediaSourceFactory or directly instantiating MediaSource instances less weird too. #minor-release PiperOrigin-RevId: 405632981ibaker committed -
When no encoder video MIME type is specified, the `TransformerTranscodingVideoRenderer` now uses the video MIME type of the input for the encoder format. The input format is now read in a new method `ensureInputFormatRead` which is called before the other configuration methods. This removes the logic for reading the input format from `ensureDecoderConfigured`, because it is now needed for both encoder and decoder configuration but the encoder needs to be configured before GL and GL needs to be configured before the decoder, so the decoder can't read the format. The width and height are now inferred from the input and the frame rate and bit rate are still hard-coded but set by the `MediaCodecAdapterWrapper` instead of `TranscodingTransformer`. PiperOrigin-RevId: 405631263
hschlueter committed
-
- 26 Oct, 2021 7 commits
-
-
PiperOrigin-RevId: 405626270
samrobinson committed -
PiperOrigin-RevId: 405626096
olly committed -
PiperOrigin-RevId: 405624136
andrewlewis committed -
PiperOrigin-RevId: 405616711
samrobinson committed -
PiperOrigin-RevId: 405598530
andrewlewis committed -
PiperOrigin-RevId: 405592960
andrewlewis committed -
This has been done for (almost) all span types. PiperOrigin-RevId: 405588294
andrewlewis committed
-
- 25 Oct, 2021 14 commits
-
-
PiperOrigin-RevId: 405473686
olly committed -
PiperOrigin-RevId: 405429757
olly committed -
PiperOrigin-RevId: 405408606
olly committed -
PiperOrigin-RevId: 405396600
andrewlewis committed -
PiperOrigin-RevId: 405394994
andrewlewis committed -
PiperOrigin-RevId: 405391455
olly committed -
The static and dynamic metadata now build up in a list, such that when the MediaMetadata is built, they are applied in an event order. This means that newer/fresher values will overwrite older ones. The MediaItem values are then applied at the end, as they take priority over any other. #minor-release PiperOrigin-RevId: 405383177
samrobinson committed -
PiperOrigin-RevId: 405379511
olly committed -
PiperOrigin-RevId: 405377964
olly committed -
PiperOrigin-RevId: 405375352
olly committed -
This introduces a new option `setAudioMimeType` in `TranscodingTransformer.Builder` and a corresponding check whether the selected type is supported. This check is done using `supportsSampleMimeType` which is now part of the `Muxer.Factory` and `MuxerWrapper` rather than `Muxer`. A new field `audioMimeType` is added to `Transformation` and the `TransformerAudioRenderer` uses this instead of the input MIME type if requested. PiperOrigin-RevId: 405367817
olly committed -
Decoded video frames can be large and there is no need to retrieve the corresponding ByteBuffer as we render the decoded frames on a surface for better performance. PiperOrigin-RevId: 405364950
kimvde committed -
The current API exposes an `ImmutableMap` of `TrackGroup` -> `TrackSelectionOverride`. This has several disadvantages: - A difficult to use API for mutation (`ImmutableMap.Builder` doesn't support key removal). - There is no track selection specific methods, how the generic map API mapps to the selection override is not complex but to obvious for a casual reader. - The internal data type is exposed, making internal refactor difficult. This was done to have the API ready as quick as possible. When transitioning the clients to the map API in <unknown commit>, it became clear that the map API was too verbose and not mapping to the clients needs, so utility methods were added to make operations clearer and more concise. Nevertheless, having to use utility method to use easily and correctly an API is not the sign of a good API. This cl refactors the track selection API for several improvements: - Add a type `TrackSelectionParameters` that encapsulate the internal data structure (map currently). - For iteration, expose as a list. - Add a `Builder` for easy mutable operations. - Add track selection specific methods to avoid having utilities functions. - Those operations are the same as `DefaultTrackSelector.Parameters` for easier migration. (`setOverride` was renamed to `addOverride`) - Move `TrackSelection` classes outside of `TrackSelectionParameters` as their own top level classes. The migration of the client code is straightforward as most of it were already using the previously mentioned utility functions that are now native methods. The full migration has not been done yet, and is pending on this cl approval. PiperOrigin-RevId: 405362719
krocard committed -
PiperOrigin-RevId: 404897119
olly committed
-
- 21 Oct, 2021 5 commits
-
-
PiperOrigin-RevId: 404876228
olly committed -
PiperOrigin-RevId: 404851976
olly committed -
PiperOrigin-RevId: 404810682
olly committed -
* @Reason is not a TYPE_USE annotation, so should appear before any modifiers and after Javadocs. (see go/java-style#s4.8.5-annotations) * Curly braces should be used for inline Javadoc tags: {@code ...} (see http://go/bugpattern/InvalidInlineTag) This CL looks good? Just LGTM and Approve it! This CL doesn’t look good? This is what you can do: * Revert this CL, by replying "REVERT: <provide reason>" * File a bug under go/error-prone-bug for category ErrorProneStyle if the change looks generally problematic. * Revert this CL and not get a CL that cleans up these paths in the future by replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to opt out the respective paths in your CL Robot configuration instead: go/clrobot-opt-out. This CL was generated by CL Robot - a tool that cleans up code findings (go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/java/com/google/android/libraries/media/METADATA which is reachable following include_presubmits from //depot/google3/third_party/java_src/android_libs/media/METADATA. Anything wrong with the signup? File a bug at go/clrobot-bug. #codehealth PiperOrigin-RevId: 404769260olly committed -
Th purpose of this change is to speed up the instantiation of the DefaultMediaSourceFactory. PiperOrigin-RevId: 404665352
christosts committed
-