1. 09 Apr, 2021 5 commits
    • Convergence: Continue decoupling UI from Core · d853379b
      Move CaptionStyleCompat to the UI module, where it's used
      
      PiperOrigin-RevId: 367223891
      olly committed
    • Remove unnecessary @Nullable in exception message · 2434d4e6
      PiperOrigin-RevId: 367204382
      jaewan committed
    • Add Period.isPlaceholder to fix preparation issues for concatenation. · c455bad8
      We added a source that allows mixed placeholder and non-placeholder
      periods, but have no way to denote that in the Timeline because the
      placeholder flag only exists on Window level. This causes a bug if
      the first item in a concatenation has a window-period offset and the
      player can't detect whether it's still a placeholder or not.
      
      Adding this flag to Period allows the player to detect this reliably.
      In addition we need to make sure that re-resolving pending positions
      only happens for the first placeholder period where the window-offset
      can actually change. As all subsequent periods have to start at position
      0, so they don't need to be re-resolved (and shouldn't).
      
      PiperOrigin-RevId: 367171518
      tonihei committed
    • Fix 1 ErrorProneStyle finding: · ce4c655c
      * @Nullable is not a TYPE_USE annotation, so should appear before any modifiers and after Javadocs.
        (see go/java-style#s4.8.5-annotations)
      
      This CL looks good? Just LGTM and Approve it!
      This CL doesn’t look good? This is what you can do:
      * Suggest a fix on the CL (go/how-to-suggest-fix).
      * Revert this CL, by replying "REVERT: <provide reason>"
      * File a bug under go/error-prone-bug for category ErrorProneStyle if the change looks generally problematic.
      * Revert this CL and not get a CL that cleans up these paths in the future by
      replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to
      opt out the respective paths in your CL Robot configuration instead:
      go/clrobot-opt-out.
      
      This CL was generated by CL Robot - a tool that cleans up code findings
      (go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/java/com/google/android/libraries/exoplayer/METADATA which is reachable following include_presubmits from //depot/google3/third_party/java_src/android_libs/exoplayer/METADATA.
      Anything wrong with the signup? File a bug at go/clrobot-bug.
      
      #codehealth
      
      PiperOrigin-RevId: 367053059
      olly committed
    • Call new onPositionDiscontinuity callback in CastPlayer · 4c33c511
      PiperOrigin-RevId: 367020270
      bachinger committed
  2. 06 Apr, 2021 8 commits
  3. 01 Apr, 2021 27 commits