- 13 Jul, 2021 6 commits
-
-
This is more descriptive. PiperOrigin-RevId: 383887927
kimvde committed -
This is consistent with seek back and forward commands. PiperOrigin-RevId: 383867710
kimvde committed -
This is more consistent with other Player methods like previous and next. PiperOrigin-RevId: 383832298
kimvde committed -
PiperOrigin-RevId: 383816880
kimvde committed -
This is more correct and is consistent with the Javadoc. PiperOrigin-RevId: 383808096
kimvde committed -
PiperOrigin-RevId: 383806284
ibaker committed
-
- 09 Jul, 2021 34 commits
-
-
The parameters staying in DefaultTrackSelector are considered too ExoPlayer specific to be part of the `Player` interface. Those are: - exceedVideoConstraintsIfNecessary; - allowVideoMixedMimeTypeAdaptiveness; - allowVideoNonSeamlessAdaptiveness; - exceedAudioConstraintsIfNecessary; - allowAudioMixedMimeTypeAdaptiveness; - allowAudioMixedSampleRateAdaptiveness; - allowAudioMixedChannelCountAdaptiveness; - disabledTextTrackSelectionFlags; - exceedRendererCapabilitiesIfNecessary; - tunnelingEnabled; - allowMultipleAdaptiveSelections; - rendererDisabledFlags Track selection override will be migrated in a follow up cl. To avoid breaking backward compatibility, `DefaultTrackSelector.Parameters` extends `TrackSelectionParameters` and `DefaultTrackSelector.ParametersBuilder` extends `TrackSelectionParameters.Builder`. The change are thus transparent for clients. Test are incomplete for now, as this is a relatively big cl, I though the reviewer could give a first pass will the tests are completed. PiperOrigin-RevId: 383767021
krocard committed -
#minor-release Issue:#9158 PiperOrigin-RevId: 383660258
kimvde committed -
IntDef names (like enums) are normally singular, and this isn't a 'flag' IntDef. PiperOrigin-RevId: 383659574
ibaker committed -
PiperOrigin-RevId: 383656919
kimvde committed -
PiperOrigin-RevId: 383623440
kimvde committed -
PiperOrigin-RevId: 383448851
samrobinson committed -
It is used to implement `Bundleable` for `TrackSelection`. PiperOrigin-RevId: 383408386
krocard committed -
PiperOrigin-RevId: 383408075
aquilescanta committed -
In order to avoid doing the classification in ExoPlayerImplInternal. Note: This only makes the constructor change. The error code assignment will happen in an immediately following CL. PiperOrigin-RevId: 383397729
aquilescanta committed -
PiperOrigin-RevId: 383390096
bachinger committed -
This simplifies the API surface and the MediaController implementation. PiperOrigin-RevId: 383385436
kimvde committed -
PiperOrigin-RevId: 383382813
aquilescanta committed -
PiperOrigin-RevId: 383379334
aquilescanta committed -
As of 3.4.0 jdk8 annotation are integrated in checker. https://github.com/typetools/checker-framework/releases/tag/checker-framework-3.4.0 3.5 is the last version available internally. PiperOrigin-RevId: 383377733
krocard committed -
PiperOrigin-RevId: 383268454
samrobinson committed -
PiperOrigin-RevId: 383255572
ibaker committed -
PiperOrigin-RevId: 383251000
aquilescanta committed -
PiperOrigin-RevId: 383245932
bachinger committed -
This matches the Javadoc better. PiperOrigin-RevId: 383228021
kimvde committed -
* @ImaAdState is not a TYPE_USE annotation, so should appear before any modifiers and after Javadocs. (see go/java-style#s4.8.5-annotations) This CL looks good? Just LGTM and Approve it! This CL doesn’t look good? This is what you can do: * Suggest a fix on the CL (go/how-to-suggest-fix). * Revert this CL, by replying "REVERT: <provide reason>" * File a bug under go/error-prone-bug for category ErrorProneStyle if the change looks generally problematic. * Revert this CL and not get a CL that cleans up these paths in the future by replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to opt out the respective paths in your CL Robot configuration instead: go/clrobot-opt-out. This CL was generated by CL Robot - a tool that cleans up code findings (go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/java/com/google/android/libraries/media/METADATA which is reachable following include_presubmits from //depot/google3/third_party/java_src/android_libs/media/METADATA. Anything wrong with the signup? File a bug at go/clrobot-bug. #codehealth PiperOrigin-RevId: 383121587
olly committed -
And assign error codes to all callers. PiperOrigin-RevId: 383118513
aquilescanta committed -
This isn't needed now we've updated to Robolectric 4.6 PiperOrigin-RevId: 383109343
ibaker committed -
The bug fix seems potentially serious and worth having: https://github.com/robolectric/robolectric/releases/tag/robolectric-4.6.1 PiperOrigin-RevId: 383096745
ibaker committed -
PiperOrigin-RevId: 382766969
aquilescanta committed -
If a test expects an error they can use runUntilError() PiperOrigin-RevId: 382765060
ibaker committed -
Issue: #9005 PiperOrigin-RevId: 382765045
ibaker committed -
MediaItem.mediaId used to default to the content URI, but this changed: https://github.com/google/ExoPlayer/commit/cc26a92e070db8963738beed423bb4699762877f Before the mediaId change linked above, a playlist of different content all with the same ad URI would play the ads for every item. After the change the ad would only play once (because mediaId == "" for every item, so they're all the same). This change restores roughly the original behaviour by always considering both mediaId and the content URI. #minor-release Issue: #9106 PiperOrigin-RevId: 382763618
ibaker committed -
#minor-release PiperOrigin-RevId: 382763308
ibaker committed -
The serialization scheme used here is custom, it doesn't need to be compatible with emsg-v0 or emsg-v1 (since https://github.com/google/ExoPlayer/commit/97183ef55866170807910cd626264d82d41d46d4). This means that C.TIME_UNSET will propagate correctly through the serialization. #minor-release Issue: #9123 PiperOrigin-RevId: 382762873
ibaker committed -
The tests now pass without @DoNotInstrument I had to tweak the jetification settings due to a bug in the jetifier shipped with the Android Gradle Plugin. More details: https://github.com/robolectric/robolectric/issues/6521#issuecomment-851736355 PiperOrigin-RevId: 382757006
ibaker committed -
This is an abstract class so it can only be constructed from the context of a subclass anyway. PiperOrigin-RevId: 382756293
ibaker committed -
Without this annotation it seems that `SimpleExoPlayer` effectively 'un-deprecates' the method, specifically: * A usage of these methods isn't flagged by Android Studio if the declared type is `SimpleExoPlayer` (up-casting to e.g. `ExoPlayer.VideoComponent` results in the warning showing up). * The `SimpleExoPlayer` javadoc doesn't mention this method is deprecated: https://exoplayer.dev/doc/reference/com/google/android/exoplayer2/SimpleExoPlayer.html#addVideoListener(com.google.android.exoplayer2.video.VideoListener) * The Metalava API output for `SimpleExoPlayer` doesn't show these methods as deprecated. PiperOrigin-RevId: 382756174
ibaker committed -
PiperOrigin-RevId: 382710409
claincly committed -
- Use `PlaybackException.ErrorCode` IntDef for `DataSourceException` error code - Deprecate `DataSourceException.POSITION_OUT_OF_RANGE` - All other changes are related to replacing the deprecated constant and constructor PiperOrigin-RevId: 382683522
claincly committed
-