Commits · d01d0cfd4b20cfa3bf7776cda397db5ebf7dcfa3 · SDK / exoplayer

27 Apr, 2020 28 commits

Define a interface type for Aac object type. · d01d0cfd
```
PiperOrigin-RevId: 308115863
```
krocard committed Apr 27, 2020
d01d0cfd

Make sure not to create new playback sessions while still IDLE. · e250fe62

The first session should only be created once we have the media items
and/or called prepare. Otherwise the first session is created with
an EventTime having an empty timeline making it less useful.

issue:#7193
PiperOrigin-RevId: 308100555

committed Apr 27, 2020

e250fe62 Browse Files

Make download progress updates thread safe · 63db847b
```
Issue: #5978
PiperOrigin-RevId: 308076851
```
olly committed Apr 27, 2020
63db847b Browse Files
Move LoadEventInfo creation to the caller · 25f17acd
```
LoadEventInfo needs to also be sent to the LoadErrorHandlingPolicy.

PiperOrigin-RevId: 308066998
```
aquilescanta committed Apr 27, 2020
25f17acd Browse Files

Reshuffle the way listeners are attached to MediaSources · a0423461

This better supports custom listener types defined by MediaSource
subclasses.

Part of issue:#6765

PiperOrigin-RevId: 308050575

committed Apr 27, 2020

a0423461 Browse Files

SegmentDownloader cleanup · 84faa1ae

This is just some trivial cleanup to get things into a better state to
implement parallel segment downloads.

Issue: #5978
PiperOrigin-RevId: 308041996

committed Apr 27, 2020

84faa1ae Browse Files

Fix AdsMediaSource parameter when reporting load error · 17fff2d0
```
PiperOrigin-RevId: 308041841
```
aquilescanta committed Apr 27, 2020
17fff2d0 Browse Files
Remove deprecated LoadControl method · c452d6df
```
PiperOrigin-RevId: 308031992
```
olly committed Apr 27, 2020
c452d6df Browse Files

Add missing nullable annotations · 1699ab0d

The MediaSessionConnector gets a Bundle passed to the MediaSession.Callback
from the framework which can be null. This needs to be properly annotated
with @Nullable.

Issue: #7234
PiperOrigin-RevId: 307822764

committed Apr 27, 2020

1699ab0d

Plumb an ExecutorService into Downloader implementations · cd828e5c
```
Issue: #5978
PiperOrigin-RevId: 307819608
```
olly committed Apr 27, 2020
cd828e5c Browse Files

Improve Format propagation within the MediaCodecRenderer. · 37f0ff92

Handles pixel aspect ratio changes in playlists where video
resolution does not change.

Issue:#6646
PiperOrigin-RevId: 307817028

committed Apr 27, 2020

37f0ff92 Browse Files

Add test for TS with h264 and DTS audio · 5d3230d8
```
PiperOrigin-RevId: 307789384
```
aquilescanta committed Apr 27, 2020
5d3230d8
Split {Amr,Ogg}ExtractorTest into parameterized & non-parameterized · 11c24ac3
```
This avoids the non-parameterized tests being run repeatedly for every
combination of parameters.

PiperOrigin-RevId: 307785770
```
ibaker committed Apr 27, 2020
11c24ac3 Browse Files

Use parameterization in most extractor tests · cfa8e19f

Part of what makes these tests hard to deal with (imo) is being
unable to easily run a specific config, or seeing exactly which one
failed (because you always see only the first failure).

I put the parameters as a method on ExtractorAsserts to
reduce the boiler-plate required in each test class.

I'll migrate the extension FlacExtractorTest in a follow-up CL

PiperOrigin-RevId: 307785380

committed Apr 27, 2020

cfa8e19f Browse Files

Add test for TsExtractor's FLAG_DETECT_ACCESS_UNITS · 1b6a32f2
```
PiperOrigin-RevId: 307777265
```
aquilescanta committed Apr 27, 2020
1b6a32f2 Browse Files
Make some TtmlDecoder methods static. · 29392d26
```
PiperOrigin-RevId: 307776363
```
tonihei committed Apr 27, 2020
29392d26 Browse Files
Change some annotations placement Checkerframework now warns about. · 1031dae1
```
PiperOrigin-RevId: 307764457
```
tonihei committed Apr 27, 2020
1031dae1 Browse Files
Remove usages of deprecated CacheDataSourceFactory · 6f2891e5
```
PiperOrigin-RevId: 307684243
```
olly committed Apr 27, 2020
6f2891e5 Browse Files

Remove DownloadConstructorHelper · 4abaaf13

Something that helps a constructor always seemed a bit strange.
It's now possible to use CacheDataSource.Factory directly instead.

PiperOrigin-RevId: 307661930

committed Apr 27, 2020

4abaaf13

Move PriorityTaskManager inside CacheDataSource · 722a5b22

In the same way it made sense to tie CacheKeyFactory and CacheDataSource
together in
https://github.com/google/ExoPlayer/commit/7ea83d7167d0b021fb280fca2b5dfa4a5616b5c1,
it makes sense to tie the PriorityTaskManager to the CacheDataSource as
well. This prevents error prone scenarios where one can end up being
passed around without (or with the wrong instance of) the other.

This change also internalizes use of PriorityDataSource directly into
CacheDataSource, rather than requiring the caller to chain things
themselves.

PiperOrigin-RevId: 307647290

committed Apr 27, 2020

722a5b22 Browse Files

Sanitize CacheDataSource/CacheDataSink factories · fab80874
```
PiperOrigin-RevId: 307636959
```
olly committed Apr 27, 2020
fab80874 Browse Files

Fix timestamp rounding error in fMP4 extractor. · 96ccb893

The sample timestamps are currently rounded to milliseconds, only to
be multiplied by 1000 later. This causes rounding errors where the sample
timestamps don't match the timestamps in the seek table (which are already
in microseconds).

issue:#7086
PiperOrigin-RevId: 307630559

committed Apr 27, 2020

96ccb893

Separate encryption data into a new TrackOutput method · 7839955f
```
Allows media parser to populate crypto data.

PiperOrigin-RevId: 307616083
```
aquilescanta committed Apr 27, 2020
7839955f Browse Files
Fix nullness checker warnings · 1ab5923f
```
PiperOrigin-RevId: 307570994
```
olly committed Apr 27, 2020
1ab5923f Browse Files
Prevent StreamVolumeManager from being released twice · 118f0b39
```
PiperOrigin-RevId: 307534335
```
gyumin committed Apr 27, 2020
118f0b39 Browse Files
Read media items from intent · 628234fd
```
PiperOrigin-RevId: 307442976
```
bachinger committed Apr 27, 2020
628234fd Browse Files
Use anti-aliasing and bitmap filtering for bitmap subtitles · 6a36574a
```
issue:#6950
PiperOrigin-RevId: 307411067
```
ibaker committed Apr 27, 2020
6a36574a Browse Files
Add key set id to MediaItem · 8d0d31e1
```
PiperOrigin-RevId: 307390673
```
bachinger committed Apr 27, 2020
8d0d31e1

20 Apr, 2020 12 commits

Fix H265Reader to correctly output SEI and AUD NAL units · cb51a1bf
```
Issue: #7113
PiperOrigin-RevId: 307380133
```
olly committed Apr 20, 2020
cb51a1bf

Noop naming generalization for H265Reader · 9a729000

This change generalizes the concept of "reading parameter sets" to
"reading prefix NAL units", ahead of a change that will treat AUD
and suffix SEI NAL units in the same way.

The change also introduces some static isXxxNalUnit methods for
clarity.

Issue: #7113
PiperOrigin-RevId: 307376967

committed Apr 20, 2020

9a729000 Browse Files

Update WebVttCueParser to parse position alignment values · eb8c174b

Currently we assume these are "start", "center", "middle" or "end",
which was correct in a previous draft of the spec:
https://www.w3.org/TR/2014/WD-webvtt1-20141111/#dfn-webvtt-text-position-cue-setting

The released spec uses "line-left", "center" and "line-right":
https://www.w3.org/TR/webvtt1/#webvtt-position-cue-setting

PiperOrigin-RevId: 307371066

committed Apr 20, 2020

eb8c174b

Merge pull request #7247 from vadimdolgachev:subtitle_track_name_for_matroska · ad3fb3d0
```
PiperOrigin-RevId: 307368176
```
Oliver Woodman committed Apr 20, 2020
ad3fb3d0
Fix AdsMediaSource child sources not being released · ccdd1a43
```
Also add unit tests for AdsMediaSource.

PiperOrigin-RevId: 307365492
```
andrewlewis committed Apr 20, 2020
ccdd1a43 Browse Files

Fix gapless playback · 02af670a

Audio processors are now flushed twice after reconfiguration.
The second flush call cleared the pending trim start bytes so
transitions between tracks were no longer gapless.

Fix this by removing logic to clear pending trim bytes on flush.
As a result we may trim data incorrectly if there is a flush
before any data has been handled for seeking to a non-zero
position, but this edge case will happen rarely and the effect
shouldn't be noticeable.

PiperOrigin-RevId: 307344357

committed Apr 20, 2020

02af670a Browse Files

Merge trick play tracks into main track groups · fea43767
```
Issue: #6054
PiperOrigin-RevId: 307285068
```
olly committed Apr 20, 2020
fea43767 Browse Files

Support ad tag with default media source · 8ea33e23

This is the missing attribute to support all features of the Sample with MediaItem. Hence PlayerActivity can use the setMediaItems() method directly without creating actual media sources in the app code.

PiperOrigin-RevId: 307102036

committed Apr 20, 2020

8ea33e23 Browse Files

Improve the error message when an extractor dump file is not found · 9937744f
```
PiperOrigin-RevId: 307078446
```
ibaker committed Apr 20, 2020
9937744f Browse Files
Better tie injection of Cache/CacheDataSource/CacheKeyFactory · 7ea83d71
```
PiperOrigin-RevId: 307056661
```
olly committed Apr 20, 2020
7ea83d71 Browse Files
Merge pull request #7210 from nebyan:CacheKeyFactoryNotUsed · 704993ce
```
PiperOrigin-RevId: 307045655
```
Oliver Woodman committed Apr 20, 2020
704993ce Browse Files

Use higher level interface for method parameters where possible. · 7350981e

This makes it easier to use the helper methods because the player doesn't
have to be assigned to a SimpleExoPlayer in all cases.

PiperOrigin-RevId: 307039126

committed Apr 20, 2020

7350981e Browse Files