- 14 Feb, 2023 4 commits
- 13 Feb, 2023 11 commits
-
-
It can be confusing how to use RgbMatrix for app devs not comfortable with image manipulation, so add a helper class that simply translates rgb values the same constant brightness value, to update the brightness values. PiperOrigin-RevId: 509287229
huangdarwin committed -
#minor-release PiperOrigin-RevId: 509246479
christosts committed -
For all end-to-end tests, we currently run on a generic API 26 and newer API 31 emulator. Due to some issues on API 31, update to use an API 33 emulator. Also, update documentation to mention issues on different emulator versions. PiperOrigin-RevId: 509242743
huangdarwin committed -
This now matches EncoderUtil.getSupportedEncoders return type. PiperOrigin-RevId: 509222078
samrobinson committed -
PiperOrigin-RevId: 509210836
andrewlewis committed -
In parsing Describe RTSP response messages, IllegalArgumentExceptions are thrown for invalid parameters and values. These exceptions were not caught and crashed the Playback thread. Now these exceptions will be caught and their errors forwarded to the proper error handling listeners. #minor-release Issue: google/ExoPlayer#10971 PiperOrigin-RevId: 509207881
michaelkatz committed -
FileUtil is only ever used in mh, and never in mh.analysis PiperOrigin-RevId: 509206721
huangdarwin committed -
#minor-release PiperOrigin-RevId: 509189206
bachinger committed -
It may be confusing for 3P apps, for us to have separate error codes for (1) if encoding HDR is not supported at all by the device, and (2) if encoding the format, which happens to be HDR, is not supported by the device. Instead, we can communicate this in the error message. PiperOrigin-RevId: 509188666
huangdarwin committed -
Tests in `SilenceSkippingAudioProcessorTest` used half as many short integers as needed for channel values when generating alternating silence/noise input. Fix this by passing left and right channel input. PiperOrigin-RevId: 509188074
andrewlewis committed -
PiperOrigin-RevId: 509165378
claincly committed
-
- 10 Feb, 2023 5 commits
-
-
Following changes are included: 1. Added missing color information in HDR test case. 2. Corrected few namings in AudioBoxesTest.java. 3. Updated corresponding dump files. PiperOrigin-RevId: 508745206
sheenachhabra committed -
GLEffectsFrameProcessor, MatrixShaderProgram and FinalMatrixShaderProgramWrapper are currently setup to handle the input frames coming from an external input (i.e. a video decoder). Image input is loaded into Bitmap objects at the start of the pipeline, so they are not produced externally. The changes provide a way for the frame processing pipeline to handle this "internal" (i.e. non-external) input. PiperOrigin-RevId: 508645244
tofunmi committed -
The AsynchronousMediaCodecAdapter's queuing thread stores any exceptions raised by MediaCodec and re-throws them on the next call to queueInputBuffer()/queueSecureInputBuffer(). However, if MediaCodec raises and error while queueing, it goes into a failed state and does not announce available input buffers. If there is no input available input buffer, the MediaCodecRenderer will never call queueInputBuffer()/queueSecureInputBuffer(), hence playback is stalled. This change surfaces the queueing error through the adapter's dequeueing methods. PiperOrigin-RevId: 508637346
christosts committed -
`TrackSelectorResult.rendererConfigurations` can contain null elements: > A null entry indicates the corresponding renderer should be disabled. This wasn't caught by the nullness checker because `ExoPlayerImpl` is currently excluded from analysis. #minor-release Issue: google/ExoPlayer#10977 PiperOrigin-RevId: 508619169
ibaker committed -
PiperOrigin-RevId: 508602059
tonihei committed
-
- 09 Feb, 2023 1 commit
-
-
The existing implementation depends on an internal library (Mp4Slicer) to assert the output. We have removed the dependency on internal library and used golden data to compare the output. PiperOrigin-RevId: 508401527
sheenachhabra committed
-
- 14 Feb, 2023 5 commits
-
-
PiperOrigin-RevId: 508323432
christosts committed -
This simplifies usage of 64-bit sequence numbers. PiperOrigin-RevId: 508107588
Googler committed -
- For single-asset, the behavior stays the same. Transcode if and only if it's necessary, - For constrained multi-asset, always transcode, except if the setter to transmux is set. This is to avoid failing if a MediaItem that doesn't require transcoding is followed by a MediaItem that does require transcoding. PiperOrigin-RevId: 508097798
kimvde committed -
Previously, Robolectric's instrumentation updated all constructors to be public. This caused two main types of problems: 1) When non-public constructors were made public and added to the Android API, Robolectric allowed tests to incorrectly use the constructors on older SDK levels (where they were non-public). This most commonly occurs for AccessibiltyEvent and AccessibilityNodeInfo. 2) When reflection was used to instantiate classes that were instrumented by Robolectric, all constructors were accessible. Fix issues across Google3 Robolectric tests that were affected by this issue. A forthcoming change will fix the instrumentation in Robolectric to prevent this type of issue from occurring. Tested: TAP --sample ran all affected tests and none failed http://test/OCL:507861075:BASE:507805409:1675803313108:f2128fa4 PiperOrigin-RevId: 508087822Googler committed -
PiperOrigin-RevId: 508062795
sheenachhabra committed
-
- 08 Feb, 2023 14 commits
-
-
PiperOrigin-RevId: 508053559
michaelkatz committed -
PiperOrigin-RevId: 508031337
kimvde committed -
If a renderer error happens while processing readahead data for the next item in the playlist, we currently throw the error immediately and only set the item id in the error details. This makes it harder to associate the error to the right item. For example, the user facing UI is likely not updated to show the failing item when the error is reported. This can be improved slighly by force setting the position to the failing item. The playback still fails immediately, but this can't be avoided because the renderer itself went into an error state. PiperOrigin-RevId: 507808635
tonihei committed -
PiperOrigin-RevId: 507784608
microkatz committed -
This will also allow us to skip transcodes in the future for other effects, like cropping, color effects, etc. PiperOrigin-RevId: 507765618
huangdarwin committed -
Also replace some usages of deprecated Transformer listeners with the new ones. PiperOrigin-RevId: 507743860
kimvde committed -
The AudioTrackPositionTracker needs to correct positions by the speed set on the AudioTrack itself whenever it makes estimations based on real-time (=the real-time playout duration is not equal to the media duration played). This happens for the main playback path already, but not for the mode in which the position is estimated from the playback head position and also not in the phase after the track has been stopped. Both cases are not very noticeable during normal playback, but become relevant when playing in offload mode. PiperOrigin-RevId: 507736408
tonihei committed -
Checked there's no other occurrence. PiperOrigin-RevId: 507534909
claincly committed -
Also, replace instances of "texture processor" to "shader program", with capitalization retained. PiperOrigin-RevId: 507515655
huangdarwin committed -
PiperOrigin-RevId: 507515587
tofunmi committed -
In MediaCodecUtil, use Format.colorInfo, besides the codec string, to accurately map to a 10bit HEVC profile. PiperOrigin-RevId: 507500071
christosts committed -
PiperOrigin-RevId: 507461550
claincly committed -
This is a refactoring to separate and simplify the logic of VOD and live streams when handling IMA ad events. An additional listener will be required for DASH live stream in a follow-up CL. PiperOrigin-RevId: 507435741
bachinger committed -
Also update some Javadoc in Transformer PiperOrigin-RevId: 507395956
kimvde committed
-