Commits · ccdd1a43c2a4e19a8b9706378ba6b2988ca451a8 · SDK / exoplayer

20 Apr, 2020 11 commits

Fix AdsMediaSource child sources not being released · ccdd1a43
```
Also add unit tests for AdsMediaSource.

PiperOrigin-RevId: 307365492
```
andrewlewis committed Apr 20, 2020
ccdd1a43 Browse Files

Audio processors are now flushed twice after reconfiguration.
The second flush call cleared the pending trim start bytes so
transitions between tracks were no longer gapless.

Fix this by removing logic to clear pending trim bytes on flush.
As a result we may trim data incorrectly if there is a flush
before any data has been handled for seeking to a non-zero
position, but this edge case will happen rarely and the effect
shouldn't be noticeable.

PiperOrigin-RevId: 307344357

committed Apr 20, 2020

02af670a Browse Files

Merge trick play tracks into main track groups · fea43767
```
Issue: #6054
PiperOrigin-RevId: 307285068
```
olly committed Apr 20, 2020
fea43767

Support ad tag with default media source · 8ea33e23

This is the missing attribute to support all features of the Sample with MediaItem. Hence PlayerActivity can use the setMediaItems() method directly without creating actual media sources in the app code.

PiperOrigin-RevId: 307102036

committed Apr 20, 2020

8ea33e23 Browse Files

Improve the error message when an extractor dump file is not found · 9937744f
```
PiperOrigin-RevId: 307078446
```
ibaker committed Apr 20, 2020
9937744f Browse Files
Better tie injection of Cache/CacheDataSource/CacheKeyFactory · 7ea83d71
```
PiperOrigin-RevId: 307056661
```
olly committed Apr 20, 2020
7ea83d71 Browse Files
Merge pull request #7210 from nebyan:CacheKeyFactoryNotUsed · 704993ce
```
PiperOrigin-RevId: 307045655
```
Oliver Woodman committed Apr 20, 2020
704993ce Browse Files

Use higher level interface for method parameters where possible. · 7350981e

This makes it easier to use the helper methods because the player doesn't
have to be assigned to a SimpleExoPlayer in all cases.

PiperOrigin-RevId: 307039126

committed Apr 20, 2020

7350981e Browse Files

Remove a suppression introduced by the checker-framework 3.3.0 upgrade · ece8d223

Update the comment on a suppression of Field.get(null) which is safe
but blocked by the checker.

These suppressions were introduced in https://github.com/google/ExoPlayer/commit/d1e057244812a566a5fc8b18a2caec1908db1a43

PiperOrigin-RevId: 307036441

committed Apr 20, 2020

ece8d223

Wait with throwing stuck buffering error until pending load is finished · ca2105d5

We currently check for shouldContinueLoading, which is the intention to load,
not playbackInfo.isLoading, which is the actual loading state, when detecting
stuck buffering issues.

They only differ if the LoadControl said stop loading (based on nextLoadPosition),
but there is still a load in flight (updating bufferedPosition). This may cause
the exception to be thrown in edge cases that are only temporary.

PiperOrigin-RevId: 307022608

committed Apr 20, 2020

ca2105d5 Browse Files

Add Format.label to the extractor test dumps · 15bbd181
```
Needed to test issue:#7247

PiperOrigin-RevId: 307016276
```
ibaker committed Apr 20, 2020
15bbd181 Browse Files

17 Apr, 2020 6 commits
- Merge pull request #7245 from Clement-Jean:silence-media-source-factory · abadc768
```
PiperOrigin-RevId: 307010600
```
  bachinger committed Apr 17, 2020
  abadc768
- Add tests for ID3 in Mp3Extractor · 63da73df
```
PiperOrigin-RevId: 306844582
```
  kimvde committed Apr 17, 2020
  63da73df
- Fix TeeAudioProcessor sink configuration · efaa98ee
```
TeeAudioProcessor needs to configure its sink when it is initially set up.

PiperOrigin-RevId: 306808871
```
  andrewlewis committed Apr 17, 2020
  efaa98ee
- Add custom cache key to media item · d7280f09
```
This is required to migrate the PlayerActivity away from Sample to MediaItem. It hence needs adding buildUpon to MediaItem to mix in the customCacheKey and streamKeys before playback.

PiperOrigin-RevId: 306710643
```
  bachinger committed Apr 17, 2020
  d7280f09
- Merge pull request #6270 from TiVo:p-iframe-only-playlist · 88de7745
```
PiperOrigin-RevId: 306677468
```
  bachinger committed Apr 17, 2020
  88de7745
- Test and fix H265Reader · ed977d14
```
- Update H265Reader to output the same samples after a seek to 0.
- Add a TsExtractor test for H.265.

PiperOrigin-RevId: 306675050
```
  kimvde committed Apr 17, 2020
  ed977d14
16 Apr, 2020 1 commit
- Add tag and Factory to SilenceMediaSource · 3c655981
  Clement Jean committed Apr 16, 2020
  
  3c655981 Browse Files
15 Apr, 2020 14 commits
- Use FrameLayout instead of ViewGroup for Subtitle(Web)View · 7214ad2d
```
This is a more specific ViewGroup subclass that handles some of the
layout logic automatically. It's designed to work best with a single
child view, as used here.

PiperOrigin-RevId: 306654947
```
  ibaker committed Apr 15, 2020
  7214ad2d
- Parse trick-play role flags from DASH manifests · ba0028ca
```
Issue: #6054
PiperOrigin-RevId: 306641689
```
  olly committed Apr 15, 2020
  ba0028ca
- Avoid throwing an exception for sample default values · 50926658
```
Allows playback of content when the default value is
not valid, but not used for any samples.

Issue: #7207
PiperOrigin-RevId: 306631376
```
  aquilescanta committed Apr 15, 2020
  50926658 Browse Files
- Add Clock#currentTimeMillis() · 91690f06
```
PiperOrigin-RevId: 306602043
```
  christosts committed Apr 15, 2020
  91690f06 Browse Files
- Allow custom playback session id generator. · 82341976
```
This allows users to inject their own session id logic.

PiperOrigin-RevId: 306597785
```
  tonihei committed Apr 15, 2020
  82341976 Browse Files
- Capitalize r's in HlsMediaPlaylist byte ranges · 4d22121c
```
PiperOrigin-RevId: 306504969
```
  aquilescanta committed Apr 15, 2020
  4d22121c Browse Files
- Don't select trick-play tracks by default · 6cff8a6a
```
Issue: #6054
Issue: #474
PiperOrigin-RevId: 306504362
```
  olly committed Apr 15, 2020
  6cff8a6a Browse Files
- Pass UriSample to DownloadTracker · a99288a6
```
PiperOrigin-RevId: 306469450
```
  olly committed Apr 15, 2020
  a99288a6 Browse Files
- Fix capabilities check for low frame-rate content · 66f1c044
```
Issue: #6054
Issue: #474
PiperOrigin-RevId: 306437452
```
  olly committed Apr 15, 2020
  66f1c044 Browse Files
- Fix javadoc typo · edc25ddc
```
PiperOrigin-RevId: 306431216
```
  aquilescanta committed Apr 15, 2020
  edc25ddc Browse Files
- Verify MediaSources passed to set/addMediaSources are non-null. · 6a491e12
```
Even though they are annotated as non-null, Java users can pass in null values.
So we should verify the input to fail fast.

PiperOrigin-RevId: 306425487
```
  tonihei committed Apr 15, 2020
  6a491e12 Browse Files
- Fix NPE in AdaptiveBitrateTest due to missing Looper. · 76ad0bc4
```
The new TestExoPlayer.Builder asserts that a Looper is present in
the constructor, although it can be set later for cases where no
such Looper exists.

PiperOrigin-RevId: 306403491
```
  tonihei committed Apr 15, 2020
  76ad0bc4 Browse Files
- Delete ExtractorAsserts.assertThrows · af81238c
```
This doesn't seem to be used anywhere

PiperOrigin-RevId: 306391995
```
  ibaker committed Apr 15, 2020
  af81238c Browse Files
- Suppress warnings in preparation for Checker Framework 3.3.0 upgrade. · d1e05724
```
PiperOrigin-RevId: 305810757
```
  olly committed Apr 15, 2020
  d1e05724 Browse Files
09 Apr, 2020 5 commits
- Disallow FakeTrackOutput.format() without sampleMetadata() in between · 2dafb8fd
```
In general an extractor shouldn't be outputting multiple formats with
no samples in between.

PiperOrigin-RevId: 305674393
```
  ibaker committed Apr 09, 2020
  2dafb8fd Browse Files
- Tweak PassthroughSectionPayloadReader to allow timestamp to change · dfd5c512
```
PiperOrigin-RevId: 305674374
```
  ibaker committed Apr 09, 2020
  dfd5c512 Browse Files
- Eagerly set the format in PassthroughSectionPayloadReader.init · d9a8622b
```
This reverts https://github.com/google/ExoPlayer/commit/94315ab757505f98d0b907fa2f7d2c516356ecae

This fixes issue:#7177

PiperOrigin-RevId: 305674114
```
  ibaker committed Apr 09, 2020
  d9a8622b Browse Files
- Add mute/unmute to DeviceComponent · e250900a
```
PiperOrigin-RevId: 305648273
```
  gyumin committed Apr 09, 2020
  e250900a
- CacheKeyFactory is not used. · a944b5cc
  nebyan committed Apr 09, 2020
  
  a944b5cc Browse Files
08 Apr, 2020 3 commits
- Improve tests and samples naming in TsExtractor · d33c5ac0
```
PiperOrigin-RevId: 305526093
```
  kimvde committed Apr 08, 2020
  d33c5ac0
- Update misc dependencies · 2e51182f
```
PiperOrigin-RevId: 305503804
```
  olly committed Apr 08, 2020
  2e51182f Browse Files
- Add PsExtractor test for AC3 · afc2858a
```
PiperOrigin-RevId: 305503256
```
  kimvde committed Apr 08, 2020
  afc2858a