- 27 Nov, 2020 11 commits
-
-
Also make compilation automatically determine the number of threads to use during compilation. PiperOrigin-RevId: 344264761
aquilescanta committed -
#exofixit PiperOrigin-RevId: 344246408
olly committed -
PiperOrigin-RevId: 344243929
olly committed -
This is simpler than instantiating a single-element string array for every parameter. #exofixit PiperOrigin-RevId: 344237475
ibaker committed -
#exofixit PiperOrigin-RevId: 344232362
samrobinson committed -
Issue: #8239 #exofixit #minor-release PiperOrigin-RevId: 344211877
andrewlewis committed -
In many cases it doesn't matter for the test itself how many windows a timeline has, or even how the timeline of a MediaSource looks like. And since we introduced the MediaItem-based APIs, single-window Timelines are the only fully supported Timelines. Thus there is no point in specifiying this explicitly. Using these assumptions, we can remove some boilerplate when setting up standard FakeTimelines or FakeMediaSources with a standard FakeTimeline. #exofixit PiperOrigin-RevId: 344210395
tonihei committed -
#exofixit Issue: #5602 PiperOrigin-RevId: 344093622
olly committed -
The current code creates placeholder metadata elements if there is no static metadata. This causes onStaticMetadataChanged callbacks even if there is no metadata. Instead, we can keep the empty list as the static metadata is already documented to be an empty list if the metadata is unavailable. #exofixit PiperOrigin-RevId: 344071639
tonihei committed -
#exofixit PiperOrigin-RevId: 344065556
bachinger committed -
#exofixit PiperOrigin-RevId: 344065519
bachinger committed
-
- 24 Nov, 2020 21 commits
-
-
The ref'd issue was marked as a doucmentation candidate, but I think the confusion likely arises from the lack of "next" and "previous" in the method names. Our other UI components also support enabling each button individually, so this also brings notifications in line with those. Issue: #6491 #exofixit PiperOrigin-RevId: 344058969
olly committed -
PiperOrigin-RevId: 344057097
kim-vde committed -
* These grouping parentheses are unnecessary; it is unlikely the code will be misinterpreted without them (see http://go/bugpattern/UnnecessaryParentheses) (2 times) This CL looks good? Just LGTM and Approve it! This CL doesn’t look good? This is what you can do: * Suggest a fix on the CL (go/how-to-suggest-fix). * Revert this CL, by replying "REVERT: <provide reason>" * File a bug under go/error-prone-bug for category ErrorProneStyle if the change looks generally problematic. * Revert this CL and not get a CL that cleans up these paths in the future by replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to opt out the respective paths in your CL Robot configuration instead: go/clrobot-opt-out. This CL was generated by CL Robot - a tool that cleans up code findings (go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/java/com/google/android/libraries/exoplayer/METADATA which is reachable following include_presubmits from //depot/google3/third_party/java_src/android_libs/exoplayer/METADATA. Anything wrong with the signup? File a bug at go/clrobot-bug. #codehealth PiperOrigin-RevId: 344053269
olly committed -
#exofixit PiperOrigin-RevId: 344052500
kimvde committed -
#minor-release PiperOrigin-RevId: 344051610
christosts committed -
PiperOrigin-RevId: 344051289
olly committed -
These tests appear not to need an activity, and removing it means we don't need to switch away from the deprecated `ActivityTestRule`. #exofixit PiperOrigin-RevId: 344037927
andrewlewis committed -
#exofixit PiperOrigin-RevId: 344031062
andrewlewis committed -
- Remove restriction on `AdsMediaSource`s in playlists in `ExoPlayerImpl`. - Allow playing playlists of `AdsMediaSource`s in the demo app. - Add a sample with ads in a playlist in the demo app. Issue: #3750 PiperOrigin-RevId: 344018774
andrewlewis committed -
Null check warning was reported by //java/com/google/android/apps/gsa/staticplugins/silk/silkcast:silkcast_nullness_checker //third_party/java_src/android_libs/exoplayer/v2/extensions/media2/src/main:library_nullness_test PiperOrigin-RevId: 343939763
olly committed -
https://github.com/google/ExoPlayer/commit/483a350e84367f0c1bacbea293ba0108ffd3ca9e
*** Original commit *** Suppress warnings in preparation for Checker Framework 3.7.1 upgrade. LSC: go/checker-lsc Tested: TAP train for global presubmit queue http://test/OCL:342788973:BASE:342817196:1605636478036:6c558c0c *** PiperOrigin-RevId: 343895651tonihei committed -
PiperOrigin-RevId: 343883034
olly committed -
PiperOrigin-RevId: 343882631
olly committed -
Issue: #3750 PiperOrigin-RevId: 343878310
andrewlewis committed -
#exofixit PiperOrigin-RevId: 343871061
olly committed -
#exofixit PiperOrigin-RevId: 343857564
samrobinson committed -
This saves a few lines of code and is nicer. We already did make sure to update the notification only once by posting because of b/145521438. #exofixit PiperOrigin-RevId: 343852256
bachinger committed -
Don't refer to the "system's default charset", just specify UTF-8 explicitly. PiperOrigin-RevId: 343839878
ibaker committed -
#exofixit PiperOrigin-RevId: 343821736
olly committed -
The EventTime wasn't part of the onEvents callbacks so far because the individual events may have different event times (e.g. if they relate to different media periods). By adding a query method to obtain the EventTime by event type, we can solve this issue. #exofixit PiperOrigin-RevId: 343818819
tonihei committed -
Mentioning the realtionship on every other callback makes it easier for the casual developer to understand the relationship between the methods and discover the existence of onEvents. PiperOrigin-RevId: 343811032
tonihei committed
-
- 23 Nov, 2020 3 commits
-
-
Previously, VideoFrameReleaseTimeHelper didn't receive PTS values for frames that were skipped. This would lead to unnecessary sync loss when encountering such buffers, because the helper would see a frame-rate change (i.e., the next frame being significantly longer than previous ones). After this change, VideoFrameReleaseTimeHelper is notified of all frame PTS values, so it can retain sync in this case. This change also propagates onStarted and onPositionReset to the helper. This paves the way for decoupling frame-rate estimation from release adjustment sync. Note that currently, loss of sync effectively resets both. This is unnecessary. For example, if the renderer is paused and later resumed, then release adjustment sync needs to be reset, but any frame-rate estimate we have is still valid. PiperOrigin-RevId: 343803531
olly committed -
https://github.com/google/ExoPlayer/commit/8d84a50fa1c86f730105cd648bb2454f365830d4
*** Original commit *** Update Styled non bottom buttons to be borderless. This requires the parent of the background to draw and have padding large enough to support the size of the ripple. The bottom buttons must remained bordered as the space around them is constrained. *** PiperOrigin-RevId: 343531411
olly committed -
PiperOrigin-RevId: 343507207
tonihei committed
-
- 20 Nov, 2020 5 commits
-
-
RunnableFutureTask is not reusable. Trying to reuse it meant that a failure in one doWork() call would cause subsequent download() calls to (a) not block until the runnable has finished executing (does not apply when using a direct executor), and (b) throw the same failure as thrown from the first doWork() call. This could cause #8078 if the initial failure occurred before the content length was resolved. Retries are not blocked on their work completing due to (a), and the download would be marked as failed due to (b). The work itself could then resolve the content length, which causes the stack trace in this issue. Issue: #8078 PiperOrigin-RevId: 343498252
olly committed -
This callback allows listeners to know when all simultanous changes have been handled and the values reported through callbacks are again completely consistent with value obtained from Player getter calls. PiperOrigin-RevId: 343476639
tonihei committed -
PiperOrigin-RevId: 343467276
tonihei committed -
The demo app has two states for downloads, as per DownloadTracker.isDownloaded. It's either "downloaded or downloading" (isDownloaded returns true, and the UI shows a blue tick) or it's "not downloaded or failed (isDownloaded returns false, and the UI does not show a blue tick). toggleDownload is out of sync in that it treates "failed" as belonging to the first state rather than the second. This means tapping on the grey tick in the UI in this case appears to be a no-op (tapping it again will make something happen). This change aligns things by making toggleDownload re-download in the case a previous download failed. In the future we could consider having three states, so failed downloads could be disambiguated properly. Unclear whether it's a good complexity/benefit trade-off for the demo app though! #minor-release PiperOrigin-RevId: 343464364
olly committed -
When a stream has duplicate timestamps we currently discard to the last sample with the specified discardTo timestamp, but it should be the first one to adhere to the method doc and the intended usage. #minor-release PiperOrigin-RevId: 343458870
tonihei committed
-