Commits · ad115a5ab3882539704bd8cca09b13afe51a561b · SDK / exoplayer

03 Feb, 2020 14 commits
- Fix some boolean logic in TtmlStyle#inherit · ad115a5a
```
I got confused copying the hasBackgroundColor logic in
https://github.com/google/ExoPlayer/commit/3aa52c231720eaed88cdf27eff0f97d4bcf7625f

Add tests to confirm I got it right this time

PiperOrigin-RevId: 292898421
```
  ibaker committed Feb 03, 2020
  ad115a5a Browse Files
- Remove redundant prepared flag in ProgressiveMediaPeriod · 49fa6d63
```
PiperOrigin-RevId: 292892407
```
  kimvde committed Feb 03, 2020
  49fa6d63 Browse Files
- Remove deprecated Format.createSampleFormat · 8ac5698a
```
PiperOrigin-RevId: 292888026
```
  olly committed Feb 03, 2020
  8ac5698a Browse Files
- Avoid unnecessary decoder instantiations on key rotation · 97fbbad6
```
Issue: #6903
PiperOrigin-RevId: 292884280
```
  olly committed Feb 03, 2020
  97fbbad6 Browse Files
- Migrate static imports of org.mockito.Matchers to org.mockito.ArgumentMatchers · 719b34a9
```
The former is deprecated and replaced by the latter in Mockito 2.

For more information see go/mockito-2-lsc

Tested:
    TAP --sample ran all affected tests and none failed
    http://test/OCL:292555754:BASE:292543534:1580490509580:bfdfdd31
PiperOrigin-RevId: 292881633
```
  olly committed Feb 03, 2020
  719b34a9 Browse Files
- Update release notes for 2.11.2 · bb8aa4f5
```
PiperOrigin-RevId: 292881432
```
  olly committed Feb 03, 2020
  bb8aa4f5 Browse Files
- Make SingleSampleMediaSource.Factory reusable · c095a9ff
```
PiperOrigin-RevId: 292879934
```
  olly committed Feb 03, 2020
  c095a9ff Browse Files
- Replace most usages of @TargetApi with @RequiresApi · b6bd57ab
```
We keep @TargetApi where the method is a safe no-op on
older versions due to an in-line version check.

PiperOrigin-RevId: 292878727
```
  ibaker committed Feb 03, 2020
  b6bd57ab Browse Files
- Tweak SpannedSubject error message when `actual` has no spans · dd10d96a
```
Before:
No matching span found
in text  : Text with combined section.
expected : start=10	end=18	type=HorizontalTextInVerticalContextSpan	substring='combined'
but found:

After:
No matching span found
in text : Text with combined section.
expected: start=10	end=18	type=HorizontalTextInVerticalContextSpan	substring='combined'
but found no spans
PiperOrigin-RevId: 292878264
```
  ibaker committed Feb 03, 2020
  dd10d96a Browse Files
- Reduce the number of allocations in SubtitlePainter.setupTextLayout · c7ea8bbf
```
PiperOrigin-RevId: 292877661
```
  ibaker committed Feb 03, 2020
  c7ea8bbf Browse Files
- Change Format.createTextSampleFormat for common uses cases · 3a702cf5
```
PiperOrigin-RevId: 292863614
```
  olly committed Feb 03, 2020
  3a702cf5 Browse Files
- Fixes incorrect parameter name comments in ImaAdsLoaderTest · d7551f97
```
This CL fixes build warnings (incorrect parameter name comment).

PiperOrigin-RevId: 292829708
```
  olly committed Feb 03, 2020
  d7551f97 Browse Files
- Change Format.createImageSampleFormat for common use case · 0be3451c
```
PiperOrigin-RevId: 292570360
```
  olly committed Feb 03, 2020
  0be3451c Browse Files
- Add some missing local @Nullable annotations · a7c6cb4a
```
PiperOrigin-RevId: 292564056
```
  olly committed Feb 03, 2020
  a7c6cb4a Browse Files
31 Jan, 2020 6 commits

Add Format.createSampleFormat for common use case · d287e13d
```
PiperOrigin-RevId: 292562678
```
olly committed Jan 31, 2020
d287e13d Browse Files
Remove deprecated Format constructors · 04218bde
```
PiperOrigin-RevId: 292554283
```
olly committed Jan 31, 2020
04218bde Browse Files
Lock down SampleQueue to reasonable extension points · 660cfd28
```
PiperOrigin-RevId: 292542298
```
olly committed Jan 31, 2020
660cfd28 Browse Files
Fix annotation position · 37745308
```
PiperOrigin-RevId: 292519511
```
olly committed Jan 31, 2020
37745308 Browse Files

Rollback of https://github.com/google/ExoPlayer/commit/3e41c0a1d28020251a841c86255d677f3d760792 · 2a718c5a

*** Original commit ***

Rollback of https://github.com/google/ExoPlayer/commit/3c56b113e43812f188bdd9750f48897e812697ce

*** Original commit ***

Rollback of https://github.com/google/ExoPlayer/commit/d48dc4c15933dd8354cbcc6260c48565bb850e15

*** Original commit ***

Move getting-stuck-prevention into DefaultLoadControl.

We recently added code that prevents getting stuck if the buffer is low and
the LoadControl refuses to continue loading (https://github.com/google/ExoPlayer/commit/b84bde025258e7307c52eaf6bbe58157d788aa06).

Move this logic...

***

PiperOrigin-RevId: 292457964

committed Jan 31, 2020

2a718c5a Browse Files

annotate nullabilty of CommandReceiver · 2adec8d9
```
Issue: #6938
PiperOrigin-RevId: 292415853
```
bachinger committed Jan 31, 2020
2adec8d9 Browse Files

30 Jan, 2020 15 commits
- Adjust `FakeSampleStream` to take varargs of `FakeSampleStreamItem`. · 52fb5f38
```
This is instead of taking a list.

PiperOrigin-RevId: 292354720
```
  samrobinson committed Jan 30, 2020
  52fb5f38 Browse Files
- Fix outputFormat not being assigned after position is reset. · 3e6efe7e
```
PiperOrigin-RevId: 292350437
```
  samrobinson committed Jan 30, 2020
  3e6efe7e Browse Files
- Add missing AV1 extension path to .gitignore · ffabb9f6
```
PiperOrigin-RevId: 292347360
```
  andrewlewis committed Jan 30, 2020
  ffabb9f6 Browse Files
- Start fixing nullness in testutil · 7c8a54c6
```
PiperOrigin-RevId: 292340530
```
  olly committed Jan 30, 2020
  7c8a54c6 Browse Files
- HLS: Fix key rotation · ff822ff9
```
Passing EXT-X-KEY DrmInitData through the FragmentedMp4Extractor
doesn't work for streams with key rotation, because an extractor
instance is used for multiple segments, but is only passed the
EXT-X-KEY DrmInitData corresponding to the first segment.

This change removes passing DrmInitData through the extractor,
and instead passes it via FormatAdjustingSampleQueue. This is
in-line with how manifest DrmInitData is handled during DASH
playbacks.

Issue: #6903
PiperOrigin-RevId: 292323429
```
  olly committed Jan 30, 2020
  ff822ff9 Browse Files
- Merge pull request #6724 from nnoury:fix/subtitles-outline-color · cf065890
```
PiperOrigin-RevId: 292316767
```
  Oliver Woodman committed Jan 30, 2020
  cf065890 Browse Files
- SampleQueue: Let subclasses easily invalidate format adjustment · d75aa97c
```
This is a nice-regardless improvement to SampleQueue, which will
likely to used to fix the referenced issue. It makes it possible
for SampleQueue subclasses to support dynamic changes to format
adjustment in a non-hacky way.

Issue: #6903
PiperOrigin-RevId: 292314720
```
  olly committed Jan 30, 2020
  d75aa97c Browse Files
- add playWhenReady changed callback with reasons · 21fe13d3
```
PiperOrigin-RevId: 292194805
```
  bachinger committed Jan 30, 2020
  21fe13d3 Browse Files
- Add tate-chu-yoko support to TtmlDecoder · 64244039
```
PiperOrigin-RevId: 292161845
```
  ibaker committed Jan 30, 2020
  64244039 Browse Files
- Move DrmSession into the core module · 6377e277
```
PiperOrigin-RevId: 292112214
```
  aquilescanta committed Jan 30, 2020
  6377e277 Browse Files
- Update mp3 test files to test more common use cases · 427db0b5
```
PiperOrigin-RevId: 292110291
```
  kimvde committed Jan 30, 2020
  427db0b5 Browse Files
- Fix incorrect parameter name comment · 016042de
```
PiperOrigin-RevId: 292099759
```
  olly committed Jan 30, 2020
  016042de Browse Files
- MP3 IndexSeeker: handle seek to non-yet-read frames · 5d74ebe5
```
Issue: #6787
PiperOrigin-RevId: 291953855
```
  kimvde committed Jan 30, 2020
  5d74ebe5 Browse Files
- Add @Dimension annotation to SubtitleView size methods · e15989ff
```
PiperOrigin-RevId: 291943185
```
  ibaker committed Jan 30, 2020
  e15989ff Browse Files
- Make SubtitleWebView 'invisible' to touch events · 658e0e17
```
Without this, tapping the main video playback doesn't bring up the
controls.

PiperOrigin-RevId: 291943063
```
  ibaker committed Jan 30, 2020
  658e0e17 Browse Files
29 Jan, 2020 1 commit

Introduce edgeLayout to keep outline color · 1e72e1ac

Fix outline style subtitle

When a ForegroundColorSpan changes the foreground color, it is also applied
to the outline painter. In order to keep the correct color, one needs to
filter out theses span. We do this with a new cue that is our text source
for the specific edgeLayout.

Take care to only apply background color once

Test: Manual check - Subtitle view can show custom color subtitles from specific Subtitle
Renderer and outline is shown correctly using user defined color.

committed Jan 29, 2020

1e72e1ac Browse Files

28 Jan, 2020 4 commits

Do not throw on valid SubtitleView.setViewType · e92ea31f

Calling setViewType with the same view type as the
subtitleView is using would throw InvalidArgumentException
instead of being a noop.

PiperOrigin-RevId: 291937202

committed Jan 28, 2020

e92ea31f Browse Files

Add SubtitleWebView · 2fd8cf02
```
PiperOrigin-RevId: 291927263
```
ibaker committed Jan 28, 2020
2fd8cf02 Browse Files

Simplify startMediaTimeUs states. · b83534ee

We currently have 3 states, but the NOT_SET state isn't needed
anymore. We can therefore replace the IntDef by a simple boolean.

PiperOrigin-RevId: 291926049

committed Jan 28, 2020

b83534ee Browse Files

Include startMediaTime in media position checkpoints. · 739fd5f5

We currently apply new parameter checkpoints from an absolute media
time and then substract the current media start time again to retrieve
the media time offset for this playback parameter checkpoint.

However, the media start time may change when unexpected discontinuities
happen (the start time doesn't actually change, but we change it to
correct for this discontinuity). This then invalidates the absolute
media time in the playback parameter checkpoints (which should have been
corrected as well).

Avoid this problem by also only applying the new start position
from the checkpoint. We don't have to save the start position anymore
because it will cancel itself out.

Also add some documentation and code clarification for improved
readability.

PiperOrigin-RevId: 291923069

committed Jan 28, 2020

739fd5f5 Browse Files