- 03 Jul, 2020 17 commits
-
-
PiperOrigin-RevId: 319223173
Oliver Woodman committed -
PiperOrigin-RevId: 319222833
samrobinson committed -
Even without a drmInitData, a format can still has a DRM. PiperOrigin-RevId: 319217188
krocard committed -
PiperOrigin-RevId: 319205008
olly committed -
The system services may return a null value if the service is not available. Guard against this by falling back to default values. PiperOrigin-RevId: 319187882
tonihei committed -
Issue: #7011 Issue: #6725 Issue: #7066 This also mitigates (but doesn't fix) Issue: #4133 because it prevents a second key load after a short clear section. PiperOrigin-RevId: 319184325
ibaker committed -
PiperOrigin-RevId: 319183621
tonihei committed -
PiperOrigin-RevId: 319183486
krocard committed -
- Removed unnecessary private method - Revised document for animation_enabled attribute - Added setAnimationEnabled/isAnimationEnabled in StyledPlayerControlView PiperOrigin-RevId: 319054648
insun committed -
Including ExoPlayer via relative paths currently breaks the import logic of the common library settings file because it's referenced from different directories. Fix this by resolving the setting path to its canonical name. Issue: #7554 PiperOrigin-RevId: 319043560
tonihei committed -
See https://developer.android.com/reference/android/media/MediaCodec.CryptoInfo#numBytesOfClearData. Both values are allowed to be null. PiperOrigin-RevId: 319038124
tonihei committed -
SampleStreams should always provide samples starting from a keyframe. We do not have equivalent logic in any of our extension decoder renderers. PiperOrigin-RevId: 319012365
olly committed -
PiperOrigin-RevId: 319007693
olly committed -
The list of MediaSourceHolder in ExoPlayerImpl is only maintained to be able to create a PlaylistTimeline for masking. By keeping only the id and a snapshot of the timeline of the MediaSourceHolder in ExoPlayerImpl, parallel access is prevented and we still have sufficient information to create the masking timeline. PiperOrigin-RevId: 319003837
bachinger committed -
Moved ui2/ code and resources into ui/ PiperOrigin-RevId: 318984707
insun committed -
We can't restore the previous state of the remaining chunk, so we can't support discarding from spliced-in chunks. Mark this explicitly instead of attempting to discard from the previous chunk. PiperOrigin-RevId: 318983628
tonihei committed -
I don't need to keep a separate playback looper, I can just use ShadowLooper.idleMainLooper(). PiperOrigin-RevId: 318823190
ibaker committed
-
- 01 Jul, 2020 1 commit
-
-
This fixes an issue where, even if captioning manager is disabled, the latest used captioning manager preference related to text size is being applied. In order to replicate: 1. Go to Captioning Preferences under device Settings and enable it 2. Change the text size to "very large" 3. Observe the selected text size is used for subtitles, for example in Youtube 4. Go to Captioning Preferences under device Settings and disable it 5. Observe the text size used for subtitles does not come back to normal, stays on "very large"
Juanky Soriano committed
-
- 29 Jun, 2020 11 commits
-
-
- Deprecate constructors that don't take an executor, to direct developers toward the new ones. Callers can trivially pass Runnable::run to one of the new ones if they want old behaviour. - Add comment explaining warning suppression added in the CL that added parallelised download support. Issue: #5978 PiperOrigin-RevId: 318803296
olly committed -
This will be necessary to support partially fragmented MP4s. PiperOrigin-RevId: 318798726
kimvde committed -
This enhances readability, particularly as those methods will become more complex when partially fragmented media will be supported. PiperOrigin-RevId: 318795536
kimvde committed -
PiperOrigin-RevId: 318790917
olly committed -
Previously only pcm encoding were stored in Format, this was an issue as for audio passthrough and offload lots of code needs to pass complex format informations (encoding, sample rate, channel count, gapless metadata) but could not use Format and each function was taking each as different parameter. By allowing Format to contain any encoding, and not only pcmEncoding, it allows to pass a Format everywhere in ExoPlayer code that needs a Format. This patch does not have any functional change. It is only an internal refactor. PiperOrigin-RevId: 318789444
krocard committed -
PiperOrigin-RevId: 318786283
tonihei committed -
PiperOrigin-RevId: 318785458
bachinger committed -
The seek start position was set to the first mdat but this box was always skipped because the moof box was not read. PiperOrigin-RevId: 318762126
kimvde committed -
Issue: Issue: #6978 PiperOrigin-RevId: 318710782
olly committed -
PiperOrigin-RevId: 318485946
kimvde committed -
According to the discussion in <unknown commit>. PiperOrigin-RevId: 318473575
bachinger committed
-
- 26 Jun, 2020 11 commits
-
-
On reaching the end of the content we would notify content complete and skip unplayed ads, causing a timeline change. That timeline change was handled in a way that caused a further timeline change in the 2.11.6 release, where we don't yet deduplicate no-op Timeline changes, causing repeated timeline changes indefinitely. At tip-of-tree, the timeline wouldn't refresh repeatedly. However the code for sending content complete at the point of transitioning to play a preloaded postroll ad was not correct in that it didn't mark previous ads as skipped. Instead they happened to be marked as skipped later on due to the timeline change handling content completion code triggering again. Fix this by only marking ads as skipped when content completes once, to avoid the duplicate timeline change, and moving the skipped ad marking so it happens in the same place as notifying content complete. PiperOrigin-RevId: 318454908
andrewlewis committed -
MediaCodec does not need to be re-created in the event of gapless metadata. PiperOrigin-RevId: 318439694
samrobinson committed -
Gapless offload is fixed in later R beta builds of all Pixels supporting R. On the firsts R beta builds of Pixel 4, run the following command. `setprop vendor.audio.offload.gapless.enabled true`. It can not be enabled on the first Pixel 2 and 3 beta build. PiperOrigin-RevId: 318436134
krocard committed -
This it is enabled only on a list of manually tested devices. The list is empty in this CL. *** Reason for rollforward *** Fixed dependent cl was rolled forward. *** Original change description *** Rollback of https://github.com/google/ExoPlayer/commit/962e08d3be3b47166d1628cd1951e115c5cc00be *** Original commit *** Add Offload gapless support Confirmed to work on a Pixel 4 after enabling the feature: `setprop vendor.audio.offload.gapless.enabled true` *** *** PiperOrigin-RevId: 318433123
krocard committed -
*** Reason for rollforward *** Fixed dependent cl was rolled forward *** Original change description *** Rollback of https://github.com/google/ExoPlayer/commit/2aac0717d728df5511ebac5855467e83cd2d4aa0 *** Original commit *** Propagate format in supportsOutput It is needed to know if gapless is needed, as gapless offload might not be supported. *** *** PiperOrigin-RevId: 318429321
krocard committed -
*** Reason for rollforward *** Rollforward after making sure the handler is created, and that a test is written preventing a similar regression. *** Original change description *** Rollback of https://github.com/google/ExoPlayer/commit/b6f5a263f725089c026bb8416ade555f4f16a2bc *** Original commit *** Rollforward of commit 5612ac50. *** Reason for rollforward *** Rollforward after making sure the handler is created from the playback thread and not from an app thread. *** Original change description *** Rollback of https://github.com/google/ExoPlayer/commit/e1beb1d1946bb8ca94f62578aee8cbadd97b6e2b *** Original commit *** PiperOrigin-RevId: 318274400
krocard committed -
PiperOrigin-RevId: 318264209
krocard committed -
PiperOrigin-RevId: 318255509
kimvde committed -
Ignore two tests in AsynchronousMediaCodecBufferEnqueuerTest until the ShadowMediaCodec's behavior is updated to apply input buffer ownership. PiperOrigin-RevId: 318251859
christosts committed -
PiperOrigin-RevId: 318152038
insun committed -
This uses a license server implemented using MockWebServer to test DefaultDrmSessionManager and DefaultDrmSession. PiperOrigin-RevId: 318086890
ibaker committed
-