- 05 May, 2020 11 commits
-
-
PiperOrigin-RevId: 309899166
aquilescanta committed -
Issue: #7309 PiperOrigin-RevId: 309749566
aquilescanta committed -
PiperOrigin-RevId: 309746009
olly committed -
PiperOrigin-RevId: 309735092
andrewlewis committed -
These tests require longer content so that the ads are spaced apart far enough to trigger preloading while content is playing (rather than immediately as soon as a position is reported). PiperOrigin-RevId: 309733826
andrewlewis committed -
Also clean up naming of test ads responses. PiperOrigin-RevId: 309728625
andrewlewis committed -
PiperOrigin-RevId: 309720018
tonihei committed -
PiperOrigin-RevId: 309710359
olly committed -
PiperOrigin-RevId: 309709215
tonihei committed -
And allow default value constant to be assigned as valid value. PiperOrigin-RevId: 309708888
tonihei committed -
We currently call the old (deprecated) from the new one and not the other way round. Also remove a duplicated method. PiperOrigin-RevId: 309702752
tonihei committed
-
- 01 May, 2020 29 commits
-
-
DownloadManager doesn't know enough about the Downloader implementations to know that interrupting the thread is the right thing to do. In particular, if a Downloader implementation wants to delegate work to additional worker threads, then it will probably not want its main thread to be interrupted on cancelation. Instead, it will want to cancel/interrupt its worker threads, and keep its main thread blocked until work on those worker threads has stopped (download() must not return whilst the Downloader is still touching the cache). This change moves control over what happens to the individual Downloader implementations. Issue: #5978 PiperOrigin-RevId: 309419177
olly committed -
- Stop throwing InterruptedException from CacheUtil. When a CacheUtil operation throws or returns, the caller should always check its own state to determine whether they canceled the operation. If a caller is trying to catch InterruptedException separately to IOException to do something different in that case, they're probably doing the wrong thing. So it's simpler, and probably less error prone, just to throw an IOException in the case of interruption. - Throwing InterruptedIOException is also consistent with what our Extractor and DataSource implementations do. Issue: #5978 PiperOrigin-RevId: 309411556
olly committed -
PiperOrigin-RevId: 309411490
olly committed -
PiperOrigin-RevId: 309395364
Oliver Woodman committed -
Issue: #7306 PiperOrigin-RevId: 309392633
olly committed -
PiperOrigin-RevId: 309391401
ibaker committed -
PiperOrigin-RevId: 309390501
aquilescanta committed -
PiperOrigin-RevId: 309390205
ibaker committed -
PiperOrigin-RevId: 309390050
ibaker committed -
PiperOrigin-RevId: 309389731
ibaker committed -
PiperOrigin-RevId: 309389571
ibaker committed -
This mimics the behaviour of SubtitleTextView for cues that don't have alignment set. PiperOrigin-RevId: 309389392
ibaker committed -
Issue: #7309 PiperOrigin-RevId: 309387483
aquilescanta committed -
PiperOrigin-RevId: 309258505
aquilescanta committed -
PiperOrigin-RevId: 309245320
ibaker committed -
PiperOrigin-RevId: 309244671
ibaker committed -
PiperOrigin-RevId: 309244135
ibaker committed -
PiperOrigin-RevId: 309243467
ibaker committed -
PiperOrigin-RevId: 309231983
tonihei committed -
Also fix a typo in them PiperOrigin-RevId: 309221515
andrewlewis committed -
We keep an index hint for the next pending player message. This hint wasn't updated correctly when messages are removed due to a timeline update. This change makes sure to only use the hint locally in one method so that it doesn't need to be updated anywhere else and also adds the "hint" suffix to the variable name to make it clearer that it's just a hint and there are no guarantees this index actually exists anymore. issue:#7278 PiperOrigin-RevId: 309217614
tonihei committed -
This also allows subsequent MediaSource instance in the list to still be released successfully. Issue: #7168 PiperOrigin-RevId: 309202170
olly committed -
Implementors should use the new callbacks to clean up any resources associated with the corresponding LoadEventInfo ids. PiperOrigin-RevId: 309198455
aquilescanta committed -
Currently the assertOutput() overloads do quite different things. Also stop returning FakeExtractorOutput from assertOutput (it's not used). PiperOrigin-RevId: 309030386
ibaker committed -
PiperOrigin-RevId: 309022070
olly committed -
testSubtitleEventTimes/IndicesHelper make assertions that only happen to be the same because values in two different constants match up. It seems much better to explicitly put the assertions in each test. The other assert methods are just obscuring the underlying call to Truth. PiperOrigin-RevId: 309022044
ibaker committed -
Steps 4-10 of https://www.w3.org/TR/webvtt1/#cue-computed-line This part is harder to fit into our code structure because it depends on how many cues are simultaneously visible - so it has to go in WebvttSubtitle not WebvttCueParser (which only deals with individual cues in isolation). This removes the `isNormal()` method that was trying to approximate the correct behaviour. PiperOrigin-RevId: 309021686
ibaker committed -
PiperOrigin-RevId: 308999582
olly committed -
PiperOrigin-RevId: 308997845
olly committed
-