Commits · a4ad85d25a173980562621b2e7c8bd78da7209d0 · SDK / exoplayer

17 Feb, 2023 17 commits

InternalTextureManager: delete texture after use · a4ad85d2
```
PiperOrigin-RevId: 510377977
```
tofunmi committed Feb 17, 2023
a4ad85d2 Browse Files

Update demo app with image input · 7614ac47

Adds a new option to the preset file list to show an image for 5secs at 30fps. Also adds an ImageView to show the input image

PiperOrigin-RevId: 510372035

committed Feb 17, 2023

7614ac47 Browse Files

Move BoxesTest.java into muxer module · 48fca7d0

Following changes are included:
1. Move BoxesTest.java into muxer module.
2. Change test code to use dump file infra.

BoxesTest.java does not cover all the boxes implemented in Boxes.java so created a WI to track it b/269471752

PiperOrigin-RevId: 510219645

committed Feb 17, 2023

48fca7d0

HDR: Catch test util decoder support error. · 0cb5c588

Otherwise, a lack of HDR decoding support will result in the tests checking output files for HDR output, like HdrEditingTest.transform_noRequestedTranscode_hdr10File_transformsOrThrows, failing.

PiperOrigin-RevId: 510213020

committed Feb 17, 2023

0cb5c588

Remove space in exception message. · 9ca1122b
```
This space was added by mistake in a prior CL of mine.

PiperOrigin-RevId: 510157363
```
samrobinson committed Feb 17, 2023
9ca1122b Browse Files
HDR: Add comment explaining force-SDR and AssetLoader interaction. · aa7abd55
```
PiperOrigin-RevId: 510155318
```
huangdarwin committed Feb 17, 2023
aa7abd55 Browse Files

HDR: Put force HDR as SDR into AssetLoader · 7d54f244

This allows us to fix usage of HDR_MODE_EXPERIMENTAL_FORCE_INTERPRET_HDR_AS_SDR.

Before, this was checked in the VideoSamplePipeline, which no longer decides on the decoder configuration input format.

PiperOrigin-RevId: 510142097

committed Feb 17, 2023

7d54f244 Browse Files

Rename occurrences of transform in lib-transformer · 4cc5080d
```
PiperOrigin-RevId: 510118760
```
kimvde committed Feb 17, 2023
4cc5080d Browse Files

Remove Pixel watch check · 37768ed0

It's unlikely anyone will try to use Transformer on watches.

PiperOrigin-RevId: 510115645

committed Feb 17, 2023

37768ed0 Browse Files

Fix a missed rename. · f74cd7b1
```
PiperOrigin-RevId: 510100709
```
claincly committed Feb 17, 2023
f74cd7b1 Browse Files

Check capabilities for more tests · ab2cabe3

Some of the test methods in `TransformationTest` don't check
capabilities. Add a check just scoped to decoding (not checking
encoding, but the default encoder factory may fall back).

PiperOrigin-RevId: 510088562

committed Feb 17, 2023

ab2cabe3 Browse Files

Rename TransformationTest to ExportTest · 3f84c869
```
PiperOrigin-RevId: 510087543
```
kimvde committed Feb 17, 2023
3f84c869 Browse Files
Effects: Update javadoc to link to method. · 5fee7df6
```
PiperOrigin-RevId: 510077348
```
huangdarwin committed Feb 17, 2023
5fee7df6 Browse Files
Rename TransformationException to ExportException · 774b44c6
```
PiperOrigin-RevId: 510062674
```
kimvde committed Feb 17, 2023
774b44c6 Browse Files

Update instrumentation to avoid making all constructors public · 6867f566

Previously, any constructors instrumented by Robolectric were made public. This
caused two types of issues:

1) If Android classes had non-public constructors which were made public and
added to the Android API, Robolectric allowed tests to incorrectly use the
constructors on older SDK levels (where they were non-public). This most
commonly occurs for AccessibiltyEvent and AccessibilityNodeInfo.

2) When reflection was used to instantiate classes that were instrumented by
Robolectric, all constructors were accessible, which did not match what
happened when running on an Android test.

Update the instrumentation in Robolectric to prevent making all public
constructors.

PiperOrigin-RevId: 510049123

committed Feb 17, 2023

6867f566 Browse Files

Effect: Rename FrameProcessor · 413f61b9

Rename FrameProcessor to VideoFrameProcessor, and GlEffectsFrameProcessor to
DefaultVideoFrameProcessor.

Most changes are semi-mechanical, semi-manual find-replace, preserving case:
* "FrameProc" -> "VideoFrameProc" (ex. FrameProcessor -> VideoFrameProcessor, and
   FrameProcessingException -> VideoFrameProcessingException)
* "GlEffectsVideoFrameProc" -> "DefaultVideoFrameProc"

PiperOrigin-RevId: 509887384

committed Feb 17, 2023

413f61b9 Browse Files

Fix some minor nits · 3e5ae92b
```
PiperOrigin-RevId: 509879029
```
andrewlewis committed Feb 17, 2023
3e5ae92b

15 Feb, 2023 11 commits
- Update javadoc for ExoPlayer 2.18.3 · 482871fe
```
#minor-release

PiperOrigin-RevId: 509867431
```
  christosts committed Feb 15, 2023
  482871fe
- Update javadoc for ExoPlayer 2.18.3 · 19d4a588
```
#minor-release

PiperOrigin-RevId: 509864205
```
  christosts committed Feb 15, 2023
  19d4a588 Browse Directory
- Change FrameProcessor.create() inputTrackType parameter to a boolean · 5168a356
```
PiperOrigin-RevId: 509808913
```
  tofunmi committed Feb 15, 2023
  5168a356 Browse Files
- Skip tests if muxing is unsupported · 6d9baa6e
```
PiperOrigin-RevId: 509802784
```
  andrewlewis committed Feb 15, 2023
  6d9baa6e Browse Files
- Update javadoc for ExoPlayer 2.18.3 · 4759e007
```
#minor-release

PiperOrigin-RevId: 509789955
```
  christosts committed Feb 15, 2023
  4759e007 Browse Directory
- Move inputExternalSurfaceTexture to the ExternalTextureManager · f7621aac
```
Now that the GLEffectFrameProcessor handles external (video) and internal (image) input, components used only for external input needs should be moved to the ExternalTextureManager for code clarity

PiperOrigin-RevId: 509787494
```
  tofunmi committed Feb 15, 2023
  f7621aac Browse Files
- Use MediaFormatUtil for creating MediaFormat from Format. · 7497b1e0
```
PiperOrigin-RevId: 509785247
```
  samrobinson committed Feb 15, 2023
  7497b1e0 Browse Files
- Add missing import for ExoPlayer v2 codebase · 3b7cf8f0
```
Issue: google/ExoPlayer#10989
PiperOrigin-RevId: 509771687
```
  andrewlewis committed Feb 15, 2023
  3b7cf8f0 Browse Files
- Clarify the mime type used in EncoderUtilTest. · bcbe3f1f
```
PiperOrigin-RevId: 509750806
```
  samrobinson committed Feb 15, 2023
  bcbe3f1f Browse Files
- Align ASP and VSP on findSupportedMimeTypeForEncoder/Muxer logic. · d91afa06
```
* Moved the logic to SamplePipeline.
* Pass the requested values via Format.
* Moved exception throwing inside the methods.
* Build up the mimeTypesToCheck as a set - removing possible duplicate
checks.
* Simplified logic that calls the findSupportedMimeType method.
* Improved javadoc.

PiperOrigin-RevId: 509594062
```
  samrobinson committed Feb 15, 2023
  d91afa06 Browse Files
- Preserve aspect ratio when scaling resolution is insufficient. · ccd8856d
```
PiperOrigin-RevId: 509546771
```
  samrobinson committed Feb 15, 2023
  ccd8856d Browse Files
14 Feb, 2023 6 commits
- Effect: Add leading zero to decimals in floats. · ccdb3b70
```
PiperOrigin-RevId: 509518734
```
  huangdarwin committed Feb 14, 2023
  ccdb3b70 Browse Files
- Version bump for ExoPlayer 2.18.3 & media3-1.0.0-rc01 · b18dccde
```
#minor-release

PiperOrigin-RevId: 509501665
```
  christosts committed Feb 14, 2023
  b18dccde
- Fix InternalTextureManager so that all frames are sent downstream · cdd92450
```
PiperOrigin-RevId: 509478455
```
  tofunmi committed Feb 14, 2023
  cdd92450 Browse Files
- Add exception cause to thrown exception · 08cf6db3
```
PiperOrigin-RevId: 509473556
```
  Googler committed Feb 14, 2023
  08cf6db3 Browse Files
- Use ColorInfo.Builder in transformer and common. · efcb7683
```
Because the ColorInfo constructor is deprecated.

PiperOrigin-RevId: 509468663
```
  claincly committed Feb 14, 2023
  efcb7683 Browse Files
- Add error codes to reflect failures in using effects. · 33d45c3c
```
PiperOrigin-RevId: 509461955
```
  claincly committed Feb 14, 2023
  33d45c3c Browse Files
13 Feb, 2023 6 commits

Effect: Implement brightness convenience class. · f9fffc28

It can be confusing how to use RgbMatrix for app devs not comfortable with image
manipulation, so add a helper class that simply translates rgb values the same
constant brightness value, to update the brightness values.

PiperOrigin-RevId: 509287229

committed Feb 13, 2023

f9fffc28 Browse Files

Update release notes for ExoPlayer 2.18.3 · 8ff024e4
```
#minor-release

PiperOrigin-RevId: 509246479
```
christosts committed Feb 13, 2023
8ff024e4

Test: Update emulator version from 31 to 33. · 94f7d2f2

For all end-to-end tests, we currently run on a generic API 26 and newer API 31 emulator. Due to some issues on API 31, update to use an API 33 emulator.

Also, update documentation to mention issues on different emulator versions.

PiperOrigin-RevId: 509242743

committed Feb 13, 2023

94f7d2f2 Browse Files

Generalize getSupportedEncodersForHdr to return List<MediaCodecInfo>. · dcd1f6bc
```
This now matches EncoderUtil.getSupportedEncoders return type.

PiperOrigin-RevId: 509222078
```
samrobinson committed Feb 13, 2023
dcd1f6bc Browse Files
Update overlay test bitmap based on emulator output · 77e651ad
```
PiperOrigin-RevId: 509210836
```
andrewlewis committed Feb 13, 2023
77e651ad Browse Files

Catch IllegalArgumentExceptions in RTSP Response parsing · 711fa44d

In parsing Describe RTSP response messages, IllegalArgumentExceptions are thrown for invalid parameters and values. These exceptions were not caught and crashed the Playback thread. Now these exceptions will be caught and their errors forwarded to the proper error handling listeners.

#minor-release

Issue: google/ExoPlayer#10971
PiperOrigin-RevId: 509207881

committed Feb 13, 2023

711fa44d