- 20 Mar, 2019 2 commits
- 15 Mar, 2019 17 commits
-
-
When an error occurs we call stopInternal, and this clears the MediaPeriodQueue, which in turn releases media period holders and notifies that media periods have been released. AnalyticsCollector updates its information about media periods using the media period release events, which means that if we post the source error after stopInternal posts its events we can't determine what media period the source error corresponds to. Move error notifications before calling stopInternal, so that AnalyticsCollector's model of the media period queue contains the loading period at the point when it handles the error. For consistency also move the other (non-source) error notifications to match the new ordering. PiperOrigin-RevId: 238559324
andrewlewis committed -
PiperOrigin-RevId: 238442845
eguven committed -
Issue:#5572 PiperOrigin-RevId: 238401862
aquilescanta committed -
This simplifies the DownloadHelper code in the demo app and is generally useful for more specific updates with SelectionOverrides. PiperOrigin-RevId: 238228276
tonihei committed -
This replaces the deprecated usages of RobolectricTestRunner and RuntimeEnvironent and fully migrates the tests to androidx. PiperOrigin-RevId: 238011667
tonihei committed -
PiperOrigin-RevId: 238002393
eguven committed -
Now that this class can be extended, it makes sense for subclasses to be able to clear state in seek(). PiperOrigin-RevId: 237902276
andrewlewis committed -
PiperOrigin-RevId: 237900673
andrewlewis committed -
PiperOrigin-RevId: 237803831
tonihei committed -
PiperOrigin-RevId: 237772784
tonihei committed -
PiperOrigin-RevId: 237467628
tonihei committed -
We didn't read the attribute value so far. PiperOrigin-RevId: 237420697
tonihei committed -
PiperOrigin-RevId: 237416206
tonihei committed -
PiperOrigin-RevId: 237412166
Oliver Woodman committed -
PiperOrigin-RevId: 237247769
andrewlewis committed -
We may currently throw if the load completes before we finished preparation. Don't throw and instead check for this condition in maybeThrowPrepareError. PiperOrigin-RevId: 237237000
tonihei committed -
Issue: #5598 PiperOrigin-RevId: 237067179
olly committed
-
- 06 Mar, 2019 21 commits
-
-
PiperOrigin-RevId: 237052890
olly committed -
PiperOrigin-RevId: 237052069
aquilescanta committed -
This is needed now that index data may be stored outside of the cache directory. PiperOrigin-RevId: 237051112
olly committed -
These are thrown for non-IOException encountered during loading. Also, they are thrown from an unexpected position and retrying is likely to fail anyway because the Extractor is left in an unrecoverable state. PiperOrigin-RevId: 237043948
tonihei committed -
SQLiteException is a runtime exception, which makes it easy to forget to handle it. This change converts SQLiteExceptions into a checked exception, which is then handled appropriately. PiperOrigin-RevId: 237038793
olly committed -
PiperOrigin-RevId: 237028164
andrewlewis committed -
Currently a flags-only DecoderInputBuffer may hold only the end-of-stream flag. This change makes flags-only buffer read any kind of flag set in the next sample. If no sample is available RESULT_NOTHING_READ is returned. PiperOrigin-RevId: 237027581
aquilescanta committed -
PiperOrigin-RevId: 237025639
olly committed -
We currrently just inherit the acitivity's alertDialogTheme style (which is equivalent to ThemeOverlay.AppCompat.Dialog.Alert). Using the theme overlay directly and also force-enable the title such that the title is shown even if the activity disabled the title. PiperOrigin-RevId: 237012601
tonihei committed -
nalPrefix.readUnsignedIntToInt() will throw if the unsigned output doesn't fit in an int. Before this change, in the error case we'd retry reading from after the NAL prefix position. Throw a ParserException so that reading an obviously invalid NAL prefix will be treated as a fatal exception by the default load error handling policy. PiperOrigin-RevId: 236839690
andrewlewis committed -
PiperOrigin-RevId: 236805460
andrewlewis committed -
There are 6 different situations which are now more explicitly covered to ensure we handle them correctly: 1. Radio button (non-adaptive, single group only) Selected -> Do nothing. Unselected -> Replace override with selected track. 2. Check box (non-adaptive, but multi-group allowed) Selected -> Remove track (and override). If last one, set isDisabled flag. Unselected -> Replace override with selected track. 3. Check box (adaptive allowed, single or multi group) Selected -> Remove track. If last, remove override and maybe set isDisabled. Unselected -> Add track to override. PiperOrigin-RevId: 236668642
tonihei committed -
The release needs to post to the MediaSource thread and also needs to post back to the DownloadHelper thread to prevent sending updates after release has been called. The point where we release the downloadHelper also needs to dismiss the dialog in case the creation has already been queued before the release. PiperOrigin-RevId: 236652309
tonihei committed -
PiperOrigin-RevId: 236648435
aquilescanta committed -
PiperOrigin-RevId: 236645446
olly committed -
This is more in line with "forgetting all previous state" as documented for resetState=True. Also only apply the current position as initial seek position in this case. PiperOrigin-RevId: 236623630
tonihei committed -
Deduplicates a bit of code PiperOrigin-RevId: 236621851
aquilescanta committed -
We currently throw if a pending seek position was valid when the user issued it on the app thread, but can't be resolved on the playback thread because the timeline changed in the meantime. Throwing in this case seems wrong as the user could not have known about the issue (and the seek position was actually valid). Also, in other cases where the currently playing period is no longer in the new timeline, we gracefully use a subsequent period or transition to ENDED state instead of throwing. So it seems more consistent to transition to ENDED state as well. PiperOrigin-RevId: 236274862
tonihei committed -
This constants and classes are defined by the same name in the super class and thus can be safely removed. PiperOrigin-RevId: 236136197
tonihei committed -
PiperOrigin-RevId: 236133636
tonihei committed -
So far it's only enabled in the external demo app. PiperOrigin-RevId: 236122825
tonihei committed
-