- 02 Sep, 2019 20 commits
-
-
Any seek before the first timeline becomes available will result in a NPE. Change it to handle that case gracefully. Issue:#5831 PiperOrigin-RevId: 264603061
tonihei committed -
AdsMediaSource posts AdsLoader.start to the main thread during preparation, but the app may call AdsLoader.setPlayer(null) before it actually runs (e.g., if initializing then quickly backgrounding the player). This is valid usage of the API so handle this case instead of asserting. Because not calling setPlayer at all is a pitfall of the API, track whether setPlayer has been called and still assert that in AdsLoader.start. PiperOrigin-RevId: 264329632
andrewlewis committed -
https://developer.apple.com/documentation/http_live_streaming/about_the_common_media_application_format_with_http_live_streaming PiperOrigin-RevId: 264126140
ibaker committed -
PiperOrigin-RevId: 263768428
ibaker committed -
This field is used in .equals(), so it makes sense to include it in toString() too. PiperOrigin-RevId: 263768329
ibaker committed -
This matches the documentation on MetadataDecoder.decode: "@return The decoded metadata object, or null if the metadata could not be decoded." PiperOrigin-RevId: 263767144
ibaker committed -
Venkatarama NG. Avadhani committed
-
Initially this supports ID3-in-EMSG, but can also be used to support SCTE35-in-EMSG too. PiperOrigin-RevId: 263535925
ibaker committed -
entries are used in .equals(), so it's good to have them printed in toString() too (for test failures) and it makes logging easier too. PiperOrigin-RevId: 263335503
ibaker committed -
This field is used in .equals(), we should print it in toString() too PiperOrigin-RevId: 263335432
ibaker committed -
The current max video buffer is 13MB which is too small for high quality streams and doesn't allow the DefaultLoadControl to buffer up to its default max buffer time of 50 seconds. Also move util method and constants only used by DefaultLoadControl into this class. PiperOrigin-RevId: 263328088
tonihei committed -
PiperOrigin-RevId: 262886490
tonihei committed -
PiperOrigin-RevId: 262511088
andrewlewis committed -
I think we need to start clearing the holder as part of the DRM rework. When we do this, it'll only be valid to read from the holder immediately after it's been populated. PiperOrigin-RevId: 262362725
olly committed -
We're no longer tied to the emsg spec, so we can skip unused fields and assume ms for duration. Also remove @Nullable annotation from EventMessageEncoder#encode, it seems the current implementation never returns null PiperOrigin-RevId: 262135009
ibaker committed -
PiperOrigin-RevId: 262121134
ibaker committed -
We don't usually refer to other classes when documenting method parameters but rather duplicate the actual definition. PiperOrigin-RevId: 262102714
tonihei committed -
We already allow mixed mime type and mixed sample rate adaptation on request, so for completeness, we can also allow mixed channel count adaptation. Issue:#6257 PiperOrigin-RevId: 261930046
tonihei committed -
This only covers calls to scaleLargeTimestamp() PiperOrigin-RevId: 261878019
ibaker committed -
This also decouples EventMessageEncoder's serialization schema from the emesg spec (it happens to still match the emsg-v0 spec, but this is no longer required). PiperOrigin-RevId: 261877918
ibaker committed
-
- 09 Aug, 2019 1 commit
-
-
r2.10.4
Oliver Woodman committed
-
- 05 Aug, 2019 2 commits
-
-
If we keep streams in chunk sources after selecting new tracks, we also keep a reference to a stale disabled TrackSelection object. Fix this by updating the TrackSelection object when keeping the stream. The static part of the selection (i.e. the subset of selected tracks) stays the same in all cases. Issue:#6256 PiperOrigin-RevId: 261696082
tonihei committed -
Issue:#6260 PiperOrigin-RevId: 261647858
tonihei committed
-
- 02 Aug, 2019 8 commits
-
-
PiperOrigin-RevId: 261353271
olly committed -
PiperOrigin-RevId: 261341256
olly committed -
PiperOrigin-RevId: 261340526
olly committed -
PiperOrigin-RevId: 261328701
olly committed -
PiperOrigin-RevId: 261320318
olly committed -
- Test seeking to (timeUs=0, position=0), which should always work and produce the same output as initially reading from the start of the stream. - Reset the input when testing seeking, to ensure IO errors are simulated for this case. PiperOrigin-RevId: 261317898
olly committed -
- When in STATE_SEEK with targetGranule==0, seeking would exit without checking that the input was positioned at the correct place. - Seeking could fail due to trying to read beyond the end of the stream. - Seeking was not robust against IO errors during the skip phase that occurs after the binary search has sufficiently converged. PiperOrigin-RevId: 261317035
olly committed -
A previous change switched to calculation of the bitrate based on the first MPEG audio header in the stream. This had the effect of fixing seeking to be consistent with playing from the start for streams where every frame has the same padding value, but broke streams where the encoder (correctly) modifies the padding value to match the declared bitrate in the header. Issue: #6238 PiperOrigin-RevId: 261163904
andrewlewis committed
-
- 01 Aug, 2019 9 commits
-
-
Oliver Woodman committed
-
Issue: #6241 PiperOrigin-RevId: 261126968
olly committed -
PiperOrigin-RevId: 260970865
olly committed -
They're not unexpected! PiperOrigin-RevId: 260907687
olly committed -
PiperOrigin-RevId: 244173887
andrewlewis committed -
Issue: #5938 PiperOrigin-RevId: 261150349
olly committed -
Android considers ALAC initialization data to consider of the magic cookie only, where-as FFmpeg requires a full atom. Standardize around the Android definition, since it makes more sense (the magic cookie being contained within an atom is container specific, where-as the decoder shouldn't care what container the media stream is carried in) Issue: #5938 PiperOrigin-RevId: 261124155
olly committed -
PiperOrigin-RevId: 261102180
olly committed -
PiperOrigin-RevId: 261102008
olly committed
-