- 03 Dec, 2020 26 commits
-
-
The old tag reflects the original name of this class. It was renamed in 2017: <unknown commit> Possibly the old name was kept for compatibility with existing logs analysis? I didn't see an explicit discussion of this in the review comments of the rename change. The current tag confused me slightly - I assumed a line was being emitted by the android.media.AudioTrack rather than ExoPlayer's DefaultAudioSink. PiperOrigin-RevId: 345450056
ibaker committed -
PiperOrigin-RevId: 345442367
olly committed -
Issue: #5011 PiperOrigin-RevId: 345440697
bachinger committed -
This will mean the track is automatically used when running in a playback test. Command used to change the flag: ``` $ mkvpropedit sample_with_srt.mkv --edit track:3 --set flag-default=1 ``` PiperOrigin-RevId: 345436666
ibaker committed -
This is currently flaky, so it's better to disable it than end up with flaky tests. PiperOrigin-RevId: 345436319
ibaker committed -
PiperOrigin-RevId: 345428731
Oliver Woodman committed -
Issue: #5011 PiperOrigin-RevId: 345425048
bachinger committed -
Migrate all classes that are simple to move to common. #player-to-common PiperOrigin-RevId: 345412080
krocard committed -
The `AudioProcessor` interface requires that no more input is queued after queueing end of stream, but `DefaultAudioSink` did queue more input and the implementation of `SonicAudioProcessor` actually relied on this to drain output at the end of the stream. Fix this behavior by getting `Sonic` output in `getOutput` and having `DefaultAudioSink` only queue input to processors that are not draining. Also add TODOs to clean up audio processor implementations where the code handles interaction that doesn't conform to the interface. PiperOrigin-RevId: 345406478
andrewlewis committed -
PiperOrigin-RevId: 345398603
krocard committed -
As Player depends on VideoScalingMode, and Renderer should not move to common, to move Player to common, VideoScalingMode needs to move first. #player-to-common PiperOrigin-RevId: 345314448
krocard committed -
Issue: #5011 PiperOrigin-RevId: 345275266
bachinger committed -
Asset generated using a temporary SSA file and: ``` $ mkvmerge -o sample_with_ssa_subtitles.mkv sample.mkv input.ssa ``` PiperOrigin-RevId: 345217628
ibaker committed -
PiperOrigin-RevId: 345202157
Oliver Woodman committed -
PiperOrigin-RevId: 345198316
olly committed -
Update StyledPlayers control overlay scrim from 30% opacity to 60% opacity for Accessibility requirements. PiperOrigin-RevId: 345190774
olly committed -
This allows overriding the implementation of building the UrlRequest from dataSpec when necessary PiperOrigin-RevId: 345149165
olly committed -
PiperOrigin-RevId: 345036042
olly committed -
Changes MetadataRetriever and Transformer so that their respective tests don't need to manually control the SystemClock in order to execute taks posted with delay from Loader. PiperOrigin-RevId: 345024140
christosts committed -
Low latency streams potentially need to remove preload chunks in case they are removed from the playlist. Hence we need to schedule loading the next playlist even if the playlist is not a primary playlist. Issue: #5011 PiperOrigin-RevId: 344995891
bachinger committed -
See https://checkerframework.org/manual/#type-refinement-purity. PiperOrigin-RevId: 344994705
andrewlewis committed -
Previously `MediaPeriodQueue` would return null if an ad media URI hadn't loaded yet, but this meant that the player could be stuck in `STATE_READY` if an `AdsLoader` unexpectedly didn't provide an ad URI. Fix this behavior by masking ad media periods. `MaskingMediaPeriod` no longer requires a `MediaSource` to instantiate it. This also fixes a specific case where playback gets stuck when using the IMA extension with an empty ad where the IMA SDK unexpectedly doesn't notify the ad group fetch error. Issue: #8205 PiperOrigin-RevId: 344984824
andrewlewis committed -
This is to ensure we can still discard the data if needed. Issue: #5011 PiperOrigin-RevId: 344977548
tonihei committed -
#exofixit PiperOrigin-RevId: 344845328
ibaker committed -
PiperOrigin-RevId: 344838400
samrobinson committed -
This change avoids an early fatal exception for replaced hinted parts. Issue: #5011 PiperOrigin-RevId: 344828076
bachinger committed
-
- 30 Nov, 2020 13 commits
-
-
PiperOrigin-RevId: 344801462
ibaker committed -
This is needed to support old binary builds that still rely on the existance of this class. PiperOrigin-RevId: 344799495
tonihei committed -
PiperOrigin-RevId: 344787160
tonihei committed -
Broken in https://github.com/google/ExoPlayer/commit/bf21e3c690cfbab6cdbb76b3dd6e353f7221b3f1. PiperOrigin-RevId: 344777455
aquilescanta committed -
The inner class was only used to obtain 3 distinct pieces of information which is better handled by static methods. #exofixit PiperOrigin-RevId: 344767661
tonihei committed -
#player-to-common PiperOrigin-RevId: 344558028
krocard committed -
PiperOrigin-RevId: 344535069
olly committed -
PiperOrigin-RevId: 344526343
andrewlewis committed -
As opposed to in-source git-clone. PiperOrigin-RevId: 344525899
aquilescanta committed -
#exofixit PiperOrigin-RevId: 344517105
andrewlewis committed -
#exofixit PiperOrigin-RevId: 344516187
samrobinson committed -
This copy will be removed once Player is migrated to common. #exo-offload PiperOrigin-RevId: 344515979
krocard committed -
This method should be assumed to clear the data of the underlying array (it will do this if the new limit > data.length). This means it should only be called (directly) before writing into the backing array. It shouldn't be used as a shorthand for position=0, limit=x - those should be two explicit method calls. Most of these changes are no-ops, but they make the code more correct. The TS SectionReader can't be easily changed to be 'safe', because it relies on sectionData maintaining state between iterations of the while loop. Instead I've added comments justifying the existing code. PiperOrigin-RevId: 344515340
ibaker committed
-
- 27 Nov, 2020 1 commit
-
-
The workaround to post a message was needed to ensure we receive any final onIsPlayingChanged event before the test is finished (to record the correct playing time). Using onEvents allows us to do this synchronously as the callback guarantees that there is no other pending event. #exofixit PiperOrigin-RevId: 344436180
tonihei committed
-