Commits · 93f2dd8deb5ed3f64985a8e9a3b1ce3d9b22ce8a · SDK / exoplayer

30 Oct, 2019 2 commits

Switch test usages of ConditionVariable#block(timeout) to CountDownLatch · 93f2dd8d

ConditionVariable.block(timeout) doesn't work in Robolectric, because it
relies on the system clock which doesn't advance.

PiperOrigin-RevId: 275798281

committed Oct 30, 2019

93f2dd8d

Fix NPE in FakeAdaptiveMediaPeriod. · 4e667b89

The compositeSequenableLoader was causing NPEs in isLoading. Initializing it
upfront prevents this problem and is in line with what we do in all real
MediaPeriods.

PiperOrigin-RevId: 275491511

committed Oct 30, 2019

4e667b89

18 Oct, 2019 12 commits

Added an ICY header workaround for unseekable MP3 streams. · 694ccf42
```
Issue:#6537
PiperOrigin-RevId: 275477266
```
samrobinson committed Oct 18, 2019
694ccf42
Remove HlsSampleStreamWrapper from the null checking blacklist · b7f335c7
```
PiperOrigin-RevId: 275440589
```
ibaker committed Oct 18, 2019
b7f335c7 Browse Files

Remove HLS WebVttExtractor from null-checking blacklist · 13178515

The null-checker wasn't clever enough to understand the while-loop was safe
so I switched it to a for.

PiperOrigin-RevId: 275440464

committed Oct 18, 2019

13178515 Browse Files

Minor CastPlayer Javadoc cleanup · 3150591b
```
PiperOrigin-RevId: 275439892
```
olly committed Oct 18, 2019
3150591b Browse Files

Demo app: Do not allow tunneling on API < 21 · 6841d40b

Without this patch, enabling tunneling on an API < 21 device
would result in an method not existing exception and the
app would crash.

PiperOrigin-RevId: 275428851

committed Oct 18, 2019

6841d40b Browse Files

Replace @MonotonicNonNull with @Nullable for final variables. · 16a6946f

@MonotonicNonNull is not useful if the variable is final, because it's only
assigned once and guaranteed to keep it's current nullability in the same
way as @MonotonicNonNull ensures it's kept non-null after checking.

This way, the workarounds can also be removed.

PiperOrigin-RevId: 275428656

committed Oct 18, 2019

16a6946f Browse Files

Don't propagate empty supplemental data · 39d5f143
```
PiperOrigin-RevId: 275425267
```
andrewlewis committed Oct 18, 2019
39d5f143 Browse Files
Rollback of https://github.com/google/ExoPlayer/commit/9f0fd870e7c82d703ec0957ac47bb971aa763956 · 701b013c
```
*** Original commit ***

Port Exo v1 work around for frame synchronization issue in KitKat to Exo v2.

***

PiperOrigin-RevId: 275372272
```
olly committed Oct 18, 2019
701b013c Browse Files

Refactor GlViewGroup to ViewRenderer · 64786c6c

GlViewGroup doesn't work properly as an actual ViewGroup. For example,
it doesn't support addition of child views after instantiation. This
change turns the class into a renderer, which is also more consistent
with other classes in the package.

PiperOrigin-RevId: 275322295

committed Oct 18, 2019

64786c6c Browse Files

Fail at preparation when trying to download live content. · 0c0a67bb
```
PiperOrigin-RevId: 275293735
```
bachinger committed Oct 18, 2019
0c0a67bb

Rollback of https://github.com/google/ExoPlayer/commit/4ad4e3e4fcf2480bc36e7034026a3538ec7664be · 36f8bd78

*** Original commit ***

Rollback of https://github.com/google/ExoPlayer/commit/3b22db33ba944df6829b1eff328efb0cd25e1678

*** Original commit ***

add top-level playlist API to ExoPlayer

Public design doc:
https://docs.google.com/document/d/11h0S91KI5TB3NNZUtsCzg0S7r6nyTnF_tDZZAtmY93g

Issue: #6161

***

***

PiperOrigin-RevId: 275276158

committed Oct 18, 2019

36f8bd78

Remove HlsMediaSource from null-checking blacklist · 9ec2d2fb
```
PiperOrigin-RevId: 275233915
```
ibaker committed Oct 18, 2019
9ec2d2fb Browse Files

17 Oct, 2019 3 commits

Round impossible H264 resolutions up to valid values for capabilities check · d874656e

If an odd resolution is impossible in the specification itself, then we know
that the caller is passing invalid data. Round up on the assumption it's a
rounding error so that playback can proceed.

Issue: #6551
PiperOrigin-RevId: 275226813

committed Oct 17, 2019

d874656e Browse Files

Introduce tunneling checkbox in test app · 9af8511a

It makes observing differences without and with tunneling
much faster than recompiling.

PiperOrigin-RevId: 275216567

committed Oct 17, 2019

9af8511a Browse Files

Remove HlsMasterPlaylist from null-checking blacklist · 0d5b3c0f
```
PiperOrigin-RevId: 275052534
```
ibaker committed Oct 17, 2019
0d5b3c0f Browse Files

16 Oct, 2019 3 commits
- Merge pull request #6528 from julioz:log-param · 23f545a0
```
PiperOrigin-RevId: 275014741
```
  Oliver Woodman committed Oct 16, 2019
  23f545a0 Browse Files
- Add AUDIO_BECOMING_NOISY handling to SimpleExoPlayer. · 841b3a8b
```
Feature enabled through the SimpleExoPlayer.setHandleAudioBecomingNoisy.

PiperOrigin-RevId: 274988924
```
  samrobinson committed Oct 16, 2019
  841b3a8b Browse Files
- Add HlsSampleStreamWrapper#assertPreparationComplete · e63d3b4b
```
This gives a clear way to ensure all the preparation-related @MonotonicNonNull
fields have been set to something.

PiperOrigin-RevId: 274988280
```
  ibaker committed Oct 16, 2019
  e63d3b4b Browse Files
15 Oct, 2019 14 commits

Align PlaybackSuppressionReason java doc with method doc. · 03e3ceae

Same change as done in https://github.com/google/ExoPlayer/commit/c49388aca2047ed7680e7d8834def4f769060e2d.

PiperOrigin-RevId: 274894288

committed Oct 15, 2019

03e3ceae Browse Files

Make GvrPlayerActivity call its subclass to instantiate a player · 7dede17d
```
It's more explicit and simpler than having the subclass call up into
the activity.

PiperOrigin-RevId: 274881350
```
olly committed Oct 15, 2019
7dede17d Browse Files
Remove dead code · a2900992
```
PiperOrigin-RevId: 274848191
```
olly committed Oct 15, 2019
a2900992 Browse Files
Clean up GvrPlayerActivity · 5e538a2a
```
PiperOrigin-RevId: 274845045
```
olly committed Oct 15, 2019
5e538a2a Browse Files
Remove filter for intents that aren't handled · 34c53176
```
PiperOrigin-RevId: 274834663
```
olly committed Oct 15, 2019
34c53176 Browse Files
Set isLive flag in CastTimeline based on MediaInfo. · a95f0643
```
Issue:#2668
PiperOrigin-RevId: 274793644
```
tonihei committed Oct 15, 2019
a95f0643 Browse Files
Remove HlsChunkSource from null-checking blacklist · fc95d07a
```
PiperOrigin-RevId: 274789337
```
ibaker committed Oct 15, 2019
fc95d07a Browse Files

Break the inheritance of FullSegmentEncryptionKeyCache · 0ba91811

Use composition instead.

This makes the null-handling more explicit & complete (previous implementation
tried to prevent null values, but didn't override all mutation methods
e.g. replace(), putIfAbsent() etc.)

PiperOrigin-RevId: 274778513

committed Oct 15, 2019

0ba91811 Browse Files

Improve ffmpeg build instructions · f133766b

- Simplify the supported formats configuration by moving it to a
  separate variable, therefore avoiding updating the COMMON_OPTIONS
  variable in the ffmpeg build command.
- Move the ffmpeg build command to a shell script.

PiperOrigin-RevId: 274778232

committed Oct 15, 2019

f133766b

Fix test coverage failure for G3 exoplayer · bc75b990

Generates a manifest to have Google3InstrumentationTestRunner in order to fix the error in Zapfhahn (service to measure test coverage)

PiperOrigin-RevId: 274754720

committed Oct 15, 2019

bc75b990

Enable setOutputSurfaceWorkaround for some devices · a10fea30
```
The corresponding devices are Wiko FEVER l5460 and Huawei Honor 8X.

Issue:#6503
PiperOrigin-RevId: 274753710
```
kimvde committed Oct 15, 2019
a10fea30 Browse Files

Rollback of https://github.com/google/ExoPlayer/commit/fdfe631850908e1e4b8641d5ef2f084a39f2347d · 3eea7970

*** Original commit ***

Remove null-ness of muxedCaptionFormats list

Pre-work for removing HlsMasterPlaylist and HlsPlaylistParser from null-checking
blacklist.

***

PiperOrigin-RevId: 274591502

committed Oct 15, 2019

3eea7970 Browse Files

Remove null-ness of muxedCaptionFormats list · fdfe6318

Pre-work for removing HlsMasterPlaylist and HlsPlaylistParser from null-checking
blacklist.

PiperOrigin-RevId: 274585117

committed Oct 15, 2019

fdfe6318 Browse Files

disable download button for live content in demo app · ce625215
```
PiperOrigin-RevId: 274585052
```
bachinger committed Oct 15, 2019
ce625215 Browse Files

14 Oct, 2019 6 commits
- Fix diverged root build.gradle files · c32ad60e
```
PiperOrigin-RevId: 274568961
```
  olly committed Oct 14, 2019
  c32ad60e Browse Files
- Register cast module · c996391b
```
PiperOrigin-RevId: 274568660
```
  aquilescanta committed Oct 14, 2019
  c996391b Browse Files
- Remove HlsMediaChunk from null-checking blacklist · e670b1d0
```
PiperOrigin-RevId: 274566133
```
  ibaker committed Oct 14, 2019
  e670b1d0 Browse Files
- Fix broken Javadoc · d36abf96
```
PiperOrigin-RevId: 274564800
```
  olly committed Oct 14, 2019
  d36abf96
- Clean up playback suppression · c49388ac
```
PiperOrigin-RevId: 274561876
```
  olly committed Oct 14, 2019
  c49388ac Browse Files
- Add a Util.nullSafeArrayAppend and use it in HlsSampleStreamWrapper · eb677eb4
```
I could do this with nullSafeArrayConcat but this saves allocating a throw-away
single-element array.

PiperOrigin-RevId: 274545815
```
  ibaker committed Oct 14, 2019
  eb677eb4 Browse Files