- 21 Feb, 2022 34 commits
-
-
PiperOrigin-RevId: 426953267
Ian Baker committed -
#minor-release PiperOrigin-RevId: 426938026
ibaker committed -
Some strings didn't mention the context in which they are used (for example as item in a list, or for accessibility). This makes it harder for translators to choose the most appropriate translation and grammar. Also fix repeat and shuffle mode button accessibility descriptions to indicate the action, not the current state. PiperOrigin-RevId: 426924163
tonihei committed -
#minor-release PiperOrigin-RevId: 426909957
ibaker committed -
PiperOrigin-RevId: 426892085
olly committed -
PiperOrigin-RevId: 426876984
olly committed -
These were missed in https://github.com/google/ExoPlayer/commit/3bb0210d229ffd1455d546fa738dfebbac50f552 #minor-release PiperOrigin-RevId: 426872386
ibaker committed -
#minor-release PiperOrigin-RevId: 426870114
ibaker committed -
#minor-release PiperOrigin-RevId: 426868933
ibaker committed -
This class is deprecated (and will be removed from media3). #minor-release PiperOrigin-RevId: 426860018
ibaker committed -
PiperOrigin-RevId: 426855255
ibaker committed -
This ensures Kotlin usages of these IntDef annotations in the 'old' position will continue to compile. 'Frequently used' is a subjective judgement. I have a parallel change that marks all the other public IntDefs in the library as TYPE_USE (those that I've judged to be 'rarely used' by apps). A follow-up change will fix the positions of existing usages to be as if they're only TYPE_USE. #minor-release PiperOrigin-RevId: 426427334
ibaker committed -
This is a breaking change if the annotation itself is in use in Kotlin code. It's judged that the IntDefs in this commit are unlikely to be referred to often in Kotlin code. This is because they're either: - Related to esoteric parts of the library, or - In a common part of the library but only returned from methods (and never passed to callback methods). A follow-up change will fix the positions of existing usages to match this new config. #minor-release PiperOrigin-RevId: 426410237
ibaker committed -
#minor-release PiperOrigin-RevId: 426410137
ibaker committed -
This is not backwards compatible if the @SelectionReason annotation is used in Kotlin code, but before this change there aren't many library surfaces that return a value annotated with @SelectionReason, so it seems relatively unlikely that it is in use in any/many apps. A follow-up change will fix the positions of existing usages to match this new config. #minor-release PiperOrigin-RevId: 426409877
ibaker committed -
This is only used inside AudioFocusManager, it doesn't need to public. Also mark it TYPE_USE and update the position to match. #minor-release PiperOrigin-RevId: 426407790
ibaker committed -
This is only used in DefaultAudioSink, so we could move it there and make it private - but at that point we might as well refer to the underlying AudioManager constants instead. #minor-release PiperOrigin-RevId: 426407661
ibaker committed -
Keep values related to LegacyPlayerView in attrs_legacy_player_view.xml and put all values related to LegacyPlayerControlView back in their original locations. We plan to remove LegacyPlayerView (and attrs_legacy_player_view.xml) from media3, but will keep LegacyPlayerControlView - so the separation of the XML files needs to reflect this split. #minor-release PiperOrigin-RevId: 426406973
ibaker committed -
#minor-release Issue: google/ExoPlayer#9939 PiperOrigin-RevId: 426394339
olly committed -
This only changes IntDefs that cannot be used by apps because they're either private or package-private. A follow-up change will fix the positions of existing usages to match this new config. #minor-release PiperOrigin-RevId: 426372273
ibaker committed -
This makes the delegation model more explicit, and prevents the javadoc compiler from just pulling in the Player javadoc automatically - which can lead to some confusion when some method definitions in Player depend on other methods (e.g. seekForward() is defined in terms of getSeekForwardIncrement()). Issue: google/ExoPlayer#9897 #minor-release PiperOrigin-RevId: 426359004
ibaker committed -
These were messed up in https://github.com/google/ExoPlayer/commit/74c6ef9ba096fe64e767a739b97debca5185a375 Also suppress deprecation warnings when we're just forwarding a deprecated method to the delegate. #minor-release PiperOrigin-RevId: 426351791
ibaker committed -
This type is still known as PlayerView in exoplayer2 #minor-release PiperOrigin-RevId: 426348286
ibaker committed -
This allows us to remove the IMA naming from DefaultMediaSourceFactory's SSAI integration. #minor-release PiperOrigin-RevId: 426346456
ibaker committed -
The longer list of targets is only necessary for backwards compatibility with existing Kotlin code that will stop compiling if the position of the annotation becomes 'wrong' by marking it only TYPE_USE. Since none of these IntDefs have been released (except in media3 alpha1) we don't need to maintain this compatibility. Also add a comment to all the places that *do* need the longer list of targets, in order to explain why it's there and discourage copy-pasting when defining new IntDefs in future. Also fix some single-element arrays to remove the array notation. #minor-release PiperOrigin-RevId: 426108537
ibaker committed -
Remove most of the customisation documentation, since StyledPlayerView isn't really designed to be customised as deeply as PlayerView. Also remove most documentation around StyledPlayerControlView, especially as a standalone controller class - since it doesn't work well for this use-case. #minor-release PiperOrigin-RevId: 426090762
ibaker committed -
PiperOrigin-RevId: 426089165
tonihei committed -
PiperOrigin-RevId: 425874534
ibaker committed -
This allows the same DefaultMediaSourceFactory instance to be used as the contentMediaSourceFactory inside ImaServerSideAdInsertionMediaSource. PiperOrigin-RevId: 425846609
ibaker committed -
#minor-release PiperOrigin-RevId: 425842813
bachinger committed -
This makes SimpleExoPlayer a simple forwarding wrapper which can be removed in the future. The changes are all purely mechanical with none of the potential further simplifications made yet. The only exceptions are name clashes where either EPI or SEP was calling a method in one of the classes and both classes had different implementations for the same method name. In these cases we needed to disambiguate between the two different implementations (example: ExoPlayerImpl.setListener was renamed to setEventListener). #minor-release PiperOrigin-RevId: 425823095
tonihei committed -
Tested by confirming transformations still work and write to a output file in a scoped-storage directory on a: * Nexus 6P API 23 emulator * Google Pixel 4 API 31 physical device PiperOrigin-RevId: 425644266
huangdarwin committed -
On devices with a smaller screen / low resolution not all options fit, so scrolling is needed. PiperOrigin-RevId: 425635224
hschlueter committed -
More info: go/immutable-map-buildorthrow-lsc NOTE: if the source of truth for this code is *NOT* `third_party`, please let me know and I'll revert this CL (and please consider upstreaming this change yourself). #inlineme Tested: TAP for global presubmit queue passed after automated deflaking of failures: http://mondo/deflaker/run/530857d2-45cb-4069-a234-48c5efe945f1 http://mondo/deflaker/run/0dce4296-e6bb-42d2-8b64-b393f45b6ad3 http://test/OCL:425453729:BASE:425451020:1643699365244:811c1a24 PiperOrigin-RevId: 425616165olly committed
-
- 18 Feb, 2022 4 commits
-
-
In some cases we create empty playback metrics with no corresponding events (e.g. when an app seeks to a new media item and immediately releases the player). There is no benefit in having completely empty metrics entries, so it's cleaner to not report them in such cases. #minor-release PiperOrigin-RevId: 425609010
tonihei committed -
#minor-release PiperOrigin-RevId: 425589448
bachinger committed -
- Add a checkbox in the demo app to enable experimental HDR editing. - Add an `experimental_` method to `TransformationRequest` to enable HDR editing. - Add fragment/vertex shaders for the experimental HDR pipeline. The main difference compared to the existing shaders is that we sample from the decoder in YUV rather than RGB (because the YUV -> RGB conversion in the graphics driver is not precisely defined, so we need to do this to get consistent results), which requires the use of ES 3, and then do a crude YUV -> RGB conversion in the shader (ignoring the input color primaries for now). - When HDR editing is enabled, we force using `FrameEditor` (no passthrough) to avoid the need to select another edit operation, and use the new shaders. The `EGLContext` and `EGLSurface` also need to be set up differently for this path. PiperOrigin-RevId: 425570639
andrewlewis committed -
Issue: google/ExoPlayer#8213 #minor-release PiperOrigin-RevId: 425381474
ibaker committed
-
- 17 Feb, 2022 1 commit
-
-
This class is not ready to be released, and only exists in the dev-v2 branch.
Ian Baker committed
-
- 01 Feb, 2022 1 commit
-
-
TransformerTest sounds like a unit test for Transformer but these tests test behaviour that involves multiple stages of the pipeline. PiperOrigin-RevId: 425378369
hschlueter committed
-