- 13 Oct, 2020 20 commits
-
-
This allows a LoadControl to start playback earlier if the target live offset is very low. Issue: #4904 PiperOrigin-RevId: 336863824
christosts committed -
Issue: #4904 PiperOrigin-RevId: 336841791
christosts committed -
Issue: #4904 PiperOrigin-RevId: 336841049
christosts committed -
Use default implementation otherwise and forward chosen implementation to internal player. Issue: #4904 PiperOrigin-RevId: 336840530
christosts committed -
Issue: #4904 PiperOrigin-RevId: 336839908
christosts committed -
Issue: #4904 PiperOrigin-RevId: 336839370
christosts committed -
Issue: #4904 PiperOrigin-RevId: 336838559
christosts committed -
PiperOrigin-RevId: 336838201
olly committed -
1. The first time the player controls are are made visible, there is no animation. 2. The first time the player controls are made visible, the "select tracks" button isn't displayed. When tapping to subsequently hide the player controls, the button briefly becomes visible and then is hidden again. This bug is due to state in StyledPlayerControlViewLayoutManager being out of sync, resulting in StyledPlayerControlView's onVisibilityChange not being called properly. After this change both of these issues should be resolved. PiperOrigin-RevId: 336704031
olly committed -
This should fix gradle errors like: "warn: removing resource com.google.android.exoplayer2.demo:string/exo_controls_fastforward_by_amount_description without required default value." PiperOrigin-RevId: 336670827
andrewlewis committed -
We stopped using using this MIME type in https://github.com/google/ExoPlayer/commit/74a9d8f680995f2096c59fde6cd1ef6e85bb4d55 This broke subtitle decoding in some cases (Issue: #7985), which I fixed in https://github.com/google/ExoPlayer/commit/7b8895d655c9b48e042f66045bc9c7ab27e93346. After some discussion we've decided SubtitleDecoderFactory shouldn't depend on Format.containerMimeType (since the samples have already been extracted by this point, so the container shouldn't matter). So this change fixes DashManifestParser to use MimeTypes.APPLICATION_MP4VTT (and reverts the no-longer-needed SubtitleDecoderFactory change). PiperOrigin-RevId: 336668450
ibaker committed -
PiperOrigin-RevId: 336643621
ibaker committed -
TestExoPlayerBuilder can be used from both emulator and robolectric tests, TestPlayerRunHelper uses Robolectric Looper behaviour, meaning it can be moved to the robolectricutils module in a follow-up change. PiperOrigin-RevId: 336634225
ibaker committed -
PiperOrigin-RevId: 336558226
bachinger committed -
All these methods have been deprecated since at least 2.9.0. PiperOrigin-RevId: 336320219
tonihei committed -
Adjusted the bottom layout of StyledPlayerControlView : - Enlarged bottom button's height to make tapping easier. - Extended greyed background area to upper edge of seekbar. - Gave padding between bottom edge of the overall layout and bottom buttons. - Reduced horizontal margins between bottom buttons. PiperOrigin-RevId: 336041160
insun committed -
Previously, the overflow button was always shown at the bottom in StyledPlayerControlView and hided the settings cog even when there is enough space. With this change, the settings cog moves out from overflow and the overflow button is shown only when the buttom space is not enough. PiperOrigin-RevId: 336029179
insun committed -
Otherwise, some extractor tests are seeking without making sure that the extractor has retrieved the formats. This is needed for PR Issue: #7378. PiperOrigin-RevId: 335934326
kimvde committed -
Issue: #8024 PiperOrigin-RevId: 335846035
bachinger committed -
The bug affects playlists that start with an I-FRAME only variant. Issue: #8025 PiperOrigin-RevId: 335819497
aquilescanta committed
-
- 06 Oct, 2020 19 commits
-
-
PiperOrigin-RevId: 335683390
andrewlewis committed -
Experiments showed the timeout is beneficial to avoid ANRs and we can thus enable the feature by default. Also add configuration to set the timeout if required. Issue: #5887 PiperOrigin-RevId: 335652506
tonihei committed -
PiperOrigin-RevId: 335642909
andrewlewis committed -
Using a timeout prevents ANRs in cases where the underlying platform gets blocked forever, so we enable this feature by default. Issue: #4352 PiperOrigin-RevId: 335642485
tonihei committed -
Issue: #8005 PiperOrigin-RevId: 335625992
kimvde committed -
This is in preparation for supporting playlists of ads media sources using ImaAdsLoader. Existing ways of passing ad tags should still function but are deprecated (and won't be supported with playlists). Issue: #3750 PiperOrigin-RevId: 335618364
andrewlewis committed -
Context: Issue: #7988 PiperOrigin-RevId: 335608610
kimvde committed -
Issue:#7266 PiperOrigin-RevId: 335416280
samrobinson committed -
Issue: #7944 PiperOrigin-RevId: 335012643
andrewlewis committed -
PiperOrigin-RevId: 334801561
bachinger committed -
Without this, depending on Robolectric 4.5 causes compilation failures. PiperOrigin-RevId: 334795155
ibaker committed -
This will be used to read ads responses out of data: URLs in a subsequent change. PiperOrigin-RevId: 334778780
andrewlewis committed -
`subtitle` is only guaranteed to be non-null if `nextSubtitleEventIndex != C.INDEX_UNSET`. The null check added in https://github.com/google/ExoPlayer/commit/0efec5f6c12a5d583f24c122fbcbc1b1eebbabc3 was too early. Issue: #8017 PiperOrigin-RevId: 334777742
ibaker committed -
PiperOrigin-RevId: 334771927
ibaker committed -
This was broken by https://github.com/google/ExoPlayer/commit/74a9d8f680995f2096c59fde6cd1ef6e85bb4d55 because DashManifestParser switched to setting Format.sampleMimeType to text/vtt while SubtitleDecoderFactory was still expecting application/x-mp4-vtt. This change teaches SubtitleDecoderFactory to check both Format.containerMimeType and Format.sampleMimeType. I'll investigate a follow-up change to remove MimeTypes.APPLICATION_MP4VTT completely (it's currently still used in AtomParsers). Issue: #7985 PiperOrigin-RevId: 334771672
ibaker committed -
In the test, a real instance of SimpleExoplayer plays two identical Mp3 files. The GaplessMp3Decoder will write randomized data to decoder output on receiving input. The test compares the bytes written by the decoder with the bytes received by the AudioTrack, to verify that the trimming of encoder delay/ padding is correctly carried out. Test mp3 has delay 576 frames and padding 1404 frames. File generated from: ffmpeg -f lavfi -i "sine=frequency=1000:duration=1" test.mp3 This change needs robolectric version 4.5, which is not currently released (2020 Sep 30). PiperOrigin-RevId: 334648486
claincly committed -
This holds shared test infrastructure that needs to depend on Robolectric. PiperOrigin-RevId: 334604041
ibaker committed -
When I moved ParsableByteArray#data behind a getter I replaced some assignments with calls to reset(byte[]): https://github.com/google/ExoPlayer/commit/ce2e6e2fd625db787b1f400614adcd7458144bbd reset(byte[]) deliberately sets `limit` to `data.length`, in order to handle cases that were reassigning `data` but not updating `limit`. However OggPacket was already using `limit` to track where to write 'new' data into the array, so changing `limit` to `data.length` caused us to try and write new data beyond the end of the array. I looked at other uses of reset(byte[]) in https://github.com/google/ExoPlayer/commit/ce2e6e2fd625db787b1f400614adcd7458144bbd and condluded the only other usage in MatroskaExtractor is legit and shouldn't be updated like this (because MatroskaExtractor previously *wasn't* correctly updating/maintaining `limit`). Issue: #7992 PiperOrigin-RevId: 334601586
ibaker committed -
PiperOrigin-RevId: 334580007
christosts committed
-
- 30 Sep, 2020 1 commit
-
-
PiperOrigin-RevId: 334567234
andrewlewis committed
-