Commits · 865e0148779f277b99ffa217362cb46343f16966 · SDK / exoplayer

17 Jan, 2020 40 commits
- PlayerTrackEmsgHandler: Release sample queue in release() · 865e0148
```
This change makes it clear the SampleQueue doesn't outlive
the wrapping PlayerTrackEmsgHandler, and releases it from
PlayerTrackEmsgHandler.release().

This change is a no-op because calling release() is the
same as reset() in this case (the behavior only differs if
a non-dummy DrmSessionManager is being used).

PiperOrigin-RevId: 289416622
```
  olly committed Jan 17, 2020
  865e0148 Browse Files
- Split HlsSampleStreamWrapper.init into two methods · cebad350
```
As a result, onMediaChunkLoadStarted gets invoked on the loading thread, and
init on the playback thread, matching the thread access comments.

Issue:#6321
PiperOrigin-RevId: 289167981
```
  aquilescanta committed Jan 17, 2020
  cebad350 Browse Files
- Merge pull request #6797 from DolbyLaboratories:dev-v2-ac4-drm · 2902452b
```
PiperOrigin-RevId: 289092332
```
  Oliver Woodman committed Jan 17, 2020
  2902452b Browse Files
- Add tests to validate FLAC decoder output · ca11e56f
```
PiperOrigin-RevId: 289091494
```
  olly committed Jan 17, 2020
  ca11e56f
- Add favicon to javadocs. b/145393567 · f4271f55
```
PiperOrigin-RevId: 289054937
```
  olly committed Jan 17, 2020
  f4271f55 Browse Files
- Avoid OMX.qti.audio.decoder.flac · 91d94054
```
Unfortunately devices such as the MI 8 do not provide an alternative
working decoder. Some Vivo devices do provide one though.

PiperOrigin-RevId: 288911897
```
  olly committed Jan 17, 2020
  91d94054 Browse Files
- Fix extension FLAC decoder to correctly handle non-16-bit depths · 4e767faa
```
PiperOrigin-RevId: 288860159
```
  olly committed Jan 17, 2020
  4e767faa Browse Files
- Resolve TrueHD spec TODO · b35499f8
```
PiperOrigin-RevId: 288855515
```
  andrewlewis committed Jan 17, 2020
  b35499f8 Browse Files
- Merge pull request #6836 from DolbyLaboratories:dev-v2-refineAC4 · 91d2d8b4
```
PiperOrigin-RevId: 288772277
```
  Oliver Woodman committed Jan 17, 2020
  91d2d8b4 Browse Files
- FlacExtractor: add condition for zero-length reads · 42897b26
```
This improves readability by making clearer that reading no bytes from
the input in readFrames() is an expected case if the buffer is full.

PiperOrigin-RevId: 288711841
```
  kimvde committed Jan 17, 2020
  42897b26 Browse Files
- Disable chronometer for playback speeds != 1.0 · 6395d44b
```
This doesn't work because the Chronometer text layout can only count in realtime.

Issue:#6816
PiperOrigin-RevId: 288711702
```
  tonihei committed Jan 17, 2020
  6395d44b
- Fix TrueHD chunking in Matroska · e1a110e6
```
Issue: #6845
PiperOrigin-RevId: 288688716
```
  andrewlewis committed Jan 17, 2020
  e1a110e6 Browse Files
- Use FlacLibrary.isAvailable in FlacExtractor selection · 7fe55cd4
```
PiperOrigin-RevId: 288667790
```
  kimvde committed Jan 17, 2020
  7fe55cd4 Browse Files
- Upgrade OkHttp library to fix HTTP2 issue · bf9a61d6
```
Issue: #4078
PiperOrigin-RevId: 288651166
```
  olly committed Jan 17, 2020
  bf9a61d6 Browse Files
- Fix playback for Vivo codecs that output non-16-bit audio · eb0acb41
```
PiperOrigin-RevId: 288468497
```
  olly committed Jan 17, 2020
  eb0acb41 Browse Files
- Add comment explaining FlacBinarySearchSeeker output · d1839f14
```
PiperOrigin-RevId: 288464154
```
  kimvde committed Jan 17, 2020
  d1839f14 Browse Files
- FlacExtractor: Fix possible skipping of frame boundaries · 20e7684c
```
PiperOrigin-RevId: 288304477
```
  olly committed Jan 17, 2020
  20e7684c Browse Files
- Simulate IO exceptions in all FlacExtractor tests · be3257e8
```
- Simulate IO exceptions in the test using FlacBinarySearchSeeker for
  seeking in FlacExtractorTests. This makes the test slower but covers
  more test cases.

PiperOrigin-RevId: 288285057
```
  kimvde committed Jan 17, 2020
  be3257e8 Browse Files
- Remove WavExtractor from the nullness blacklist · 1f85cd9a
```
PiperOrigin-RevId: 288292488
```
  olly committed Jan 17, 2020
  1f85cd9a Browse Files
- Support 5G in network type detection · d609c3b6
```
PiperOrigin-RevId: 288280500
```
  tonihei committed Jan 17, 2020
  d609c3b6 Browse Files
- Fix MatroskaExtractor to use blockDurationUs not durationUs · 63eaf114
```
This typo was introduced in https://github.com/google/ExoPlayer/commit/ddb70d96ad99f07fe10f53a76ce3262fe625be70
when migrating a static method with parameter `durationUs` to an
instance method where the correct field to use was `blockDurationUs`
(but `durationUs` also exists).

The test that catches this was only added in https://github.com/google/ExoPlayer/commit/45013ece1e3fe054ff8960355a89559241eeb288 (and
therefore configured with the wrong expected output data).

issue:#6833
PiperOrigin-RevId: 288274197
```
  ibaker committed Jan 17, 2020
  63eaf114 Browse Files
- Add unit tests to FLAC extractor related classes · 1b764c2d
```
PiperOrigin-RevId: 287973192
```
  kimvde committed Jan 17, 2020
  1b764c2d Browse Files
- Use MIME types rather than PCM encodings for ALAW and MLAW · 97be0652
```
PiperOrigin-RevId: 287999703
```
  olly committed Jan 17, 2020
  97be0652
- Show ad markers after the window duration · 1f505fa9
```
Issue: #6552
PiperOrigin-RevId: 287964221
```
  andrewlewis committed Jan 17, 2020
  1f505fa9 Browse Files
- Add support for IMA ADPCM in WAV · 90a67b59
```
PiperOrigin-RevId: 287854701
```
  olly committed Jan 17, 2020
  90a67b59 Browse Files
- Support twos codec in MP4 · ef0066f0
```
Issue: #5789
PiperOrigin-RevId: 287828559
```
  olly committed Jan 17, 2020
  ef0066f0 Browse Files
- Document overriding of drawables for PlayerControlView · 0e1670bb
```
Issue: #6779
PiperOrigin-RevId: 287828273
```
  olly committed Jan 17, 2020
  0e1670bb Browse Files
- Document overriding drawables for notifications · b36c5e99
```
Issue: #6266
PiperOrigin-RevId: 287821640
```
  olly committed Jan 17, 2020
  b36c5e99 Browse Files
- Fix handling of E-AC-3 streams with AC-3 frames · 7fd0b1d8
```
Issue: #6602
PiperOrigin-RevId: 287816831
```
  andrewlewis committed Jan 17, 2020
  7fd0b1d8 Browse Files
- Don't use WavHeader.averageBytesPerSecond · 1edcc6c4
```
It's unreliable for at least one IMA ADPCM file I've found.
Calculating the blockIndex to seek to using exact properties
also seems more robust.

Note this doesn't change anything for the existing PCM test,
since averageBytesPerSecond is set correctly. It does make
a difference for an upcoming IMA ADPCM test though.

PiperOrigin-RevId: 287814947
```
  olly committed Jan 17, 2020
  1edcc6c4 Browse Files
- Fix typos · 3cf88bb4
```
PiperOrigin-RevId: 287810018
```
  andrewlewis committed Jan 17, 2020
  3cf88bb4 Browse Files
- Fix handling of network transitions in RequirementsWatcher · 3bce2138
```
Issue: #6733
PiperOrigin-RevId: 286621715
```
  olly committed Jan 17, 2020
  3bce2138 Browse Files
- Read arrays directly from Parcel · 355b3afa
```
PiperOrigin-RevId: 286197990
```
  olly committed Jan 17, 2020
  355b3afa Browse Files
- Parse MP3 header to retrieve the nb of sample per frames · 54f6f482
```
Add support for MP3 as an encoding format for passthrough.

This change does not change the observable
behavior of Exoplayer.

Also name the magics.

#exo-offload

PiperOrigin-RevId: 286146539
```
  krocard committed Jan 17, 2020
  54f6f482 Browse Files
- Add FlacExtractorSeekTest · 37e65ec0
```
PiperOrigin-RevId: 285823771
```
  kimvde committed Jan 17, 2020
  37e65ec0 Browse Files
- Fix FlacExtractor construction · fcac5af8
```
Fix the FlacExtractor constructor for the case where seek(0,0) is not called before reading.

PiperOrigin-RevId: 285811161
```
  kimvde committed Jan 17, 2020
  fcac5af8 Browse Files
- Implement seeking from seektable in FLAC extractor · bf9f49a9
```
PiperOrigin-RevId: 285799995
```
  kimvde committed Jan 17, 2020
  bf9f49a9 Browse Files
- Clean up WavExtractor PCM output · 7bd912f8
```
- Make extractor output samples that are uniformly distributed
  with respect to time, with a target of ~10 samples per second.
  The old approach could in theory put every frame into its own
  sample, which would be very inefficient downstream because we'd
  need to pass them individually to MediaCodec. It could also put
  data corresponding to a long duration of time into a single
  sample (e.g. if the sample rate of the content is low), which
  is bad downstream because we decide whether to set the decodeOnly
  flag on a per sample basis. More generally, the new approach
  is more predictable :).

- Stop using the WavSeekMap to get sample timestamps, and instead
  calculate them directly from the number of frames output. It's
  more obviously correct, particularly for data formats like IMA
  ADPCM where we'll need to adjust the data prior to output.

PiperOrigin-RevId: 285750010
```
  olly committed Jan 17, 2020
  7bd912f8 Browse Files
- Fix ParameterName warnings in core tests · 27b06e9a
```
PiperOrigin-RevId: 285716982
```
  andrewlewis committed Jan 17, 2020
  27b06e9a Browse Files
- Make it easier to update extractor test dump files · 80e3152e
```
PiperOrigin-RevId: 285407744
```
  olly committed Jan 17, 2020
  80e3152e Browse Files