1. 30 Sep, 2022 40 commits
    • Fix 1 ErrorProneStyle finding: · 83485bc5
      * Non-standard parameter comment; prefer `/* paramName= */ arg`
        (see http://go/bugpattern/ParameterComment)
      
      This CL looks good? Just LGTM and Approve it!
      This CL doesn’t look good? This is what you can do:
      * Revert this CL, by replying "REVERT: <provide reason>"
      * File a bug under go/error-prone-bug for category ErrorProneStyle if there's an issue with the CL content.
      * File a bug under go/rosie-bug if there's an issue with how the CL was managed.
      * Revert this CL and not get a CL that cleans up these paths in the future by
      replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to
      opt out the respective paths in your CL Robot configuration instead:
      go/clrobot-opt-out.
      
      This CL was generated by CL Robot - a tool that cleans up code findings
      (go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/java/com/google/android/libraries/media/METADATA which is reachable following include_presubmits from //depot/google3/third_party/java_src/android_libs/media/METADATA.
      Anything wrong with the signup? File a bug at go/clrobot-bug.
      
      #codehealth
      
      Tested:
          Local presubmit tests passed.
      PiperOrigin-RevId: 472252461
      Googler committed
    • Minor javadoc and scoping cleanup. · fa1f09fc
      No functional changes.
      
      PiperOrigin-RevId: 472245797
      huangdarwin committed
    • Remove assertion that prevents masking of ad periods · 73f86682
      The assertion asserts against a `Period` and an `AdPlaybackState` which actually
      asserts against a resolved ad which is what `ExoPlayerImplInternal` does later and
      what gives us a `SEEK_ADJUSTMENT`. However, this assertion is not required at the
      moment of masking, because we are sure that the resolved seek results in a content
      period and never an ad period.
      
      #minor-release
      Issue: androidx/media#122
      PiperOrigin-RevId: 471827072
      bachinger committed
    • Add sepia, grayscale, and inverted filters to the demo app. · 305ea205
      PiperOrigin-RevId: 471782565
      leonwind committed
    • Rename shouldPassthrough to shouldTranscode · 7085c2fa
      shouldPassthrough's internal checks seem to be check whether we should *not*
      pass through, which seemed a bit like a confusing double-negative to me.
      
      shouldTranscode is slightly more clear, by instead returning true when we do
      want to transcode.
      
      No functional changes intended.
      
      PiperOrigin-RevId: 471753771
      huangdarwin committed
    • Skip transcoding if HDR video does not need encoding. · bc88f8be
      https://github.com/androidx/media/commit/3b0d2c15867b3698f130476736785d427b28b7bd made `shouldPassthrough` always return false for `enableHdrVideoEditing`:
      
      >We force using `FrameEditor` (no passthrough) to avoid the need to select another edit operation, and use the new shaders. The `EGLContext` and `EGLSurface` also need to be set up differently for this path.
      
      However, this was introduced before the `videoNeedsEncoding` setting was introduced in https://github.com/androidx/media/commit/3f615040c033a37f81b1d73605cd1f7d420b47b5. That setting should apply to HDR videos as much as SDR videos.
      
      PiperOrigin-RevId: 471569853
      Googler committed
    • Use ContextCompat.getMainExecutor when calling MediaBrowser methods · 9a674543
      Replacing remaining usage of MoreExecutors.directExecutor. This allows the service to be switched to run in another process and the app still works the same as if it is running in the same process.
      
      Issue: androidx/media#100
      PiperOrigin-RevId: 471547177
      rohks committed
    • Provide methods to override notification fields · a45df2fd
      `contentTitle` and `contentText` can now be overridden.
      
      Issue: androidx/media#150
      PiperOrigin-RevId: 471287701
      rohks committed
    • Fix 3 ErrorProneStyle findings: · 6d3cc01d
      * Non-standard parameter comment; prefer `/* paramName= */ arg`
        (see http://go/bugpattern/ParameterComment) (3 times)
      
      This CL looks good? Just LGTM and Approve it!
      This CL doesn’t look good? This is what you can do:
      * Revert this CL, by replying "REVERT: <provide reason>"
      * File a bug under go/error-prone-bug for category ErrorProneStyle if there's an issue with the CL content.
      * File a bug under go/rosie-bug if there's an issue with how the CL was managed.
      * Revert this CL and not get a CL that cleans up these paths in the future by
      replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to
      opt out the respective paths in your CL Robot configuration instead:
      go/clrobot-opt-out.
      
      This CL was generated by CL Robot - a tool that cleans up code findings
      (go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/java/com/google/android/libraries/media/METADATA which is reachable following include_presubmits from //depot/google3/third_party/java_src/android_libs/media/METADATA.
      Anything wrong with the signup? File a bug at go/clrobot-bug.
      
      #codehealth
      
      Tested:
          Local presubmit tests passed.
      PiperOrigin-RevId: 471198016
      Googler committed
    • Add @SuppressWarnings to nullness errors detected by a newer version of the Checker Framework · 1b389ebc
      PiperOrigin-RevId: 471137219
      Googler committed
    • Effect: Add some FrameProcessor javadoc. · 69714e5f
      In particular, make it a bit more clear that "rendering" and "releasing" frames are
      related concepts, and how they differ from one another in conjunction with frame
      dropping.
      
      PiperOrigin-RevId: 471037733
      huangdarwin committed
    • HDR: Use factory for MatrixTransformationProcessor. · 1b648296
      Separate MatrixTransformationProcessor constructors by color input and output.
      
      PiperOrigin-RevId: 471034768
      huangdarwin committed
    • Fix 19 ErrorProneStyle findings: · b48ca6e0
      * Non-standard parameter comment; prefer `/* paramName= */ arg`
        (see http://go/bugpattern/ParameterComment) (19 times)
      
      This CL looks good? Just LGTM and Approve it!
      This CL doesn’t look good? This is what you can do:
      * Revert this CL, by replying "REVERT: <provide reason>"
      * File a bug under go/error-prone-bug for category ErrorProneStyle if there's an issue with the CL content.
      * File a bug under go/rosie-bug if there's an issue with how the CL was managed.
      * Revert this CL and not get a CL that cleans up these paths in the future by
      replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to
      opt out the respective paths in your CL Robot configuration instead:
      go/clrobot-opt-out.
      
      This CL was generated by CL Robot - a tool that cleans up code findings
      (go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/java/com/google/android/libraries/media/METADATA which is reachable following include_presubmits from //depot/google3/third_party/java_src/android_libs/media/METADATA.
      Anything wrong with the signup? File a bug at go/clrobot-bug.
      
      #codehealth
      
      Tested:
          Local presubmit tests passed.
      PiperOrigin-RevId: 471022923
      Googler committed
    • Add static Grayscale and Inverted RGB Filter. · 85950423
      PiperOrigin-RevId: 471017440
      leonwind committed
    • Update first frame instructions. · 3ba8bb71
      PiperOrigin-RevId: 471008623
      huangdarwin committed
    • Remove media3-only line from exoplayer2 `build.gradle` file · 932f0d22
      #minor-release
      
      PiperOrigin-RevId: 470999044
      ibaker committed
    • Fix 1 ErrorProneStyle finding: · 52d32be8
      * Non-standard parameter comment; prefer `/* paramName= */ arg`
        (see http://go/bugpattern/ParameterComment)
      
      This CL looks good? Just LGTM and Approve it!
      This CL doesn’t look good? This is what you can do:
      * Revert this CL, by replying "REVERT: <provide reason>"
      * File a bug under go/error-prone-bug for category ErrorProneStyle if there's an issue with the CL content.
      * File a bug under go/rosie-bug if there's an issue with how the CL was managed.
      * Revert this CL and not get a CL that cleans up these paths in the future by
      replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to
      opt out the respective paths in your CL Robot configuration instead:
      go/clrobot-opt-out.
      
      This CL was generated by CL Robot - a tool that cleans up code findings
      (go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/java/com/google/android/libraries/media/METADATA which is reachable following include_presubmits from //depot/google3/third_party/java_src/android_libs/media/METADATA.
      Anything wrong with the signup? File a bug at go/clrobot-bug.
      
      #codehealth
      
      Tested:
          Local presubmit tests passed.
      PiperOrigin-RevId: 470953422
      Googler committed
    • Update color info mismatch test · daf1e5e2
      This should now expect transformation to succeed.
      
      PiperOrigin-RevId: 470950411
      andrewlewis committed
    • Log instead of throwing for transfer mismatch · dbe66775
      PiperOrigin-RevId: 470354448
      andrewlewis committed
    • Fix ExternalTextureManager: repeated queueing input frame in preview · 91709831
      TL;DR: we should check if there are new frames available to queue to the
      ExternalTextureProcessor before actually queueing a frame.
      
      The overall flow on the external texture processor:
      
      - `SurfaceTexture.onFrameAvailable` is called on `ExtTexMgr`, and
        - it calls `updateTexImage()`, and sets `frame`
        - it calls `maybeQueueFrameToExtTexProc()`
          - the frame is queued to `ExtTexProc` if `frame` is set
      
        - From `ExtTexProc.queueInputFrame()`:
          - notifies the `frameProcessorListener` of available frame
          - notifies the `inputListener` of `onReadyToAcceptInputFrame`
            - (`ExtTexMgr` is the listener), it calls `maybeQueueFrameToExtTexProc()`
             again
      
      -- Parallelly --
      - `ExtTexProc` calls `inputListener.onInputFrameProcessed`, when the frame is
      released
        - (`ExtTexMgr` is the listener), sets `frame` to `null`
      
      *Problem*
      
      This logic relies on `frame` to be cleared at the right time.
      
      In transformer, it's OK b/c `ExtTexProc` release the frame immediately in
      `queueInputFrame()` and calls `onInputFrameProcessed` which also reset `frame`
      
      But in previewing, the frame is not released for a while, up to 10 ms.
      In this case, `frame` will not reset in this 10 ms, and
      `maybeQueueFrameToExtTexProc()` is repeatedly queueing the same input frame.
      
      PiperOrigin-RevId: 470211620
      claincly committed
    • Switch incorrectly configured native multidex to legacy for demos · d260b0c2
      Native multidex can only be used for binaries with minSdkVersion of 21 or higher, but minSdkVersion was specified to 16.
      
      PiperOrigin-RevId: 470004102
      rohks committed
    • Switch incorrectly configured native multidex to legacy · 5b3f3202
      Native multidex can only be used for binaries with minSdkVersion of 21 or higher, but minSdkVersion was specified to 16.
      
      PiperOrigin-RevId: 470003836
      rohks committed
    • Delete glPrograms in Contrast and RgbMatrix. · a7d3752c
      Remove unecessary null checks.
      
      PiperOrigin-RevId: 469999952
      leonwind committed
    • HDR: Rename GL_COLOR_TRANSFER instances to COLOR_TRANSFER · 2a05a504
      PiperOrigin-RevId: 469959215
      huangdarwin committed
    • Fix missing id error · 84577949
      PiperOrigin-RevId: 469750922
      rohks committed
    • HDR: Add PQ support. · 2ad07e88
      Use the PQ OETF and EOTF to ensure that intermediate fragment shader operations
      using PQ are in linear BT.2020 rather than PQ and HLG-1 BT.2020.
      
      Also, swap the OETF and EOTF in shaders, as they were used incorrectly before
      
      Manually tested by verifying transformer demo HLG and PQ videos look the same with and without this CL, including with a BitmapOverlayProcessor enabled to test flows both with one MatrixTransformationProcessor that skips HDR TFs, and with one that doesn't.
      
      PiperOrigin-RevId: 469736067
      huangdarwin committed
    • Fix outdated RtpDataLoadable javadoc · b9bcf522
      PiperOrigin-RevId: 469443086
      claincly committed
    • Bind contrastFactor in constructor instead of drawFrame method. · 7e5dcf23
      PiperOrigin-RevId: 469438747
      leonwind committed
    • Replace usage of `android_binary` with `build_test` for libraries · 28070573
      `android_binary` is only required when building an application.
      
      PiperOrigin-RevId: 469413752
      rohks committed
    • Merge pull request #157 from vanniktech:onAddMediaItems-example · ca41026c
      PiperOrigin-RevId: 469410221
      Marc Baechinger committed
    • Handle initial RTSP seek · a62cf312
      PiperOrigin-RevId: 469143613
      claincly committed
    • Reassign TODO to new bug. · ee04bb88
      PiperOrigin-RevId: 468672505
      Googler committed
    • Fix issue link in release notes · c0cfb0b1
      PiperOrigin-RevId: 468670096
      bachinger committed
    • Add device info to CastPlayer · d204f6bf
      Issue: androidx/media#142
      PiperOrigin-RevId: 468666737
      bachinger committed
    • Change onOutputFrameAvailable timestamp from nanos to micros. · 0b1c540f
      Upstream timestamps from the decoder are also in microseconds,
      so using microseconds here is consistent with that.
      
      PiperOrigin-RevId: 468659099
      Googler committed
    • Fix the command sample size given to trackOutput. · 30257c76
      Remove the manual overwriting of Note ON events that have 0 velocity with Note OFF. JSyn handles this already.
      
      - The implementation of "running status" means that the amount of bytes read from the file differ from the size of the sample that ends up in the decoder. The decoder sample contains the applied running status (status of previous event), which the file bytes don't contain.
      
      PiperOrigin-RevId: 468537659
      hmzh committed
    • Allow frame release to be controlled outside FrameProcessor. · a5d7fdca
      Adds a method to FrameProcessor.Listener to be called when an
      output frame is available and a method releaseOutputFrame in
      FrameProcessor allowing the caller to trigger release of the
      oldest available output frame at a given timestamp. Late frames
      or frames with unset release times are dropped in the
      FinalMatrixTransformationProcessorWrapper.
      
      More than one output frame can become available before they are
      released if the penultimate GlTextureProcessor is capable of producing
      multiple output frames. Processing continues while waiting for
      releaseOutputFrame to be called. Frame release tasks are prioritized
      over other tasks.
      
      PiperOrigin-RevId: 468473072
      Googler committed
    • HDR: Clamp YUV to RGB conversion. · 244d38cf
      Manually tested using transformer demo HLG videos. Before this CL, RGB values after the YUV to RGB conversion reached up to 1.025. After this CL, RGB values correctly clamp at 1.0.
      
      PiperOrigin-RevId: 468426092
      huangdarwin committed
    • Fix missing commas in documentation of DefaultMediaNotificationProvider · 6950f3aa
      PiperOrigin-RevId: 468257769
      rohks committed
    • Defensively cancel frame processing tasks on error. · 0c961a7a
      FrameProcessingTaskExecutor should be released on error.
      There can be a delay until this happens, so
      FrameProcessingTaskExecutor will cancel any pending tasks
      and drop new tasks until it is released.
      
      PiperOrigin-RevId: 468171820
      Googler committed