- 05 Dec, 2018 1 commit
-
-
[Problem] As the alignment of each lineas are calculated individually, the artificially introduced CENTER and RIGHT alignments can be mixed with each other and with the default LEFT alignment. The mixed results look worse than just using the original DEFAULT, and the readability is radically decreased. [Solution] Pre-calculate the alignment for each line, and use the leftmost of them for all lines. The intention of caption provider could be different, but the worst case scenario is that we revert back everything to LEFT alignment that is the only option in the CEA608 standard so we show everything at the exact location it is set in the content. The readability is never worse than the one given by the content provider. [Test] This should influence CEA608 pop-up cations only. (Not roll up). Test various live channels with this change. Note: Beginning of commercials tend to have PAINT-ON mode as that is immediately showing incoming characters, not just at the end of the line like POP-on mode.
Zsolt Matyas committed
-
- 26 Nov, 2018 11 commits
-
-
[Problem] PAINT-ON mode is not implemented. From the compliance tests: * RDC command has no effect except to select paint-on style. * Next data are written directly to the display upon receipt. * If other captioning is already on the screen, the four-row limit is still in effect. [Solution] It is a rare use case, we do not support overriding characters in existing cueBuilders as PAINT-ON would require. But several compliance tests check if the screen is cleared when the mode switch happens. We must keep the old captions when switching to PAINT-ON mode [Test] - Live Over-the-Air content, beginning of commercials often uses PAINT-ON mode
Zsolt Matyas committed -
It needs to have package visiblity, otherwise nothing can use it. PiperOrigin-RevId: 222821546
olly committed -
PiperOrigin-RevId: 222819933
olly committed -
Subclasses may want to analyze, log and react to the Cronet-specific connection data. Issue:#5134 PiperOrigin-RevId: 222809441
tonihei committed -
Issue: #4838 PiperOrigin-RevId: 222805051
olly committed -
Issue: #5059 PiperOrigin-RevId: 222803511
olly committed -
- Add DownloadAction.fromByteArray for symmetry with toByteArray - Make DownloadService call fromByteArray, for symmetry with calls to toByteArray PiperOrigin-RevId: 222801703
olly committed -
PiperOrigin-RevId: 222798467
Oliver Woodman committed -
PiperOrigin-RevId: 222797622
olly committed -
The existing one seems to be dead, and isn't https. PiperOrigin-RevId: 222795996
olly committed -
We already have tests for comment blocks, and they already pass because we discard the comment when we fail to parse it as a cue. We should just skip it directly, however.
Oliver Woodman committed
-
- 23 Nov, 2018 10 commits
-
-
PiperOrigin-RevId: 222633838
olly committed -
Imported from GitHub PR https://github.com/google/ExoPlayer/pull/5140 https://github.com/google/ExoPlayer/pull/5086 moved onto the right branch. Merge 8822e188d24c1d9b3ed101918763b16e46c8debc into 0c385a85 PiperOrigin-RevId: 222633340
Oliver Woodman committed -
PiperOrigin-RevId: 222632883
olly committed -
PiperOrigin-RevId: 222630411
olly committed -
PiperOrigin-RevId: 222628386
olly committed -
Imported from GitHub PR https://github.com/google/ExoPlayer/pull/5126 Closes #5125 Merge 55a4c1e15de7f100f37e38119f1da360910fd1e3 into fe41f17c PiperOrigin-RevId: 222612873
BrainCrumbz committed -
PiperOrigin-RevId: 222609579
aquilescanta committed -
The corresponding IntDef has changed without updating the attribute values. Issue:#5139 PiperOrigin-RevId: 222598044
tonihei committed -
This allows to specify open-ended blacklisting with Long.MAX_VALUE. PiperOrigin-RevId: 222550939
tonihei committed -
Oliver Woodman committed
-
- 22 Nov, 2018 9 commits
-
-
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222529260
olly committed -
We currently fail the entire playback tests if we exceed a start timeout or the test gets stopped forcefully. This is problematic as the start timeout may happen from time to time for the ABR tests and we'd still like to have the remaining playbacks. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222406639
tonihei committed -
The input.getLength() check is invalid because the length may be unknown (i.e. if the server doesn't include a Content-Length response header when serving chunks). Issue: #5063 (tangentially related only) ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222406347
olly committed -
This allows more efficient range removals and is consistent with addition, which supports adding multiple elements in a single operation. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222396310
aquilescanta committed -
Issue: #4883 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222392621
olly committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222387374
olly committed -
This allows to account for bandwidth used by fixed track selections. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222383736
tonihei committed -
BandwidthProvider allows bandwidth allocation logic to be customized. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222293581
eguven committed -
1. Pull up all subclasses of DownloadAction into DownloadAction 2. Add DownloaderFactory for Downloader instantiation, and DefaultDownloaderFactory to replace the instantiation logic being removed from the DownloadAction subclasses. This change will upgrade existing action files gracefully (i.e. it does not lose compatibility with the existing offline implementation, other than some minor breaking changes to the API). TODOs: 1. Move test methods from the XDownloadActionTest classes into DownloadActionTest. This will be done in a subsequent CL. There's a lot of consolidation that can be done here, including de-duplicating some of the test code added in this CL. 2. Look at merging DownloaderConstructorHelper into DefaultDownloaderFactory. 3. Use customCacheKey in DASH/HLS/SS Downloaders, for completeness. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222258983
olly committed
-
- 20 Nov, 2018 9 commits
-
-
createTrackSelections decides whether to create an adaptive or a fixed track seletion to create. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222231011
eguven committed -
Forwarding the listeners to the notification update is meant to ensure we only notify the listeners which were registered at the time the event happened However, we currently just copy the reference to the actual list instead of doing a deep copy of the listeners. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222227735
tonihei committed -
This ensures that all callbacks use the same notification mechanism. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222226913
tonihei committed -
The update is actually unrelated and putting it all in one large update object complicates adding the same update mechanism for other values. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222226825
tonihei committed -
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222221294
tonihei committed -
Since version 17.0 play-services-ads requires specifying AD_MANAGER_APP=true in AndroidManifest.xml, so add this in the IMA extension's manifest. See also https://developers.google.com/ad-manager/mobile-ads-sdk/android/quick-start. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222087771
andrewlewis committed -
WindowedTrackBitrateEstimator, uses future and past chunks in a window of time to estimate track bitrate values. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=222065409
eguven committed -
Interpret single-item audio stream edit lists as audio padding specification. Use the information to strip out padding from decoded audio streams. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=221865861
mdoucleff committed -
Currently no path may be chosen if minBufferUs == maxBufferUs == bufferedDurationUs. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=221639199
tonihei committed
-