- 24 May, 2022 8 commits
-
-
Pixel 5 was occasionally reaching the 2 minute limit. PiperOrigin-RevId: 448244803
samrobinson committed -
Network type detection on these API levels couldn't be tested yet because of a missing Robolectric feature. This was fixed by the recent Robolectric upgrade and the restrictions can be removed. This also requires to replicate the platform hack we rely on on these API levels. PiperOrigin-RevId: 448240431
tonihei committed -
Some RTP foramts are statically assigned, so they don't have the rtpmap attribute. Create the missing rtpmap attribute in this case. PiperOrigin-RevId: 448239724
claincly committed -
The prior test does not exist, and is not a pixel test. PiperOrigin-RevId: 448224929
huangdarwin committed -
- Add a MidiRenderer skeleton with basic playback - Add MidiDecoder with placeholder synthesizer (JSyn) impl - Make MidiExtractor feed placeholder data - Add Renderer extension loaders for MIDI PiperOrigin-RevId: 448212797
hmzh committed -
Add MIDI filetype information for use in the ExtractorsFactory PiperOrigin-RevId: 447976272
hmzh committed -
PiperOrigin-RevId: 447950623
samrobinson committed -
transformWithDecodeEncode is now transformWithoutDecodeEncode, to test the passthrough path. PiperOrigin-RevId: 447796892
samrobinson committed
-
- 10 May, 2022 1 commit
-
-
PiperOrigin-RevId: 447724152
samrobinson committed
-
- 09 May, 2022 2 commits
-
-
We never register SubtitleView as a Player.Listener directly, it's always done via PlayerView. PiperOrigin-RevId: 447467037
ibaker committed -
This listener replaces FrameProcessorChain#getAndRethrowBackgroundExceptions. The listener uses a new exception type FrameProcessingException separate from TransformationException as the frame processing components will be made reusable outside of transformer soon. PiperOrigin-RevId: 447455746
hschlueter committed
-
- 10 May, 2022 1 commit
-
-
This constant is used for https://docs.gl/es2/glVertexAttribPointer which takes the number of components per generic vertex attribute (meaning the size of the individual coordinate vectors here) not the number of attributes (the number of vertices that the old constant name referred to). PiperOrigin-RevId: 447427241
hschlueter committed
-
- 06 May, 2022 4 commits
-
-
As defined in Kush Amerasinghe's paper 'H.264 For the rest of us'. PiperOrigin-RevId: 446988272
samrobinson committed -
Before this change, we list the formats for which we don't want transcoding. This change disables transcoding altogether. This was tested by checking that transcoding takes place on a short camera recording only when the added flag is not present (and AndroidManifest does not declare support for HEVC). PiperOrigin-RevId: 446986580
aquilescanta committed -
We won't try to provide/rethrow helpful error messages that are already provided by GL, as this sort of task would expand into writing a GL verifier. A Gl verifier is unnecessarily complex for minimal payoff, especially as Apps expected to read GL error messages would mostly be those writing custom GlFrameProcessors, who should be already be familiar with reading GL error messages anyways. PiperOrigin-RevId: 446950837
huangdarwin committed -
RawCC is a Google-internal subtitle format, and is no longer used with ExoPlayer. PiperOrigin-RevId: 446950691
ibaker committed
-
- 05 May, 2022 2 commits
-
-
The texture coordinates can be derived from the frame coordinates. PiperOrigin-RevId: 446770538
hschlueter committed -
Relates to https://github.com/square/okhttp/issues/3146. This was from https://github.com/androidx/media/pull/71. There is a draft PR https://github.com/square/okhttp/pull/7185/files which documents OkHttp's ideal handling of cancellation including interrupts. But a few key points 1) This is a target state, and OkHttp does not currently handle interrupts correctly. In the past this has been identified, and the advice is to avoid interrupts on Http threads, see discussion on https://github.com/square/okhttp/issues/1902. Also an attempt at a fix here https://github.com/square/okhttp/pull/7023 which wasn't in a form to land. 2) Even with this fixed, it is likely to never be optimal, because of OkHttp sharing a socket connection for multiple inflight requests. From https://github.com/square/okhttp/pull/7185 ``` Thread.interrupt() is Clumsy ---------------------------- `Thread.interrupt()` is Java's built-in mechanism to cancel an in-flight `Thread`, regardless of what work it's currently performing. We recommend against using `Thread.interrupt()` with OkHttp because it may disrupt shared resources including HTTP/2 connections and cache files. In particular, calling `Thread.interrupt()` may cause unrelated threads' call to fail with an `IOException`. ``` This PR leaves the Loader/DataSource thread parked on a countdown latch, while this may seem wasteful and an additional context switch. However in practice the response isn't returned until the Http2Connection and Http2Reader have a response from the server and these means effectively parking in a `wait()` statement here https://github.com/square/okhttp/blob/9e039e94123defbfd5f11dc64ae146c46b7230eb/okhttp/src/jvmMain/kotlin/okhttp3/internal/http2/Http2Stream.kt#L140 PiperOrigin-RevId: 446652468
yschimke committed
-
- 04 May, 2022 6 commits
-
-
ScaleToFitFrameProcessor, PresentationFrameProcessor, and EncoderCompatibilityFrameProcessor now each implement MatrixTransformation instead of wrapping MatrixTransformationFrameProcessor. PiperOrigin-RevId: 446480286
hschlueter committed -
Refactoring change only. PiperOrigin-RevId: 446475708
huangdarwin committed -
The TrackSelector is released when the player is released. The TrackSelector can be reused if TrackSelector.init() is called again. PiperOrigin-RevId: 446439717
christosts committed -
PiperOrigin-RevId: 446432695
andrewlewis committed -
PiperOrigin-RevId: 446423017
olly committed -
PiperOrigin-RevId: 446400192
ibaker committed
-
- 03 May, 2022 4 commits
-
-
This change splits AdvancedFrameProcessor into 4 files: - MatrixTransformationFrameProcessor for the GlFrameProcessor implementation - MatrixTransformation and GlMatrixTransformation for the GlEffect specification - MatrixUtils for the static matrix helpers PiperOrigin-RevId: 446236384
hschlueter committed -
PiperOrigin-RevId: 446181877
christosts committed -
https://github.com/google/ExoPlayer/commit/8da8c5e781a7e576ebf902c92e2886d664462199
*** Original commit *** Upgrade Robolectric dependency to 4.8 *** PiperOrigin-RevId: 446175705
christosts committed -
Some APIs from Android 12L were used either via reflection or constants values were hard-coded. We can now use these APIs directly since we upgraded the compile SDK version to 32. PiperOrigin-RevId: 446167543
christosts committed
-
- 09 May, 2022 12 commits
-
-
PiperOrigin-RevId: 446161354
ibaker committed -
It's reasonable to serialize this type to support backgrounding use-cases, as demonstrated by the main demo app. PiperOrigin-RevId: 446161300
ibaker committed -
PiperOrigin-RevId: 446156308
ibaker committed -
PiperOrigin-RevId: 446143537
hschlueter committed -
PiperOrigin-RevId: 445973162
olly committed -
PiperOrigin-RevId: 445445952
olly committed -
This is used from the main demo app. PiperOrigin-RevId: 445420580
ibaker committed -
This ensures that both content and licenses are requested using the same HTTP stack. #minor-release PiperOrigin-RevId: 445378940
ibaker committed -
Also add warning for what can happen if this is ignored. Previously the return value was overridden by setOutputSurface, now setOutputSurface only overrides the values using internally. PiperOrigin-RevId: 445377036
hschlueter committed -
Developers are expected to (eventually) only use methods on PlayerView (and not PlayerControlView) to interact with the UI controller. PiperOrigin-RevId: 445361488
ibaker committed -
PiperOrigin-RevId: 445356625
ibaker committed -
This is consistent with the IntDef name, and frees up the CONTENT_TYPE_ prefix for the @ContentType values (which are currently just TYPE_*, and therefore ambiguous with lots of other 'type' values in C). PiperOrigin-RevId: 445356476
ibaker committed
-