Commits · 7f885351dba24321dcc98b163bba4b3196d73cd6 · SDK / exoplayer

18 Apr, 2019 27 commits

Upgrade dependency versions · 7f885351
Oliver Woodman committed Apr 19, 2019

7f885351

Further improve DownloadService action names & methods · 0d8146cb

- We had buildAddRequest and sendNewDownload. Converged to
  buildAddDownload and sendAddDownload.
- Also fixed a few more inconsistencies, and brought the
  action constants into line as well.

PiperOrigin-RevId: 244274041

committed Apr 18, 2019

0d8146cb

Fix lint warnings for 2.10 · b8cdd7e4
```
PiperOrigin-RevId: 244268855
```
olly committed Apr 18, 2019
b8cdd7e4 Browse Files
Clean up database tables for launch · b30efe96
```
PiperOrigin-RevId: 244267255
```
olly committed Apr 18, 2019
b30efe96 Browse Files

Improve progress reporting logic · 54a5d691

- Listener based reporting of progress allows the content length
  to be persisted into the download index (and notified via a
  download state change) as soon as it's available.
- Moved contentLength back into Download proper. It should only
  ever change once, so I'm not sure it belongs in the mutable part
  of Download.
- Made a DownloadProgress class, for naming sanity.

PiperOrigin-RevId: 244242487

committed Apr 18, 2019

54a5d691

Support multiple DefaultDownloadIndex instances · 7d67047e
```
PiperOrigin-RevId: 244226680
```
olly committed Apr 18, 2019
7d67047e Browse Files
Simplify DownloadManager constructors · 38c5350c
```
PiperOrigin-RevId: 244223870
```
olly committed Apr 18, 2019
38c5350c Browse Files
Rename start/stopDownloads to resume/pauseDownloads · 8c624081
```
PiperOrigin-RevId: 244216620
```
olly committed Apr 18, 2019
8c624081 Browse Files
Rename manualStopReason to stopReason · 138da6d5
```
PiperOrigin-RevId: 244210737
```
olly committed Apr 18, 2019
138da6d5 Browse Files
Add missing DownloadService build*Intent and startWith* methods · 6d8bd345
```
PiperOrigin-RevId: 244196081
```
eguven committed Apr 18, 2019
6d8bd345
Avoid selecting a forced text track that doesn't match the audio selection · b6337adc
```
Assuming there is no text language preference.

PiperOrigin-RevId: 244176667
```
aquilescanta committed Apr 18, 2019
b6337adc Browse Files
Fix flaky DownloadManagerDashTest · a501f8c2
```
PiperOrigin-RevId: 244170179
```
eguven committed Apr 18, 2019
a501f8c2
Add test for HlsTrackMetadataEntry population in the HlsPlaylistParser · be0acc36
```
PiperOrigin-RevId: 244168713
```
aquilescanta committed Apr 18, 2019
be0acc36 Browse Files
Extend Bluetooth dead audio track workaround to Q · c2bbf38e
```
PiperOrigin-RevId: 244139959
```
andrewlewis committed Apr 18, 2019
c2bbf38e Browse Files
[libvpx] permalaunch number of buffers. · 898bfbff
```
PiperOrigin-RevId: 244094942
```
olly committed Apr 18, 2019
898bfbff Browse Files

Remove TODOs we're not going to do · 07485664

1. customCacheKey for DASH/HLS/SS is now asserted against
   in DownloadRequest
2. Merging of event delivery in DownloadManager is very
   tricky to get right and probably not a good idea

PiperOrigin-RevId: 244048392

committed Apr 18, 2019

07485664 Browse Files

Small javadoc fix for DownloadManager constructors · 289a8ffe
```
PiperOrigin-RevId: 244009343
```
eguven committed Apr 18, 2019
289a8ffe Browse Files

Disable cache span touching for offline · afd72839

Currently SimpleCache will touch cache spans whenever it reads
from them. With legacy SimpleCache setups this involves a potentially
expensive file rename. With new SimpleCache setups it involves
a more efficient but still non-free database write.

For offline use cases, and more generally any use case where the
eviction policy doesn't use last access timestamps, touching is
not useful. This change allows the evictor to specify whether it
needs cache spans to be touched or not. SimpleCache will only touch
spans if the evictor requires it.

Note: There is a potential change in behavior in cases where a
cache uses an evictor that doesn't need cache spans to be touched,
but then later switches to an evictor that does. The new evictor
may temporarily make sub-optimal eviction decisions as a result.
I think this is a very fair trade-off, since this scenario is
unlikely to occur much, if at all, in practice, and even if it
does occur the result isn't that bad.
PiperOrigin-RevId: 244005682

committed Apr 18, 2019

afd72839 Browse Files

Don't start download if user explicitly deselects all tracks · 2907f79e
```
PiperOrigin-RevId: 244003817
```
olly committed Apr 18, 2019
2907f79e Browse Files
Upgrade IMA to 3.11.2 · c1246937
```
PiperOrigin-RevId: 243988105
```
andrewlewis committed Apr 18, 2019
c1246937 Browse Files
Fix playback of badly clipped MP3 streams · e15e6212
```
Issue: #5772
PiperOrigin-RevId: 243987497
```
olly committed Apr 18, 2019
e15e6212 Browse Files

Add WritableDownloadIndex interface · 721e1dbf

One goal we forgot about a little bit was to allow applications
to provide their own index implementation. This requires the
writable side to also be defined by an interface.

PiperOrigin-RevId: 243979660

committed Apr 18, 2019

721e1dbf Browse Files

Reset playback info but not position/state in release · 6b0fd513

ImaAdsLoader gets the player position after the app releases
the player to support resuming ads at their current position
if the same ads loader is reused.

PiperOrigin-RevId: 243969916

committed Apr 18, 2019

6b0fd513 Browse Files

Assert customCacheKey is null for DASH, HLS and SmoothStreaming downloads · dcb8417a
```
PiperOrigin-RevId: 243954989
```
eguven committed Apr 18, 2019
dcb8417a Browse Files
Update release notes for 2.10 branch cut · 10f3b8db
```
PiperOrigin-RevId: 243821394
```
olly committed Apr 18, 2019
10f3b8db Browse Files

Use player.retry in demo app instead of manual position tracking. · e62da368

We currently do manual position tracking while the player is in error mode.
This is to allow an initial seek to the new position when trying to re-prepare.

Instead, we can just use our player.retry method and remove the tracking code.

PiperOrigin-RevId: 243819580

committed Apr 18, 2019

e62da368 Browse Files

Don't reset masking position when prepare fails. · 8e7a2ba9

The removed condition only applies when prepare fails and no timeline was or
is known. We should keep a pending seek position in such a case. The internal
player does the same thing already.

PiperOrigin-RevId: 243819466

committed Apr 18, 2019

8e7a2ba9 Browse Files

16 Apr, 2019 13 commits
- Fix key and accessibility scrubbing · ee08e7dc
```
Issue: #5767
PiperOrigin-RevId: 243811443
```
  olly committed Apr 16, 2019
  ee08e7dc Browse Files
- Add "setCustomErrorMessage" override that allows including an extras bundle with a custom error. · 0be4bee2
```
PiperOrigin-RevId: 243807109
```
  borrelli committed Apr 16, 2019
  0be4bee2 Browse Files
- Rename DownloadAction to DownloadRequest · 5856e757
```
PiperOrigin-RevId: 243806888
```
  eguven committed Apr 16, 2019
  5856e757 Browse Files
- Add ability to register/unregister custom CommandReceivers. · 9fc3ea79
```
PiperOrigin-RevId: 243799572
```
  borrelli committed Apr 16, 2019
  9fc3ea79 Browse Files
- Remove redundant proguard files · c2c7c43a
```
PiperOrigin-RevId: 243781000
```
  eguven committed Apr 16, 2019
  c2c7c43a Browse Files
- DownloadTracker shouldn't depend on DefaultDownloadIndex · 77b78b96
```
- It can work with any DownloadIndex
- Also simplify things to not require that it's registered
  as a DownloadManager listener by someone else

PiperOrigin-RevId: 243697352
```
  olly committed Apr 16, 2019
  77b78b96 Browse Files
- Prepare SimpleCache for 2.10.0 release · 9c759a86
```
- Expose constructors that take DatabaseProvider. Deprecate those
  that do not.
- Expose Cache.getUid. This will likely be used for naming of the
  tables accessed by DefaultDownloadIndex .

PiperOrigin-RevId: 243637786
```
  olly committed Apr 16, 2019
  9c759a86 Browse Files
- Fix Atom ConstantCaseForConstant suppression · 45348a97
```
PiperOrigin-RevId: 243636923
```
  andrewlewis committed Apr 16, 2019
  45348a97 Browse Files
- Fix DecryptionResource.Owner#onLastReferenceReleased type · 68bd5da3
```
PiperOrigin-RevId: 243632134
```
  aquilescanta committed Apr 16, 2019
  68bd5da3 Browse Files
- DownloadManager.getCurrentDownloads: Return list instead of array · 7b84a1ea
```
- Allows enforcing immutability, which in a future CL will allow
  avoiding allocating a new array/list on every call.
- Also some left over doc cleanup from the DownloadState rename.

PiperOrigin-RevId: 243627352
```
  olly committed Apr 16, 2019
  7b84a1ea Browse Files
- Add the HlsMetadataEntry from the Master playlist to the Hls tracks · 9ddd39c1
```
PiperOrigin-RevId: 243624081
```
  aquilescanta committed Apr 16, 2019
  9ddd39c1 Browse Files
- Move the RELEASENOTES entry for PlayReady's LA_URL workaround from HLS to DRM · e9a7d47f
```
PiperOrigin-RevId: 243618907
```
  aquilescanta committed Apr 16, 2019
  e9a7d47f Browse Files
- Add DownloadService.invalidateForegroundNotification · ba915017
```
ISSUE: #4563
PiperOrigin-RevId: 243616444
```
  eguven committed Apr 16, 2019
  ba915017 Browse Files