- 15 Jul, 2021 1 commit
-
-
* Constructors and methods with the same name should appear sequentially with no other code in between, even when modifiers such as static or private differ between the methods. Please re-order or re-name methods. (see http://go/bugpattern/UngroupedOverloads) This CL looks good? Just LGTM and Approve it! This CL doesn’t look good? This is what you can do: * Suggest a fix on the CL (go/how-to-suggest-fix). * Revert this CL, by replying "REVERT: <provide reason>" * File a bug under go/error-prone-bug for category ErrorProneStyle if the change looks generally problematic. * Revert this CL and not get a CL that cleans up these paths in the future by replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to opt out the respective paths in your CL Robot configuration instead: go/clrobot-opt-out. This CL was generated by CL Robot - a tool that cleans up code findings (go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/java/com/google/android/libraries/media/METADATA which is reachable following include_presubmits from //depot/google3/third_party/java_src/android_libs/media/METADATA. Anything wrong with the signup? File a bug at go/clrobot-bug. #codehealth PiperOrigin-RevId: 384877648
olly committed
-
- 14 Jul, 2021 11 commits
-
-
PiperOrigin-RevId: 384730845
bachinger committed -
PiperOrigin-RevId: 384681659
samrobinson committed -
PiperOrigin-RevId: 384666131
claincly committed -
Issue: #9183 RFC2326 Section C.1.1 specifies that the URI to identify a track can be either absolute (like rtsp://example.com/path) or relative (like "path"). Currently we don't handle absolute URI, and this CL is to add the support. Note though, we don't currently use the Content-Base or Content-Location headers for the session URI. PiperOrigin-RevId: 384649818
claincly committed -
Also rename hasPrevious/Next to hasPrevious/NextWindow for consistency. This makes it clearer what the difference between seekToPrevious/NextWindow and seekToPrevious/Next is. PiperOrigin-RevId: 384643373
kimvde committed -
PiperOrigin-RevId: 384575860
olly committed -
PiperOrigin-RevId: 384500287
olly committed -
Applications may need to pass a non-visual context when creating a DefaultTrackSelector (e.g., because they're audio-only or are creating the selector in a background service). Obtaining the default display via DisplayManager avoids the strict mode violation that occurs when retrieving it via WindowManager. #minor-release PiperOrigin-RevId: 384487363
olly committed -
PiperOrigin-RevId: 384477188
kimvde committed -
PiperOrigin-RevId: 384451470
claincly committed -
PiperOrigin-RevId: 384442821
aquilescanta committed
-
- 13 Jul, 2021 12 commits
-
-
PiperOrigin-RevId: 384280087
aquilescanta committed -
PiperOrigin-RevId: 384257929
kimvde committed -
Most of the super-interfaces are deprecated, but the intention is that only the types are deprecated and the methods themselves shouldn't be. In order to reflect this in javadoc we override all the methods in `Player.Listener` in order to 'cancel' the deprecation. This change deliberately doesn't override methods that are explicitly deprecated with documented replacements (like `Player.EventListener#onPlayerStateChanged`) - these should contine to be marked as deprecated in javadoc. PiperOrigin-RevId: 384253725
ibaker committed -
The errorCode assignment will be done in a following CL. PiperOrigin-RevId: 384230228
aquilescanta committed -
Android doc:https://developer.android.com/reference/android/app/Notification.Builder#setOnlyAlertOnce(boolean) PiperOrigin-RevId: 384227580
olly committed -
The types (open/close/read) does not provide extra information about the thrown playback exception, and they are not utilized at higher levels. PiperOrigin-RevId: 384219870
claincly committed -
This is more descriptive. PiperOrigin-RevId: 383887927
kimvde committed -
This is consistent with seek back and forward commands. PiperOrigin-RevId: 383867710
kimvde committed -
This is more consistent with other Player methods like previous and next. PiperOrigin-RevId: 383832298
kimvde committed -
PiperOrigin-RevId: 383816880
kimvde committed -
This is more correct and is consistent with the Javadoc. PiperOrigin-RevId: 383808096
kimvde committed -
PiperOrigin-RevId: 383806284
ibaker committed
-
- 09 Jul, 2021 16 commits
-
-
The parameters staying in DefaultTrackSelector are considered too ExoPlayer specific to be part of the `Player` interface. Those are: - exceedVideoConstraintsIfNecessary; - allowVideoMixedMimeTypeAdaptiveness; - allowVideoNonSeamlessAdaptiveness; - exceedAudioConstraintsIfNecessary; - allowAudioMixedMimeTypeAdaptiveness; - allowAudioMixedSampleRateAdaptiveness; - allowAudioMixedChannelCountAdaptiveness; - disabledTextTrackSelectionFlags; - exceedRendererCapabilitiesIfNecessary; - tunnelingEnabled; - allowMultipleAdaptiveSelections; - rendererDisabledFlags Track selection override will be migrated in a follow up cl. To avoid breaking backward compatibility, `DefaultTrackSelector.Parameters` extends `TrackSelectionParameters` and `DefaultTrackSelector.ParametersBuilder` extends `TrackSelectionParameters.Builder`. The change are thus transparent for clients. Test are incomplete for now, as this is a relatively big cl, I though the reviewer could give a first pass will the tests are completed. PiperOrigin-RevId: 383767021
krocard committed -
#minor-release Issue:#9158 PiperOrigin-RevId: 383660258
kimvde committed -
IntDef names (like enums) are normally singular, and this isn't a 'flag' IntDef. PiperOrigin-RevId: 383659574
ibaker committed -
PiperOrigin-RevId: 383656919
kimvde committed -
PiperOrigin-RevId: 383623440
kimvde committed -
PiperOrigin-RevId: 383448851
samrobinson committed -
It is used to implement `Bundleable` for `TrackSelection`. PiperOrigin-RevId: 383408386
krocard committed -
PiperOrigin-RevId: 383408075
aquilescanta committed -
In order to avoid doing the classification in ExoPlayerImplInternal. Note: This only makes the constructor change. The error code assignment will happen in an immediately following CL. PiperOrigin-RevId: 383397729
aquilescanta committed -
PiperOrigin-RevId: 383390096
bachinger committed -
This simplifies the API surface and the MediaController implementation. PiperOrigin-RevId: 383385436
kimvde committed -
PiperOrigin-RevId: 383382813
aquilescanta committed -
PiperOrigin-RevId: 383379334
aquilescanta committed -
As of 3.4.0 jdk8 annotation are integrated in checker. https://github.com/typetools/checker-framework/releases/tag/checker-framework-3.4.0 3.5 is the last version available internally. PiperOrigin-RevId: 383377733
krocard committed -
PiperOrigin-RevId: 383268454
samrobinson committed -
PiperOrigin-RevId: 383255572
ibaker committed
-