- 25 Feb, 2020 11 commits
-
-
Because we now annotate not-null by default in ExoPlayer library modules, we're seeing warnings in the demo apps where we override a method and don't explicitly specify an equivalent @NotNull annotation. It's probably confusing to use not-null by default for the demo apps, so this change uses @NonNull where necessary to fix the warnings. PiperOrigin-RevId: 296000044
olly committed -
PiperOrigin-RevId: 295985916
tonihei committed -
1. Have frame buffer callbacks return Libgav1StatusCode instead of int. The 0 (success), -1 (failure) return value convention is less obvious. Note: The callers of frame buffer callbacks, BufferPool::OnFrameBufferSizeChanged() and YuvBuffer::Realloc(), currently return bool, so more work is needed to propagate the frame buffer callbacks' Libgav1StatusCode return value to the Decoder API. 2. Allow the FrameBufferSizeChangedCallback to be omitted if the frame buffer size information is not useful to the application. 3. Remove the old (version 1) frame buffer callback API. Remove the frame buffer callback adaptor. frame_buffer2.h is renamed frame_buffer.h. Libgav1FrameBuffer2 is renamed Libgav1FrameBuffer. GetFrameBufferCallback2 and ReleaseFrameBufferCallback2 are renamed GetFrameBufferCallback and ReleaseFrameBufferCallback. PiperOrigin-RevId: 295971183
olly committed -
PiperOrigin-RevId: 295953956
olly committed -
PiperOrigin-RevId: 295946028
christosts committed -
All packages that are not in a test directory (or a demo app) should have the non-null-by-default annotation. Add the remaining ones. PiperOrigin-RevId: 295938504
tonihei committed -
I had to expand the info that gets passed around a bit, so I could join up the container, base & text ruby nodes. Spec: https://www.w3.org/TR/2018/REC-ttml2-20181108/#style-attribute-ruby PiperOrigin-RevId: 295931653
ibaker committed -
issue:#6885 PiperOrigin-RevId: 295931197
ibaker committed -
The part about leaving the pending trim start byte count unmodified if the processor was just configured is not correct. PiperOrigin-RevId: 295745371
andrewlewis committed -
PiperOrigin-RevId: 295724578
olly committed -
When copying CryptoInfo for asynchronous input buffer queueing, re-use the destination CryptoInfo's arrays to avoid re-allocating memory. PiperOrigin-RevId: 295706771
christosts committed
-
- 18 Feb, 2020 6 commits
-
-
PiperOrigin-RevId: 295695297
olly committed -
PiperOrigin-RevId: 295692163
olly committed -
When common was split from core, this permission was moved to common. However both modules need it. PiperOrigin-RevId: 295690886
olly committed -
- Add Settings UI - Remove unnecessary values related to Full Mode - Remove unnecessary hierarchy in list item layout - Enable to select Playback Speed in Settings Also changes: Keep Fullscreen UI when window focus changed in demo app PiperOrigin-RevId: 295655858
olly committed -
PiperOrigin-RevId: 295607866
olly committed -
This was unnecessary complexity to avoid very few users to be broken. PiperOrigin-RevId: 295603082
krocard committed
-
- 17 Feb, 2020 23 commits
-
-
Issue: #6981 PiperOrigin-RevId: 295584705
olly committed -
With the Renderer migration, this is officially unnecessary, and should always be true for supported encrypted content. PiperOrigin-RevId: 295584542
aquilescanta committed -
PiperOrigin-RevId: 295582502
ibaker committed -
Note on UnknownNull: Where there exists a generically typed base class and both null and non-null types are permitted, we need to clear the default non-null that's otherwise propagated everywhere. This then lets the nullness of the type work properly. PiperOrigin-RevId: 295582444
olly committed -
Issue: #6981 PiperOrigin-RevId: 295579872
olly committed -
CryptoInfo.iv length is always 16. When the actual initialization vector is shorter, zero out the trailing bytes. Issue: #6982 PiperOrigin-RevId: 295575845
olly committed -
Previously, the input buffer accessUnit count was passed as the output of the audio processors which did not make sense as the processors can split buffers. This patch passes the access unit count through a member variable. PiperOrigin-RevId: 295572577
krocard committed -
Seems like it belongs here. PiperOrigin-RevId: 295571820
ibaker committed -
PiperOrigin-RevId: 295569075
aquilescanta committed -
This is closer to how our actual renderers look like and allows tests to use a similar logic to show/suppress the first frame in follow-up changes. PiperOrigin-RevId: 295557548
tonihei committed -
We will eventually remove the workaround from ExoPlayerImplInternal added in https://github.com/google/ExoPlayer/commit/b84bde025258e7307c52eaf6bbe58157d788aa06 and replace it by an error that gets thrown if the LoadControl behaves badly. PiperOrigin-RevId: 295556131
tonihei committed -
PiperOrigin-RevId: 295548715
Ian Baker committed -
Libgav1 recently added the ComputeFrameBufferInfo() and SetFrameBuffer() helper functions for writing frame buffer callbacks. Using them simplifies the Libgav1GetFrameBuffer() function. Also resurrect the AlignTo16() function. PiperOrigin-RevId: 295548330
olly committed -
PiperOrigin-RevId: 295543916
kimvde committed -
PiperOrigin-RevId: 295540885
kimvde committed -
PiperOrigin-RevId: 295539969
ibaker committed -
Plus a bit of misc warning cleanup whilst I was there PiperOrigin-RevId: 295415657
olly committed -
PiperOrigin-RevId: 295414974
olly committed -
fixes: gav1_jni.cc:446:25: error: cast from pointer to smaller type 'int' loses information const int buffer_id = reinterpret_cast<int>(buffer_private_data); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ gav1_jni.cc:730:9: error: cast from pointer to smaller type 'int' loses information reinterpret_cast<int>(decoder_buffer->buffer_private_data); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ after https://github.com/google/ExoPlayer/commit/0915998add5918214fa0282a69b50a159168a6d5 PiperOrigin-RevId: 295211245olly committed -
PiperOrigin-RevId: 295146481
christosts committed -
Previously that was implicit, it was the passthrough dance: - MimeTypes.getEncoding(inputFormat) did not implement RAW MIME, so it was returning INVALID_ENCODING for PCM - and allowPassthrough was returning MimeTypes.getEncoding() != INVALID_ENCODING - which was setting codecInfo.passthrough, and passthroughEnabled. Thus Util.isEncodingPcm(encoding) is the opposite of (MimeTypes.getEncoding(inputFormat) != C.ENCODING_INVALID) This was rather implicit and brittle as anyone could add support for audio/RAW in MimeTypes.getEncoding and break PCM playback. As a result make it explicit that allowPassthrough must always return false in PCM. PiperOrigin-RevId: 295144013krocard committed -
PiperOrigin-RevId: 295140561
krocard committed
-