- 24 Jul, 2020 40 commits
-
-
- Removed Tunneling option from popup menu - Removed intent parameter regarding tunneling - Removed string definition regarding tunneling PiperOrigin-RevId: 322123578
claincly committed -
PiperOrigin-RevId: 322120882
christosts committed -
Replace `type` with (optional) `mimeType` and add `keySetId` in DownloadRequest. The DownloadHelper infers the downloading method (DASH, HLS, SmoothStreaming or Progressive) from the content's MIME type and URI. PiperOrigin-RevId: 322117384
christosts committed -
PiperOrigin-RevId: 322115322
ibaker committed -
PiperOrigin-RevId: 322114754
christosts committed -
Also use the cronet extension in the demo app. PiperOrigin-RevId: 322108530
andrewlewis committed -
PiperOrigin-RevId: 322094331
andrewlewis committed -
This is currently causing frames to be dropped when we seek. PiperOrigin-RevId: 322009748
olly committed -
PiperOrigin-RevId: 322008577
olly committed -
PiperOrigin-RevId: 321774583
ibaker committed -
This change replaces a lot of individual isInputPcm branching with a single, larger branch. PiperOrigin-RevId: 321763040
olly committed -
PiperOrigin-RevId: 321762840
insun committed -
PiperOrigin-RevId: 321595514
olly committed -
The logic to clear the playlist is currently duplicated in various reset methods so that calls to player.stop(true) can clear the playlist. This can be deduplicated by clearing the playlist as a seperate operation that reuses the existing code. PiperOrigin-RevId: 321578759
tonihei committed -
These were missed on the first pass PiperOrigin-RevId: 321553847
ibaker committed -
Suggested during the review of https://github.com/google/ExoPlayer/commit/437d1b6e9ae1e085583b3ab8e8d686d1eea32b65 This keeps the Runnable -> Callable<Boolean> conversion encapsulated inside SessionPlayerConnector which makes it clearer why it's needed. PiperOrigin-RevId: 321553744
ibaker committed -
PiperOrigin-RevId: 321553397
bachinger committed -
I duplicated some methods in SimpleCacheTest to ensure we keep testing the deprecated code paths for now. PiperOrigin-RevId: 321548802
ibaker committed -
This also renders https://github.com/google/ExoPlayer/pull/7625 redundant. PiperOrigin-RevId: 321544195
olly committed -
- Rename PlayerActivity2 to InternalPlayerActivity. - Reduced code duplications. PiperOrigin-RevId: 321515231
insun committed -
- Move output channel workaround to a block that's only executed for PCM - Remove redundant variable PiperOrigin-RevId: 321460898
olly committed -
PiperOrigin-RevId: 321440594
olly committed -
PiperOrigin-RevId: 321436812
bachinger committed -
We currently try to call onAdPlaybackStarted even if the ad session is not created yet and if not, we never call the callback afterwards. Make sure to update and create the current session before trying to send onAdPlaybackStarted. As a result, we can merge updateSessions into the existing handleTimelineChanged and handleDiscontinuity calls as they always need to be called together. PiperOrigin-RevId: 321383860
tonihei committed -
This fixes a bug that renderer errors are currently falsely associated with the playing period. PiperOrigin-RevId: 321381705
tonihei committed -
This method has been replaced by onPlaybackSpeedChanged PiperOrigin-RevId: 321369921
ibaker committed -
ISSUE: #7565 PiperOrigin-RevId: 321367089
kimvde committed -
Also remove some duplicate logging from ExoHostedTest - EventLogger logs the same info already. PiperOrigin-RevId: 321366052
ibaker committed -
Float values are allowed to be > 0dbfs, it is just not nominal as it will might distort the signal when played without attenuation. This is also consistent with [AudioTrack.write(FloatBuffer)](https://developer.android.com/reference/android/media/AudioTrack#write(float[],%20int,%20int,%20int)) that explicitly allows it up to 3dbfs. PiperOrigin-RevId: 321345077
krocard committed -
PiperOrigin-RevId: 321340777
olly committed -
The method has been called from two call sites in EPII triggered by EPII.updatePeriods(). The first call site was calling it when the MediaSourceList is empty or not yet prepared. This can be removed because if empty or not prepared no source ever could have thrown yet. The second call site was checking for potential source refresh exceptions when queue.getNextMediaPeriodInfo() returns null when trying to getting the next loading period. Looking into all reasons for why the method returns null, none of them is caused by an exception of a media source. The reasons are: - if we are at the last period of the timeline - if the defaultPosition of the next period in the timeline is null (if the window.durationUs == C.TIME_UNSET or defaultPositionProjectionUs is projected beyond the duration of the window) - if we are waiting for an ad uri to arrive (period.isAdAvailable(...) == false) - if we are waiting for the ad group count to be updated (adCountInCurrentAdGroup == C.LENGTH_UNSET) The above reasons are not caused by a source error and may be resolved when doSomeWork is called the next time. Hence it is save to remove the calls to maybeThrowSourceInfoRefreshError(). Beside this, an actual sourceInfoRefreshError will be reported by maskingMediaSource.maybeThrowPrepareError(), which is called each time doSomeWork() is called and the playing period is not yet prepared (EPII:L836). So the player is notified by source errors that way, which confirms removing the above calls is fine. PiperOrigin-RevId: 321331777
bachinger committed -
PiperOrigin-RevId: 321280295
insun committed -
PiperOrigin-RevId: 321218451
bachinger committed -
PiperOrigin-RevId: 321181453
aquilescanta committed -
It's only used in BandwidthMeter so inline it there. PiperOrigin-RevId: 321177126
ibaker committed -
Plumb this down into BaseRenderer.onStreamChanged and use it when deciding whether to render the first frame of a new period. PiperOrigin-RevId: 321175627
ibaker committed -
PiperOrigin-RevId: 321174738
ibaker committed -
This doesn't affect the nullness checker or Kotlin, but it does make weird warnings appear in Android Studio. It seems mildly preferable to have the same spurious warnings in these files that we have in other tests, rather than different spurious warnings. PiperOrigin-RevId: 321173760
ibaker committed -
PiperOrigin-RevId: 321169585
ibaker committed -
PiperOrigin-RevId: 321168965
ibaker committed
-