- 28 Jan, 2022 18 commits
-
-
This shouldn't be required for transformer instrumentation tests, as they don't use a foreground service. PiperOrigin-RevId: 424654463
andrewlewis committed -
The second error is probably a consequence of the first one. #minor-release PiperOrigin-RevId: 424619944
kimvde committed -
When the decoder output buffer was partially read, a call to Codec.getOutputBuffer() was returning the same buffer, but with the position reset to 0. The reason was that, in Codec.maybeDequeueAndSetOutputBuffer(), mediaCodec.getOutputBuffer() was called with the same buffer index (L350 in old rev), even though there was already a buffer available (outputBufferIndex >=0). This change avoids calling mediaCodec.getOutputBuffer() if the previous buffer has not been released. #minor-release PiperOrigin-RevId: 424612197
kimvde committed -
If the encoder picks a fallback resolution the video pipeline needs to take this into account when configuring the frameEditor and when setting up the fallback TransformationRequest that's passed to the fallbackListener. PiperOrigin-RevId: 424611290
hschlueter committed -
Move the code in its own class as DefaultAudioTrack is getting very big. It also help for testability. The new class is easily configurable and highly tested. Manual test was used to catch any regression. https://github.com/google/ExoPlayer/issues/8891 PiperOrigin-RevId: 424602011
krocard committed -
AnalyticsCollector can't be null when passed into ExoPlayerImplInternal, so there is no need to pass it around as nullable. PiperOrigin-RevId: 424594031
tonihei committed -
Two of the sessions are finished at the same time in the test and the order of the corresponding callbacks depends on the randomly generated session string and the order these strings are stored in a HashSet. Update test to assert both callbacks are called and they contain the right arguments, but don't assert on the order of these two callbacks. PiperOrigin-RevId: 424548819
tonihei committed -
Ad playback shouldn't be affected by manual speed adjustments set by the user. This change enforces unit speed for ad playback. Issue: google/ExoPlayer#9018 PiperOrigin-RevId: 424546258
tonihei committed -
This only affects playbacks using the experimentalUseProgressiveMediaSourceForSubtitles method. Also update the SingleSampleMediaSource instantiation to be more similar, to try and highlight differences like this in future. PiperOrigin-RevId: 424545980
ibaker committed -
In some cases we need to update the PlaybackParameters at period boundaries, for example when switching from live to VOD and live playback speed adjustment was still active at the point of switching. Currently, we send the update when the playing MediaPeriod changes in EPII, which is slightly too late because the new speed gets only applied after the entire existing AudioTrack buffer has been played out. We can time the update slightly better by updating the values at the point where we change the reading period. This makes the update slightly too early because it also applies to all samples currently in the decoder. But generally, this is a lot better because the time spent in the decoder is likely to be considerably lower than the duration of the AudioTrack buffer. Note that this change isn't perfectly aligning to the period boundary, but reduces the number of samples with the wrong speed to a minimum. If we are getting around to add additional code that allows updating the speed at exactly the boundary, it also needs to be triggered from the reading period update, so the new code location is also helpful in the future. Issue: google/ExoPlayer#9018 PiperOrigin-RevId: 424540551
tonihei committed -
When I locally link to exoplayer source modules as described in the README and I do this directly into a fig/citc client, I get an error saying "missing_aar_type_workaround.gradle': 79: unexpected token: || @ line 79, column 29.". I can fix this by wrapping the expression in parenthesis (¯\_(ツ)_/¯). I don't think this file lands in the public source tree, but if we want to correct this, it may help someone from the team. This CL can be ignored and reverted also. PiperOrigin-RevId: 424537619
bachinger committed -
PiperOrigin-RevId: 424383900
olly committed -
PiperOrigin-RevId: 424382031
Andrew Lewis committed -
PiperOrigin-RevId: 424379489
Andrew Lewis committed -
PiperOrigin-RevId: 424366617
ibaker committed -
PiperOrigin-RevId: 424355325
Andrew Lewis committed -
PiperOrigin-RevId: 424322341
claincly committed -
PiperOrigin-RevId: 424287392
samrobinson committed
-
- 25 Jan, 2022 22 commits
-
-
PiperOrigin-RevId: 424081451
ibaker committed -
PiperOrigin-RevId: 424062588
olly committed -
Issue: google/ExoPlayer#9811 PiperOrigin-RevId: 423855051
olly committed -
Issue: google/ExoPlayer#9811 PiperOrigin-RevId: 423849421
olly committed -
PiperOrigin-RevId: 423822317
kimvde committed -
* @CryptoType is a TYPE_USE annotation, so should appear after modifiers and directly before the type. (see go/java-style#s4.8.5-annotations) This CL looks good? Just LGTM and Approve it! This CL doesn’t look good? This is what you can do: * Revert this CL, by replying "REVERT: <provide reason>" * File a bug under go/error-prone-bug for category ErrorProneStyle if the change looks generally problematic. * Revert this CL and not get a CL that cleans up these paths in the future by replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to opt out the respective paths in your CL Robot configuration instead: go/clrobot-opt-out. This CL was generated by CL Robot - a tool that cleans up code findings (go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/java/com/google/android/libraries/media/METADATA which is reachable following include_presubmits from //depot/google3/third_party/java_src/android_libs/media/METADATA. Anything wrong with the signup? File a bug at go/clrobot-bug. #codehealth Tested: Local presubmit tests passed. PiperOrigin-RevId: 423821355olly committed -
PiperOrigin-RevId: 423819515
tonihei committed -
PiperOrigin-RevId: 423786422
olly committed -
#minor-release PiperOrigin-RevId: 423314840
kimvde committed -
This was resolved in https://github.com/google/ExoPlayer/commit/081700f72b2a43e1e0d01a0130cf283c7d59b9bc where the Video/AudioSamplePipeline call this method before calling the FallbackListener. PiperOrigin-RevId: 423284258
hschlueter committed -
Issue: google/ExoPlayer#9619 (and a few other GH issues related to invalid RTP-Info header) PiperOrigin-RevId: 423283017
claincly committed -
Issue: google/ExoPlayer#9775 We got a few issues for this on GH already. Some RTSP servers do not provide track timing in PLAY responses, or the timings are invalid. Missing timing means the RTSP stream is not seekable. Added method to 1. Update the timeline that seek is not possible 2. Report read discontinuity so that playback can start from the beginning. PiperOrigin-RevId: 423281439
claincly committed -
If the output sample MIME type is inferred from the input but is not supported by the muxer, we fallback to transcoding to a supported sample MIME type. The audio and video renderers need to make sure not to select the PassthroughSamplePipeline for this case. Which sample MIME type to choose is decided by the EncoderFactory. PiperOrigin-RevId: 423272812
hschlueter committed -
To avoid the `MediaPeriodQueue`to discard the reading period, we can set the next ad of an ad group early and then (possibly) only change it's duration once we receive the actual duration. This way we avoid a rebuffering as a result of the reading period being discarded. The change also takes care to properly set ad break and their durations when we join the live stream at the moment when an ad is playing. PiperOrigin-RevId: 423163467
bachinger committed -
We currently only end sessions on Timeline updates if the associated media is no longer in the playlist. But we should also end all sessions that are finished as a result of the timeline update (similar to how this is done for discontinuities). This issue was introduced by https://github.com/google/ExoPlayer/commit/394ab7bcfd53bc8ffb8d2e37a5aeb71fef04d13c PiperOrigin-RevId: 423075855
tonihei committed -
Links should use []() instead of ()[]. PiperOrigin-RevId: 423073748
tonihei committed -
We currently don't check which session is causing a network transfer (it could be a preloaded item in a playlist). To clearly associate network transfer data with sessions, we need to keep track of transferred bytes and transfer time per session. PiperOrigin-RevId: 422867845
tonihei committed -
We may fall back to a different sample MIME type because a) the sample MIME type inferred from the input is not supported by the muxer or b) no encoders are available for the the requested sample MIME type. PiperOrigin-RevId: 422849036
hschlueter committed -
With this change, the MediaCodecAudioRenderer configures the MediaCodec to not downmix audio only if spatialization can be applied. This way, decoders who are downmixing by default are left doing so when spatialization cannot be applied. The renderer re-initializes the codec when spatialization properties change mid-playback. PiperOrigin-RevId: 422822952
christosts committed -
TransformationRequest is otherwise immutable, so if we modify the transformationMatrix in place (done before this cl) this may cause confusing behaviour for apps when they reuse a TransformationRequest. PiperOrigin-RevId: 422822916
hschlueter committed -
Currently, we keep the values for dropped/played frames, audio underruns and current formats from the last session, causing double reporting of counters and wrong track change reasons for formats. All these values should be reset when the active session is finished, so that the new session can start from scratch. PiperOrigin-RevId: 422798406
tonihei committed -
Currently, we always end the current session if onSessionFinished is called. However, the finished session may not be the active one (for example when discarding prebuffered items in a playlist). To make this code more robust, we can save the active session id explicitly and only end this session. PiperOrigin-RevId: 422788542
tonihei committed
-